pauamma: Cartooney crab wearing hot pink and acid green facemask holding drink with straw (Default)
Res facta quae tamen fingi potuit ([personal profile] pauamma) wrote in [site community profile] changelog2009-03-09 09:05 pm

[dw-free] Allow self-messaging

[commit: http://hg.dwscoalition.org/dw-free/rev/bda589ff8b47]

http://bugs.dwscoalition.org/show_bug.cgi?id=463

Allow sending yourself a provate message.

Patch by [staff profile] denise.

Files modified:
  • bin/upgrading/deadphrases.dat
  • bin/upgrading/en.dat
  • cgi-bin/LJ/Message.pm
  • htdocs/inbox/compose.bml
--------------------------------------------------------------------------------
diff -r b849a06289a2 -r bda589ff8b47 bin/upgrading/deadphrases.dat
--- a/bin/upgrading/deadphrases.dat	Mon Mar 09 20:35:29 2009 +0000
+++ b/bin/upgrading/deadphrases.dat	Mon Mar 09 21:04:44 2009 +0000
@@ -672,3 +672,5 @@ general crumb.todo
 
 general setting.contentpromotion.label
 general setting.contentpromotion.option
+
+general error.message.yourself
\ No newline at end of file
diff -r b849a06289a2 -r bda589ff8b47 bin/upgrading/en.dat
--- a/bin/upgrading/en.dat	Mon Mar 09 20:35:29 2009 +0000
+++ b/bin/upgrading/en.dat	Mon Mar 09 21:04:44 2009 +0000
@@ -1333,8 +1333,6 @@ error.message.expunged=This message cann
 error.message.expunged=This message cannot be sent to [[ljuser]] because the journal has been deleted.
 
 error.message.individual=Message can only be sent to individual users, not [[ljuser]].
-
-error.message.yourself=Stop trying to message yourself, we're not that kind of service.
 
 error.nobutton=No button pressed?
 
diff -r b849a06289a2 -r bda589ff8b47 cgi-bin/LJ/Message.pm
--- a/cgi-bin/LJ/Message.pm	Mon Mar 09 20:35:29 2009 +0000
+++ b/cgi-bin/LJ/Message.pm	Mon Mar 09 21:04:44 2009 +0000
@@ -368,11 +368,6 @@ sub can_send {
     my $ou = $self->_orig_u;
     my $ru = $self->_rcpt_u;
 
-    # Can't send to yourself
-    if ($ou->equals($ru)) {
-        push @$errors, BML::ml('error.message.yourself');
-    }
-
     # Can only send to other individual users
     unless ($ru->is_person || $ru->is_identity) {
         push @$errors, BML::ml('error.message.individual', { 'ljuser' => $ru->ljuser_display });
diff -r b849a06289a2 -r bda589ff8b47 htdocs/inbox/compose.bml
--- a/htdocs/inbox/compose.bml	Mon Mar 09 20:35:29 2009 +0000
+++ b/htdocs/inbox/compose.bml	Mon Mar 09 21:04:44 2009 +0000
@@ -76,12 +76,6 @@ body<=
                 my $tou = LJ::load_user($to);
                 unless ($tou) {
                     push @errors, "\"$to\" is not a valid username";
-                    next;
-                }
-
-                # Can't send to yourself
-                if ($remote->equals($tou)) {
-                    push @errors, BML::ml('error.message.yourself');
                     next;
                 }
 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org