kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2009-09-02 04:20 am

[dw-free] Read page can breakc when viewing it while logged out

[commit: http://hg.dwscoalition.org/dw-free/rev/7e7aaa2e3474]

http://bugs.dwscoalition.org/show_bug.cgi?id=1741

Avoid checking unset $remote on logged out reading page.

Patch by [personal profile] afuna.

Files modified:
  • cgi-bin/LJ/S2/FriendsPage.pm
--------------------------------------------------------------------------------
diff -r a691d76be23c -r 7e7aaa2e3474 cgi-bin/LJ/S2/FriendsPage.pm
--- a/cgi-bin/LJ/S2/FriendsPage.pm	Tue Sep 01 18:33:30 2009 +0000
+++ b/cgi-bin/LJ/S2/FriendsPage.pm	Tue Sep 01 23:19:57 2009 -0500
@@ -230,7 +230,7 @@ sub FriendsPage
                                              'cuturl' => LJ::item_link($friends{$friendid}, $itemid, $item->{'anum'}, $stylemine),
                                              'maximgwidth' => $maximgwidth,
                                              'maximgheight' => $maximgheight,
-                                             'imageplaceundef' => $remote->{'opt_imageundef'},
+                                             'imageplaceundef' => $remote ? $remote->{'opt_imageundef'} : undef,
                                              'ljcut_disable' => $remote ? $remote->{'opt_cut_disable_reading'} : undef,
                                              'suspend_msg' => $suspend_msg,
                                              'unsuspend_supportid' => $suspend_msg ? $entry_obj->prop("unsuspend_supportid") : 0, });
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org