afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-08-16 12:17 pm

[dw-free] /manage/tags doesn't respect sort order of security groups

[commit: http://hg.dwscoalition.org/dw-free/rev/67e1042df080]

http://bugs.dwscoalition.org/show_bug.cgi?id=1615

Back out 0731d4800a20 pending discussion; previous sort order may have been
deliberate.

Patch by [personal profile] afuna.

Files modified:
  • htdocs/manage/tags.bml
--------------------------------------------------------------------------------
diff -r 0731d4800a20 -r 67e1042df080 htdocs/manage/tags.bml
--- a/htdocs/manage/tags.bml	Sun Aug 16 10:39:26 2009 +0000
+++ b/htdocs/manage/tags.bml	Sun Aug 16 12:16:36 2009 +0000
@@ -303,7 +303,7 @@ HEAD
 
     my $grouplist = $u->trust_groups;
     push @groups,  map  { "group:" . $_, $grouplist->{$_}->{groupname} }
-    sort { $grouplist->{$a}->{sortorder} <=> $grouplist->{$b}->{sortorder} }
+    sort { $grouplist->{$a}->{groupname} cmp $grouplist->{$b}->{groupname} }
     keys %$grouplist;
 
     my $security = LJ::Tags::get_permission_levels($u);
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org