mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2009-08-10 05:35 am

[js] cmd+click does not work for links in inbox

[commit: http://hg.dwscoalition.org/js/rev/be8fe80918d1]

http://bugs.dwscoalition.org/show_bug.cgi?id=613

Fix cmd+click for inbox links.

Patch by [personal profile] afuna.

Files modified:
  • selectable_table.js
--------------------------------------------------------------------------------
diff -r 86f06394454a -r be8fe80918d1 selectable_table.js
--- a/selectable_table.js	Mon Aug 10 05:25:44 2009 +0000
+++ b/selectable_table.js	Mon Aug 10 05:35:51 2009 +0000
@@ -91,9 +91,10 @@ SelectableTable = new Class(DataSource, 
         var self = this;
 
         var rowClicked = function (evt) {
-            // if it was a control-click, they're probably trying to open a new tab or something.
+            // if it was a control-click or a command-click
+            // they're probably trying to open a new tab or something.
             // let's not handle it
-            if (evt && evt.ctrlKey) return false;
+            if (evt && (evt.ctrlKey || evt.metaKey)) return false;
 
             var tagName = ele.tagName.toLowerCase();
 
--------------------------------------------------------------------------------