mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2009-07-22 01:52 am

[dw-free] links in comment pages with ?style=light in the URL point to style=mine, not style=light

[commit: http://hg.dwscoalition.org/dw-free/rev/f6f8ca5311a9]

http://bugs.dwscoalition.org/show_bug.cgi?id=1452

Address style=mine FIXMEs.

Patch by [personal profile] yvi.

Files modified:
  • htdocs/talkpost.bml
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r 93d7a82de65d -r f6f8ca5311a9 htdocs/talkpost.bml
--- a/htdocs/talkpost.bml	Wed Jul 22 01:48:56 2009 +0000
+++ b/htdocs/talkpost.bml	Wed Jul 22 01:52:33 2009 +0000
@@ -113,11 +113,7 @@ body<=
     my $itemid = $init->{'itemid'};
 
     my $formatlight = ( ( $GET{format} eq 'light' ) || ( $GET{style} eq 'light' ) ) ? 'style=light' : '';
-    my $stylemine = "";
-
-    # FIXME: $init->{style} returns 'mine' even if style=format is used instead of style=mine
-    # if that is fixed, this can be adjusted
-    $stylemine = ( $init->{style} eq "mine" ) ? "style=mine" : "" unless $formatlight;
+    my $stylemine = $init->{style} eq "mine" ? "style=mine" : "";
 
     ## load the journal item
     my $item = LJ::Talk::get_journal_item($u, $itemid);
diff -r 93d7a82de65d -r f6f8ca5311a9 htdocs/talkread.bml
--- a/htdocs/talkread.bml	Wed Jul 22 01:48:56 2009 +0000
+++ b/htdocs/talkread.bml	Wed Jul 22 01:52:33 2009 +0000
@@ -101,11 +101,7 @@ body<=
 
     # Get format/style parameters to pass to the URL later
     my $formatlight = ( ( $GET{format} eq 'light' ) || ( $GET{style} eq 'light' ) ) ? 'style=light' : '';
-    my $stylemine = "";
-
-    # FIXME: $init->{style} returns 'mine' even if style=format is used instead of style=mine
-    # if that is fixed, this can be adjusted
-    $stylemine = ( $init->{style} eq "mine" ) ? "style=mine" : "" unless $formatlight;
+    my $stylemine = $init->{style} eq "mine" ? "style=mine" : "";
 
     my $item = LJ::Talk::get_journal_item($u, $itemid);
 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org