mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2009-07-13 09:06 pm

[dw-free] Footer appears even when comments are enabled

[commit: http://hg.dwscoalition.org/dw-free/rev/429488b55141]

http://bugs.dwscoalition.org/show_bug.cgi?id=1417

Another fix for the xpost footer appearing when it shouldn't. This should
make it properly obedient.

Patch by [personal profile] ysobel.

Files modified:
  • cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm
--------------------------------------------------------------------------------
diff -r 2a5a2c6ea216 -r 429488b55141 cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm
--- a/cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm	Mon Jul 13 07:05:58 2009 +0000
+++ b/cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm	Mon Jul 13 21:06:48 2009 +0000
@@ -178,11 +178,12 @@ sub crosspost {
                 $footer_text = "\n\n" . LJ::Lang::ml( "xpost.redirect.comment", { postlink => $entry->url } );
             }
 
-        } elsif ( $xpostfootprop eq "D" && $disabling_comments ) {
+        } elsif ( $xpostfootprop eq "D" ) {
+
+            $adding_footer = 1 if $disabling_comments;
             # we are only adding a footer if comments are disabled
             # (and they are)
 
-            $adding_footer = 1;
             if ( $footer_text ) {
                 my $url = $entry->url;
                 $footer_text =~ s/%%url%%/$url/gi;
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
No Subject Icon Selected
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org