afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-16 05:13 pm

[dw-free] Select-all checkbox for unbanning users doesn't work; assumes specific site-scheme

[commit: http://hg.dwscoalition.org/dw-free/rev/5a7a2a1c0bcc]

http://bugs.dwscoalition.org/show_bug.cgi?id=335

Fix select-all checkbox for banning users and approving pending members.
Original bug report from LiveJournal.

Patch by [personal profile] wyntarvox.

Files modified:
  • htdocs/community/pending.bml
  • htdocs/manage/banusers.bml
--------------------------------------------------------------------------------
diff -r 800b3f476b9f -r 5a7a2a1c0bcc htdocs/community/pending.bml
--- a/htdocs/community/pending.bml	Sun May 17 00:50:24 2009 +0800
+++ b/htdocs/community/pending.bml	Sat May 16 17:12:18 2009 +0000
@@ -141,7 +141,7 @@ body<=
     @users = @{$items{items}};
 
     # output starts here
-    $ret .= "<form method='post' action='pending.bml?authas=$cname'>";
+    $ret .= "<form method='post' action='pending.bml?authas=$cname' name='pending_member_form'>";
     $ret .= LJ::form_auth();
 
     # jump to user
@@ -156,14 +156,14 @@ body<=
     $ret .= "<br /><div align='center'><table class='userslist-table' cellspacing='0' cellpadding='2'>\n<tr><th>";
     $ret .= LJ::html_check({ id => 'all', name => 'all', checked => 'checked', 
 	onchange =>
-		"var inputs = document.getElementById('content-wrapper').getElementsByTagName('input');
+		"var inputs = document.pending_member_form.getElementsByTagName('input');
 		for (var i = 0; i < inputs.length; i++) {
 			if (inputs[i].type == 'checkbox' && inputs[i].getAttribute('id') !== 'all') {
 				inputs[i].checked = this.checked;
 			}
 		}", 
 	onclick =>
-		"var inputs = document.getElementById('content-wrapper').getElementsByTagName('input');
+		"var inputs = document.pending_member_form.getElementsByTagName('input');
 		for (var i = 0; i < inputs.length; i++) {
 			if (inputs[i].type == 'checkbox' && inputs[i].getAttribute('id') !== 'all') {
 				inputs[i].checked = this.checked;
diff -r 800b3f476b9f -r 5a7a2a1c0bcc htdocs/manage/banusers.bml
--- a/htdocs/manage/banusers.bml	Sun May 17 00:50:24 2009 +0800
+++ b/htdocs/manage/banusers.bml	Sat May 16 17:12:18 2009 +0000
@@ -75,7 +75,7 @@ body<=
 
     $ret .= "<div style='margin-top: 20px;'>$submit_msg</div>";
 
-    $ret .= "<form action='$LJ::SITEROOT/manage/banusers.bml$getextra' method='post'>";
+    $ret .= "<form action='$LJ::SITEROOT/manage/banusers.bml$getextra' method='post' name='ban_users_form'>";
     $ret .= LJ::form_auth();
 
     # ban users
@@ -96,14 +96,14 @@ body<=
         $ret .= $u->is_community ? "<p>$ML{'.intro.unban.comm'}</p>" : "<p>$ML{'.intro.unban.self'}</p>";
         $ret .= "<table class='userslist-table' cellspacing=0 cellpadding=0><tr><th>";
         $ret .= LJ::html_check({ id => 'all', name => 'all', onchange =>
-                "var inputs=document.getElementById('content-wrapper').getElementsByTagName('input');
+                "var inputs=document.ban_users_form.getElementsByTagName('input');
                 for (var i = 0; i < inputs.length; i++) {
                     if (inputs[i].type == 'checkbox' && inputs[i].getAttribute('id') !== 'all') {
                         inputs[i].checked = this.checked;                  
                     } 
                 }",
 	            onclick=>
-                "var inputs=document.getElementById('content-wrapper').getElementsByTagName('input');
+                "var inputs=document.ban_users_form.getElementsByTagName('input');
                 for (var i = 0; i < inputs.length; i++) {
                     if (inputs[i].type == 'checkbox' && inputs[i].getAttribute('id') !== 'all') {
                         inputs[i].checked = this.checked;                  
--------------------------------------------------------------------------------