2020-08-09

[dreamwidth/dw-free] a5d792: Re-enable javascript in core1 with s2foundation fe...

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: a5d792526618dc1daf1a650b5fbee40d706a38a0 https://github.com/dreamwidth/dw-free/commit/a5d792526618dc1daf1a650b5fbee40d706a38a0 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M styles/core1.s2

Log Message:

Re-enable javascript in core1 with s2foundation features

To support newer components in journal styles, we needed to change how script tags enter the document. core2 already had room to do this without disrupting anything, but naturally core1 does not.

Since most legacy core1 layouts in the wild probably override Page::print(), they'll need to update their code to call $this->print_script_tags(); right before closing the body tag.

[dreamwidth/dw-free] 5a6d43: remove %LJ::SSL_DISABLED_URI

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 5a6d4334f09990c38422f0bf755e2157022b9097 https://github.com/dreamwidth/dw-free/commit/5a6d4334f09990c38422f0bf755e2157022b9097 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/Global/Defaults.pm

Log Message:

remove %LJ::SSL_DISABLED_URI

The comment says it was temporary, and it appears to be no longer used.

Commit: 99683a792b3864b6cb354076ba3baf3544502d71 https://github.com/dreamwidth/dw-free/commit/99683a792b3864b6cb354076ba3baf3544502d71 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/User/Account.pm

Log Message:

fix undefined variable warning in cgi-bin/LJ/User/Account.pm

Use of uninitialized value $uuserid in addition (+) at cgi-bin/LJ/User/Account.pm line 1761.

Commit: 843f2e0e81a92e975f42c19657158617e23c8f4d https://github.com/dreamwidth/dw-free/commit/843f2e0e81a92e975f42c19657158617e23c8f4d Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat

Log Message:

remove dead userinfo.bml strings

I was looking up a string on /admin/translate and happened to notice that most of the strings belonging to /userinfo.bml (the predecessor of profile.bml) never got added to deadphrases.

Commit: a6d1b14829fbb6f1eb5225ab6acafd08a16cc40d https://github.com/dreamwidth/dw-free/commit/a6d1b14829fbb6f1eb5225ab6acafd08a16cc40d Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/Global/Defaults.pm

Log Message:

remove unused config variable $LJ::MAX_FRIENDOF_LOAD

Looks like this was an earlier take on the FORCE_EMPTY_SUBSCRIPTIONS hack.

Commit: 82be65dd1ece0c1fdb1c03093fb12358cf0672ca https://github.com/dreamwidth/dw-free/commit/82be65dd1ece0c1fdb1c03093fb12358cf0672ca Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/maint/taskinfo.txt

Log Message:

remove undefined 'memeclean' reference from ljmaint taskinfo

I don't think we ever had code for this.

Commit: 095b6b2e420c98b521ccf0c9b61575185517a104 https://github.com/dreamwidth/dw-free/commit/095b6b2e420c98b521ccf0c9b61575185517a104 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/DW/Controller/Customize/Advanced.pm

Log Message:

fix undefined variable warning in cgi-bin/DW/Controller/Customize/Advanced.pm

Use of uninitialized value in pattern match (m//) at cgi-bin/DW/Controller/Customize/Advanced.pm line 236.

Commit: 33fe92b32319f8f812577d7935a06cff6997ead1 https://github.com/dreamwidth/dw-free/commit/33fe92b32319f8f812577d7935a06cff6997ead1 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M htdocs/support/see_request.bml M htdocs/support/see_request.bml.text

Log Message:

update link on see_request to target /help instead of /help.bml

Commit: c701c57869376d8500108c2deaedbc16031b6e32 https://github.com/dreamwidth/dw-free/commit/c701c57869376d8500108c2deaedbc16031b6e32 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/User/Account.pm

Log Message:

machete commented out code for default friend groups

Protocol still defines editfriendgroups but it just fails.

Commit: 674b7291167cb057c4312d3339f9508c4e60d87f https://github.com/dreamwidth/dw-free/commit/674b7291167cb057c4312d3339f9508c4e60d87f Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/Setting/Display/AccountStatus.pm

Log Message:

make actionlink for suspended accounts a link

It was doing something ineffective with aopts. Now it is a real link.

Commit: eb7408df45c6d408aaf1af0c74fb205edcb28e14 https://github.com/dreamwidth/dw-free/commit/eb7408df45c6d408aaf1af0c74fb205edcb28e14 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/proplists.dat M cgi-bin/LJ/User/Journal.pm

Log Message:

remove userprop third_party_notify_list and related unused methods

Commit: c7351f32e86e29d5caa4b1d2aec4bcc773b53d41 https://github.com/dreamwidth/dw-free/commit/c7351f32e86e29d5caa4b1d2aec4bcc773b53d41 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M views/admin/propedit.tt

Log Message:

fix textarea with no id in views/admin/propedit.tt

Use of uninitialized value in concatenation (.) or string at cgi-bin/DW/Template/Plugin/FormHTML.pm line 438.

Compare: https://github.com/dreamwidth/dw-free/compare/a5d792526618...c7351f32e86e

[dreamwidth/dw-free] aada0c: fix missing strings from converting /shop/receipt ...

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: aada0cfd4b3313c6e1a3d6cde36a2d4a08afe86c https://github.com/dreamwidth/dw-free/commit/aada0cfd4b3313c6e1a3d6cde36a2d4a08afe86c Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/shop/history.bml M views/admin/pay/vieworder.tt M views/admin/pay/viewuser.tt

Log Message:

fix missing strings from converting /shop/receipt to TT

Commit: 2ced1a5bf4409f299b85bd36568641466092e926 https://github.com/dreamwidth/dw-free/commit/2ced1a5bf4409f299b85bd36568641466092e926 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M views/admin/pay/vieworder.tt M views/admin/pay/vieworder.tt.text

Log Message:

fix another sad shop conversion bug

The template passed an empty string instead of undef to the SQL query, with undesired results.

Compare: https://github.com/dreamwidth/dw-free/compare/c7351f32e86e...2ced1a5bf440

[dreamwidth/dw-free] 14e877: [#2791] siteskin entry preview tweaks

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 14e877ec538f21c1d39d020ea1a90513601e0893 https://github.com/dreamwidth/dw-free/commit/14e877ec538f21c1d39d020ea1a90513601e0893 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M views/entry/preview.tt

Log Message:

[#2791] siteskin entry preview tweaks

[dreamwidth/dw-free] 6403e2: Restore space between body and crosspost footer

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 6403e2b7d9bd55425e1346178f3d3b6fc107a782 https://github.com/dreamwidth/dw-free/commit/6403e2b7d9bd55425e1346178f3d3b6fc107a782 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/DW/External/XPostProtocol.pm

Log Message:

Restore space between body and crosspost footer

We now pre-process all our autoformatting and send the result to LJ-alikes as opt_preformatted, so we can do things they don't support and not have to maintain a working understanding of THEIR auto-formatting.

Crosspost footer was expecting to land in NON-preformatted text tho, and gets jammed onto the end of the last sentence if the post is being treated as raw HTML. Presumably this already used to break on preformatted crossposts, so I'm surprised we didn't hear about it before, but anyway, now it hits everything so let's fix.

[dreamwidth/dw-free] 0c84f7: test commafy without ljlib (#2818)

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 0c84f7bf8f4e8ee96c18ba3142e20ae1c1bbbe8f https://github.com/dreamwidth/dw-free/commit/0c84f7bf8f4e8ee96c18ba3142e20ae1c1bbbe8f Author: Martin DeMello mdemello@google.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M t/commafy.t M t/lib/ljtestlib.pl

Log Message:

test commafy without ljlib (#2818)

test commafy without ljlib
don't use my sub

[dreamwidth/dw-free] 64115c: Site skin comments: Attempt to fix the wooz

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 64115c34b2629c1795d89d84125091ba85cf50b6 https://github.com/dreamwidth/dw-free/commit/64115c34b2629c1795d89d84125091ba85cf50b6 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/scss/skins/entry-styles.scss M htdocs/scss/skins/journal-typography.scss

Log Message:

Site skin comments: Attempt to fix the wooz

Attempting to fix some vertigo issues reported with the new site skin comments, working on a hypothesis that it involves some combination of line length and spacing.

This shrinks the average line length of entries and top-level comments by about ten or fifteen characters per line, at least with the default font (verdana). It also adds some vertical spacing around the body of a comment.

[dreamwidth/dw-nonfree] fa7cf3: Tropos: reduce background brightness

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-nonfree Commit: fa7cf308b71ca3f6b03e2ee824981256102600c5 https://github.com/dreamwidth/dw-nonfree/commit/fa7cf308b71ca3f6b03e2ee824981256102600c5 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/scss/skins/tropo/tropo-purple.scss M htdocs/scss/skins/tropo/tropo-red.scss

Log Message:

Tropos: reduce background brightness

Changes to spacing on comment pages seem to cause an illusion that the new #f7f7f7 is brighter than the old #f7f7f7. Reduce brightness to compensate?

Commit: d30a3df06a6e22287be4c083fc3fe441037aa9f9 https://github.com/dreamwidth/dw-nonfree/commit/d30a3df06a6e22287be4c083fc3fe441037aa9f9 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/scss/skins/tropo/tropo-purple.scss M htdocs/scss/skins/tropo/tropo-red.scss

Log Message:

Darken Tropo header font color

This is a bit too dim, under some circumstances.

Compare: https://github.com/dreamwidth/dw-nonfree/compare/75ac6358867a...d30a3df06a6e

[dreamwidth/dw-nonfree] 1eb42b: Nicer site-schemed comment page links in Tropo

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-nonfree Commit: 1eb42b5f9099048ab9175bb46b805527175f735f https://github.com/dreamwidth/dw-nonfree/commit/1eb42b5f9099048ab9175bb46b805527175f735f Author: Ruth momijizukamori@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/scss/skins/tropo/tropo-purple.scss M htdocs/scss/skins/tropo/tropo-red.scss

Log Message:

Nicer site-schemed comment page links in Tropo

[dreamwidth/dw-free] ac8755: Fix mobile blowouts on Drifting

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: ac8755ae7335c7604fe9c5e2ba700624bf7b7364 https://github.com/dreamwidth/dw-free/commit/ac8755ae7335c7604fe9c5e2ba700624bf7b7364 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M styles/drifting/layout.s2

Log Message:

Fix mobile blowouts on Drifting

This hack seems to have been an old version of the modern hack I replaced it with. The drawback of the old one is that it doesn't constrain the widths of the table 'cells', so a long preformatted string of example CSS code or whatever will blast your flist page off for Mars. Using flex lets it respect the per-entry overflow: auto it already has for avoiding blowouts.

[dreamwidth/dw-free] 548b93: use sitescheme error pages in LJ::make_journal

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 548b93a5847b1f889be48eb7999da3773eaf04f0 https://github.com/dreamwidth/dw-free/commit/548b93a5847b1f889be48eb7999da3773eaf04f0 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/User/Styles.pm

Log Message:

use sitescheme error pages in LJ::make_journal

This uses the new suspended.tt and purged.tt templates for the relevant error page displays.

Commit: 878e46c32efcf7b5801c528b2ed0e23cec2d0909 https://github.com/dreamwidth/dw-free/commit/878e46c32efcf7b5801c528b2ed0e23cec2d0909 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/en.dat M cgi-bin/LJ/User/Styles.pm A views/error/suspended-entry.tt

Log Message:

add sitescheme error template for viewing a suspended entry

Not sure how the error.suspended.entry string came to be defined in production but not in en.dat. I got it copied over, though.

Commit: 97c03b03ff3037ee4a95faf2635da33df61a3ae8 https://github.com/dreamwidth/dw-free/commit/97c03b03ff3037ee4a95faf2635da33df61a3ae8 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/en.dat M cgi-bin/Apache/LiveJournal.pm M cgi-bin/LJ/User/Styles.pm A views/error/unknown-user.tt

Log Message:

[#2177] add sitescheme error template for 404 no such user

Tagging #2177 because I consider Foundation sitescheme rendering an improvement, but the error text hasn't really changed.

Commit: 4d753ec02ee1377b7bba458a4ec5f7bb9ad29b58 https://github.com/dreamwidth/dw-free/commit/4d753ec02ee1377b7bba458a4ec5f7bb9ad29b58 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/en.dat M cgi-bin/LJ/User/Styles.pm A views/error/openid-user.tt

Log Message:

add sitescheme error template for viewing the journal of an ext_xxx user

Commit: 47ddc816ca115635de2a9c707ccf12d58153077e https://github.com/dreamwidth/dw-free/commit/47ddc816ca115635de2a9c707ccf12d58153077e Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M bin/upgrading/en.dat M cgi-bin/LJ/User/Styles.pm A views/error/tagview.tt

Log Message:

add sitescheme error template for tag view errors and refactor

Commit: 23312c997c300ba1aaa97d300c5fdae497a6593f https://github.com/dreamwidth/dw-free/commit/23312c997c300ba1aaa97d300c5fdae497a6593f Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/User/Styles.pm

Log Message:

show sitescheme error when user can't view their network page

Commit: d897da19016ad4062700dde7ca67bff4ffee4afe https://github.com/dreamwidth/dw-free/commit/d897da19016ad4062700dde7ca67bff4ffee4afe Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M bin/upgrading/en.dat M cgi-bin/LJ/User/Styles.pm

Log Message:

remove unused string error.vhost.nocomm

When invoking badargs, the return value is ignored.

Commit: 681efb029c5834ed3bb3c0de0ff909b1b5275bfe https://github.com/dreamwidth/dw-free/commit/681efb029c5834ed3bb3c0de0ff909b1b5275bfe Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/User/Styles.pm A views/error/vhost.tt

Log Message:

replace $notice with $error using sitescheme error template

Compare: https://github.com/dreamwidth/dw-free/compare/ac8755ae7335...681efb029c58

[dreamwidth/dw-free] b0c8ef: Various new site skin fixes

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: b0c8effb6f679674222fd5b9a40abdf79260793a https://github.com/dreamwidth/dw-free/commit/b0c8effb6f679674222fd5b9a40abdf79260793a Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/scss/skins/entry-styles.scss M htdocs/scss/skins/journal-typography.scss M htdocs/scss/skins/_reply-form-styles.scss

Log Message:

Various new site skin fixes

The border colors on comment headers were wonky after re-adding the color alternation. (One of them was half-highlight-color, half-black). Fixed by exploding "border-bottom" into its constituent parts. (The "combined" border properties implicitly set border-color to currentcolor, which is black-ish.)
Add padding to .comment-info (comment header) boxes.
Reduce the space we waste for absent comment headers on mobile.
We shouldn't mess with table styles in Lynx (since they're browser default anyway), so move that out of the "need this to display comment pages" file and into the "fix bad Foundation behavior for thick siteskins" file.
Remove default Foundation styling for textareas in entries (which are used to share code).
Fix a rare issue where the height of the comment form textarea got compressed. (Only affects highly obsolete browsers.)

[dreamwidth/dw-free] 92db27: remove ineffective editjournal feature action:save...

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 92db2792db71e68e440b4f28b6bd93770f4cc806 https://github.com/dreamwidth/dw-free/commit/92db2792db71e68e440b4f28b6bd93770f4cc806 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M bin/upgrading/en.dat M bin/upgrading/proplists.dat M cgi-bin/DW/Controller/Entry.pm M cgi-bin/DW/Controller/RPC/CutExpander.pm M cgi-bin/LJ/CleanHTML.pm M cgi-bin/LJ/Console/Command/Unsuspend.pm M cgi-bin/LJ/Entry.pm M cgi-bin/LJ/Web.pm M htdocs/editjournal.bml M htdocs/editjournal.bml.text

Log Message:

remove ineffective editjournal feature action:saveunsuspend

The intent of this feature was to automatically open a new support request when a suspended entry was edited to remove offending content. This had no effect because $LJ::UNSUSPENSION_REQUEST_SPCATID was never set.

Most of the actual changes here are related to removing the unsuspend_supportid entryprop, intended to link the suspended entry and the support request.

[dreamwidth/dw-free] 5705ec: move loggedout_support_requests error to error_ml ...

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 5705ec04d5dfa603d0d1a799dadace19415e08e6 https://github.com/dreamwidth/dw-free/commit/5705ec04d5dfa603d0d1a799dadace19415e08e6 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M cgi-bin/DW/Controller/Support/Submit.pm M views/support/submit.tt M views/support/submit.tt.text

Log Message:

move loggedout_support_requests error to error_ml in controller

Commit: e620bb7b86eea1a0166076f9ced777d7df0ac209 https://github.com/dreamwidth/dw-free/commit/e620bb7b86eea1a0166076f9ced777d7df0ac209 Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/deadphrases.dat M cgi-bin/DW/Controller/Support/Submit.pm M views/support/submit.tt M views/support/submit.tt.text

Log Message:

remove language selection code from request form

This can never work because %LJ::LANGS_FOR_SUPPORT_REQUESTS is undefined, and support_request_language is disabled by default anyway.

Commit: 2aae96e56d69c8efb02e8a4ce0031edfecc267df https://github.com/dreamwidth/dw-free/commit/2aae96e56d69c8efb02e8a4ce0031edfecc267df Author: Kareila kareila@dreamwidth.org Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M views/support/submit.tt

Log Message:

convert /support/submit to Foundation

Compare: https://github.com/dreamwidth/dw-free/compare/92db2792db71...2aae96e56d69

[dreamwidth/dw-free] 225139: Sort the array returned by $userpic->keywords

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: 2251399a8c22d57f19ceca5e3fcfc1601d35d863 https://github.com/dreamwidth/dw-free/commit/2251399a8c22d57f19ceca5e3fcfc1601d35d863 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/LJ/Userpic.pm

Log Message:

Sort the array returned by $userpic->keywords

There's an original order for the submitted keywords stored somewhere... but because we sort alphabetically when building the text field for changing the icon's keywords, that order effectively does not exist. Since it doesn't exist, we should expose it Nowhere, and consistently alphabetize.

Commit: a4e558d720f737b29f0e7cfe7005cb92b3d03371 https://github.com/dreamwidth/dw-free/commit/a4e558d720f737b29f0e7cfe7005cb92b3d03371 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M bin/upgrading/proplists.dat M cgi-bin/DW/Controller/Entry.pm M cgi-bin/DW/Controller/RPC/IconBrowserOptions.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/User/Permissions.pm M cgi-bin/LJ/Web.pm M htdocs/js/jquery.replyforms.js M views/entry/form.tt M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

New userprop: iconbrowser_keyword order

This commit adds a new prop for sorting the icon browser by keyword instead of date, and wires it through all of the perl and TT stuff for things that invoke the icon browser or act on that userprop.

Commit: 026efca1fedd8e0221b0b7f5648b2923692579f9 https://github.com/dreamwidth/dw-free/commit/026efca1fedd8e0221b0b7f5648b2923692579f9 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/scss/components/icon-browser.scss M views/components/icon-browser.tt

Log Message:

Icon browser: Enable sort by keyword order, change toggles to radio buttons

Bask in the analog warmth of plain-ass web controls. Ahhhh.
I'm using custom events to trigger the sorting, due to the slightly odd design of that Options object -- it holds a reference to the modal's HTML element, but can't access very much of its internal state, so it needs to send a message indirectly if it's doing anything wilder than just setting a CSS class on the container.

Commit: 9da1bafeaa6116bb825421edb9262713ee3bcacd https://github.com/dreamwidth/dw-free/commit/9da1bafeaa6116bb825421edb9262713ee3bcacd Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M views/journal/quickreply.tt M views/journal/talkform.tt

Log Message:

Icon browser: Focus message body after dismissal, for comments

For the create entries page, I'm leaving focus on the icon selector, since the page is more spread out and modularized.

Commit: c0d5c7ede49daa819869fcc0f65133eebf02f6a0 https://github.com/dreamwidth/dw-free/commit/c0d5c7ede49daa819869fcc0f65133eebf02f6a0 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M htdocs/js/components/jquery.icon-browser.js M htdocs/scss/components/icon-browser.scss

Log Message:

Icon browser: Visual and behavioral revisions

No text means no text: Yank the keywords menu that appeared below the active icon in no-text mode. This was there to support a workflow that the browser's previous design also bent over backwards to enable (picking a specific keyword for a multi-keyword icon while in no-text mode), but on investigation with some of the userbase, it turned out maybe no one actually wanted that workflow.
Yes text means less text: Yank the "comment" text, which wastes a ton of precious space and which (while interesting in its home context on the icons page) isn't relevant to choosing which icon to use for this post.
One-click and done: As best as I can tell, the icon browser's two-clicks-to-finish interaction was only ever there to accommodate the "pick specific keyword from no-text" workflow, which is now gone. So let's cut the clicks in half: clicking an icon selects its first keyword, and clicking a keyword in yes-text mode selects that keyword. This also lets us remove the "Select" button entirely, which saves some space and kills off a source of jump-around annoyance.
Revised markup: we're now using normal button elements to represent the clickable icon and keyword buttons, instead of mutant <a> elements with an aria role set. This gives better tab and focus behavior in some browsers (Firefox uses a better focus ring style for buttons than for mutant tabbables), and ought to yield better accessibility. Required a mass of knock-on changes everywhere in the JS and CSS, naturally.
Focus previous icon: Previous design was to focus the search field when summoning the icon browser (except it was unreliable so I fixed it). This amends that, so that if you already selected an icon (either with the browser or the menu), that icon's button gets focused when summoning the browser again. That way, you can use tab to navigate nearby icons. AS A WILD BONUS, it turns out that in some browsers (desktop FF and Safari, so far) this scrolls the currently selected icon into view, so if you accidentally chose the wrong icon when you wanted the one next to it, you're in perfect position to switch your pick if you open the browser again.
Minor filter tweaks: Now that we're doing one-click-and-done, the intermediate "selected" state doesn't really mean anything (except when indicating the current value of the actual form element). So I changed the search filter to not change the "selected" state. For an all-keyboard flow, just tab out of the search field to focus the desired icon instead of filtering down to exactly one and hitting enter.
Visual updates: Centering and aligning things a bit more nicely, and revising the "small + text" mode to hopefully waste less space.

Commit: 140ffda28a92fe32dcb889afe9f10caefaac2797 https://github.com/dreamwidth/dw-free/commit/140ffda28a92fe32dcb889afe9f10caefaac2797 Author: Nick Fagerlund nick.fagerlund@gmail.com Date: 2020-08-09 (Sun, 09 Aug 2020)

Changed paths: M cgi-bin/DW/Controller/Entry.pm M cgi-bin/LJ/Talk.pm M cgi-bin/LJ/Web.pm

Log Message:

Tidy

Compare: https://github.com/dreamwidth/dw-free/compare/2aae96e56d69...140ffda28a92