[dreamwidth/dw-free] 6e82fe: Fix failing comment-create.t

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 6e82fedde483857d20523ee031af18dec9a90765
https://github.com/dreamwidth/dw-free/commit/6e82fedde483857d20523ee031af18dec9a90765
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Protocol.pm
M t/comment-create.t

Log Message:
-----------
Fix failing comment-create.t

- First problem: Legit!! I forgot to add an early exit to LJ::Comment::create
when it's called without a ditemid. Previously, this would blow up slightly
later during LJ::Talk::Post::init and then create would return a generic error,
but because LJ::Entry::new explodes without it, we need to handle it earlier.
Could result in uninformative errors in both LJ::Comment::create and the Talk
controller.

- Second problem: Annoying. The test is looking for specific error codes, which
means if you give it input that's illegal in MULTIPLE ways, you're really
testing the ORDER in which it checks things, which I struggle to believe anyone
actually cares about. Well, oh well.

[dreamwidth/dw-free] 77763f: [#2681] Don't break mapid -> pic lookups just beca...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 77763f87ac63c9003568f2ffc468246f79709e80
https://github.com/dreamwidth/dw-free/commit/77763f87ac63c9003568f2ffc468246f79709e80
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/LJ/User/Icons.pm

Log Message:
-----------
[#2681] Don't break mapid -> pic lookups just because keyword is empty

This misplaced "next" statement was bailing out before mapid housekeeping
finished, making it so userpics without keywords were never shown in comments.
(Although their keywords would appear in hovertext on the default icon. Since we
finished SOME of the mapid housekeeping before being interrupted,
get_keyword_from_mapid worked fine, even though get_picid_from_mapid didn't.)

[dreamwidth/dw-free] a717ae: Escape data attributes in _html_option

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: a717aeee16d6a6295957a9cdeef0abcbc7582967
https://github.com/dreamwidth/dw-free/commit/a717aeee16d6a6295957a9cdeef0abcbc7582967
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/LJ/HTMLControls.pm

Log Message:
-----------
Escape data attributes in _html_option

Looks like this was just forgotten when the feature was added. Only got noticed
when we started setting data attributes in the userpic menu to wrangle the icon
preview in reply forms.

I'm using the same $ehtml argument that sets escaping for values and text, since
I can't conceive of a situation where we'd want the one escaped but not the
other.

[dreamwidth/dw-free] 26eced: convert /admin/sysban

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 26eced8e21d0aaa2755f57e1f54a8c00b7d13771
https://github.com/dreamwidth/dw-free/commit/26eced8e21d0aaa2755f57e1f54a8c00b7d13771
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
A cgi-bin/DW/Controller/Admin/Sysban.pm
R htdocs/admin/sysban.bml
A views/admin/sysban/addnew.tt
A views/admin/sysban/addnew.tt.text
A views/admin/sysban/index.tt
A views/admin/sysban/index.tt.text
A views/admin/sysban/query.tt
A views/admin/sysban/query.tt.text

Log Message:
-----------
convert /admin/sysban


Commit: 5edcdaed258698cdcf5cd55948b1d8332c40732b
https://github.com/dreamwidth/dw-free/commit/5edcdaed258698cdcf5cd55948b1d8332c40732b
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/Admin/Sysban.pm
M views/admin/sysban/addnew.tt.text
M views/admin/sysban/index.tt.text
M views/admin/sysban/query.tt.text

Log Message:
-----------
use render_success instead of success_ml

I didn't realize (or had forgotten) that there were two different versions of the success page defined. Use the newer one with Foundation styling.


Commit: b0ca0a85533592068ea2daaaa6fbd4abce894e50
https://github.com/dreamwidth/dw-free/commit/b0ca0a85533592068ea2daaaa6fbd4abce894e50
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Admin.pm
M views/admin/index.tt.text

Log Message:
-----------
remove /admin/sysban from legacy index


Compare: https://github.com/dreamwidth/dw-free/compare/a717aeee16d6...b0ca0a855335

[dreamwidth/dw-free] 34a89c: convert openid/login.bml to TT

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 34a89c7b89a8f2bf3f918fbffdc4254e5525f3f8
https://github.com/dreamwidth/dw-free/commit/34a89c7b89a8f2bf3f918fbffdc4254e5525f3f8
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
M cgi-bin/DW/Controller/Talk.pm
M cgi-bin/LJ/User/Account.pm
R htdocs/openid/login.bml
R htdocs/openid/login.bml.text
A views/openid/login.tt.text

Log Message:
-----------
convert openid/login.bml to TT


Commit: f7ed3b0a0538b244eb5a2d160ff5101a47c9d5dd
https://github.com/dreamwidth/dw-free/commit/f7ed3b0a0538b244eb5a2d160ff5101a47c9d5dd
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-06-06 (Sat, 06 Jun 2020)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
R htdocs/openid/approve.bml
R htdocs/openid/approve.bml.text
A views/openid/approve.tt
A views/openid/approve.tt.text

Log Message:
-----------
convert openid/approve.bml to TT


Compare: https://github.com/dreamwidth/dw-free/compare/b0ca0a855335...f7ed3b0a0538