Jan. 28th, 2017

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: 36547d6046e17ef4ba073a8c16a21ac153848b40
https://github.com/dreamwidth/dw-free/commit/36547d6046e17ef4ba073a8c16a21ac153848b40
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-09-29 (Thu, 29 Sep 2016)

Changed paths:
M cgi-bin/LJ/Capabilities.pm

Log Message:
-----------
fix undefined warning in LJ/Capabilities.pm

Use of uninitialized value $name in string ne ... cgi-bin/LJ/Capabilities.pm line 123.

I was seeing this whenever loading support/see_request when
the user was opted into the updatepage beta.


Commit: 6064083a3d0a998a3ea68590fe57c79caad95266
https://github.com/dreamwidth/dw-free/commit/6064083a3d0a998a3ea68590fe57c79caad95266
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-09-29 (Thu, 29 Sep 2016)

Changed paths:
M cgi-bin/LJ/S2.pm

Log Message:
-----------
fix undefined warning in LJ/S2.pm

Use of uninitialized value in subroutine entry ... cgi-bin/LJ/S2.pm line 300.

Was seeing this when previewing a theme.


Commit: c09b2fa0709935e041daec25aea67a5d741b810a
https://github.com/dreamwidth/dw-free/commit/c09b2fa0709935e041daec25aea67a5d741b810a
Author: Ruth <ruth.s.hatch@gmail.com>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M styles/practicality/layout.s2

Log Message:
-----------
Practicality color props now sort properly in wizard. Fixes #1893


Commit: 611e73bf02830661c8562a572b4691ce5bf7c099
https://github.com/dreamwidth/dw-free/commit/611e73bf02830661c8562a572b4691ce5bf7c099
Author: Mark Smith <mark@qq.is>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M styles/practicality/layout.s2

Log Message:
-----------
Merge pull request #1912 from rshatch/1893/PracticalityPropgroups

Practicality color props now sort properly in wizard. Fixes #1893


Commit: 366b99da17ee508c0f93deba3c2fa6b3922ea1b9
https://github.com/dreamwidth/dw-free/commit/366b99da17ee508c0f93deba3c2fa6b3922ea1b9
Author: Ruth <ruth.s.hatch@gmail.com>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M styles/drifting/layout.s2

Log Message:
-----------
QuickReply box appears in appropriate location in Drifting

Adds the print_entry_footer code form core2 into Drifting to
give proper targets for the QuickReply box to anchor to.

Fixes #1509


Commit: 9134d6343548318bcbae42f212275d031164758a
https://github.com/dreamwidth/dw-free/commit/9134d6343548318bcbae42f212275d031164758a
Author: Mark Smith <mark@qq.is>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M styles/drifting/layout.s2

Log Message:
-----------
Merge pull request #1914 from rshatch/1609/DriftingQR

QuickReply box appears in appropriate location in Drifting


Commit: de0edab377718fb4b20b60b09e5a9456bdc919c6
https://github.com/dreamwidth/dw-free/commit/de0edab377718fb4b20b60b09e5a9456bdc919c6
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M cgi-bin/LJ/DB.pm

Log Message:
-----------
handle not using active-active clusters in prod


Commit: 09f4e0396bc43bc35ae59621e00fc44de4833ef5
https://github.com/dreamwidth/dw-free/commit/09f4e0396bc43bc35ae59621e00fc44de4833ef5
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M cgi-bin/LJ/DB.pm

Log Message:
-----------
defined %hash is deprecated


Commit: ea58c6d7dae14622027bb4070cd3422581f2858c
https://github.com/dreamwidth/dw-free/commit/ea58c6d7dae14622027bb4070cd3422581f2858c
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M cgi-bin/LJ/DB.pm

Log Message:
-----------
start removing master-master support


Commit: e03b794ddc6b97d3a3003e66934d09a4ed61e4e5
https://github.com/dreamwidth/dw-free/commit/e03b794ddc6b97d3a3003e66934d09a4ed61e4e5
Author: Mark Smith <mark@qq.is>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M cgi-bin/LJ/DB.pm

Log Message:
-----------
Merge pull request #1916 from alierak/foreach_cluster_ms_1909

handle not using active-active clusters in prod


Commit: 92253b70b2c0f2eb293747295a70ed1ef1fe56c2
https://github.com/dreamwidth/dw-free/commit/92253b70b2c0f2eb293747295a70ed1ef1fe56c2
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M views/stats/site.tt

Log Message:
-----------
[#1909] don't divide by zero when undefined

In Template Toolkit, undefined does not equal zero, so test for both.

Fixes #1909.


Commit: 7d5dcb23b004f2d75f8819d23026479e6be91864
https://github.com/dreamwidth/dw-free/commit/7d5dcb23b004f2d75f8819d23026479e6be91864
Author: Mark Smith <mark@qq.is>
Date: 2016-12-27 (Tue, 27 Dec 2016)

Changed paths:
M views/stats/site.tt

Log Message:
-----------
Merge pull request #1918 from kareila/1909-dividebyzero

[#1909] don't divide by zero when undefined


Commit: 6a78f416a91bc2ad5f59c360d82314b3015b93b9
https://github.com/dreamwidth/dw-free/commit/6a78f416a91bc2ad5f59c360d82314b3015b93b9
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2016-12-28 (Wed, 28 Dec 2016)

Changed paths:
M bin/worker/sphinx-search-gm

Log Message:
-----------
use dummy encoders for sphinx, strings are already utf8


Commit: bdde64d0cb57c8fdf3fcf994ffb722f0ee140bf0
https://github.com/dreamwidth/dw-free/commit/bdde64d0cb57c8fdf3fcf994ffb722f0ee140bf0
Author: Mark Smith <mark@qq.is>
Date: 2016-12-28 (Wed, 28 Dec 2016)

Changed paths:
M bin/worker/sphinx-search-gm

Log Message:
-----------
Merge pull request #1919 from alierak/sphinx_already_utf8

use dummy encoders for sphinx, strings are already utf8


Commit: d408b7af14aa5814aae265f34a6607a7389a8d68
https://github.com/dreamwidth/dw-free/commit/d408b7af14aa5814aae265f34a6607a7389a8d68
Author: hotlevel4 <hotlevel4@hotmail.com>
Date: 2016-12-29 (Thu, 29 Dec 2016)

Changed paths:
A cgi-bin/DW/Controller/Support/Index.pm
R htdocs/support/index.bml
R htdocs/support/index.bml.text
A views/support/index.tt
A views/support/index.tt.text

Log Message:
-----------
(Issue 1046) Convert Support Index to TT and Foundation

As stated above.


Commit: 12a5148c2b4177b2cb257b54a64b6bf1861c127e
https://github.com/dreamwidth/dw-free/commit/12a5148c2b4177b2cb257b54a64b6bf1861c127e
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-12-31 (Sat, 31 Dec 2016)

Changed paths:
M bin/worker/sphinx-copier
R cgi-bin/LJ/DBUtil.pm

Log Message:
-----------
[#1917] remove DBUtil.pm


Commit: f4a60aacbe59a5253f8e53e7de3effd4058002b7
https://github.com/dreamwidth/dw-free/commit/f4a60aacbe59a5253f8e53e7de3effd4058002b7
Author: Mark Smith <mark@qq.is>
Date: 2017-01-01 (Sun, 01 Jan 2017)

Changed paths:
M bin/worker/sphinx-copier
R cgi-bin/LJ/DBUtil.pm

Log Message:
-----------
Merge pull request #1922 from kareila/1917-dbutil

[#1917] remove DBUtil.pm


Commit: fecfac041722197e80bdccd0ac754d3f54f83c64
https://github.com/dreamwidth/dw-free/commit/fecfac041722197e80bdccd0ac754d3f54f83c64
Author: Mark Smith <mark@qq.is>
Date: 2017-01-01 (Sun, 01 Jan 2017)

Changed paths:
M cgi-bin/LJ/Capabilities.pm
M cgi-bin/LJ/S2.pm

Log Message:
-----------
Merge pull request #1923 from kareila/cleanup-2016q4

Cleanup 2016q4


Commit: bd33881b7136064c89a0f1770bd5db096f476dd1
https://github.com/dreamwidth/dw-free/commit/bd33881b7136064c89a0f1770bd5db096f476dd1
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/DW/Pay.pm
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
Safer payments

Fix an issue where preload_props could get no database handle and
wouldn't fail immediately (but would instead fail two lines later).
Also, make the payment system catch failures in the post-payment tasks
and not fail hard.


Commit: 711bc2d38d40753c098b32815f884d702e9a69ac
https://github.com/dreamwidth/dw-free/commit/711bc2d38d40753c098b32815f884d702e9a69ac
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/DW/External/Userinfo.pm

Log Message:
-----------
add stats collection for resolve-extacct

If my understanding of DW::Stats is correct, this should report
resolve-extacct successes and failures to Datadog or similar.


Commit: b65e3d55f583d86303fc593b379bea66177b9a5e
https://github.com/dreamwidth/dw-free/commit/b65e3d55f583d86303fc593b379bea66177b9a5e
Author: Mark Smith <mark@qq.is>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/DW/External/Userinfo.pm

Log Message:
-----------
Merge pull request #1925 from kareila/extacct_stats

add stats collection for resolve-extacct


Commit: c7f0385ab27cab9553e1b480a8efc84d48819a55
https://github.com/dreamwidth/dw-free/commit/c7f0385ab27cab9553e1b480a8efc84d48819a55
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/Apache/LiveJournal.pm
M cgi-bin/DW/Controller/Misc.pm
M cgi-bin/LJ/BetaFeatures.pm
M cgi-bin/LJ/User/Display.pm
M views/beta.tt.text

Log Message:
-----------
Add HTTPS Everywhere beta

This adds a beta option for testing use of HTTPS Everywhere. This will
allow us to ensure the site is fully working before turning it on for
everybody. When we do turn it on everywhere we'll have to do a little
cleanup to revert most of this.


Commit: 3d2965f834cd96d5e31a22b9228d83dc61b9ed52
https://github.com/dreamwidth/dw-free/commit/3d2965f834cd96d5e31a22b9228d83dc61b9ed52
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
Use confess to get backtrace


Commit: e17977d1a4a2776814b2b090ec03ff1af7a778c7
https://github.com/dreamwidth/dw-free/commit/e17977d1a4a2776814b2b090ec03ff1af7a778c7
Author: Mark Smith <mark@qq.is>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
M cgi-bin/Apache/LiveJournal.pm
M cgi-bin/DW/Controller/Misc.pm
M cgi-bin/LJ/BetaFeatures.pm
M cgi-bin/LJ/User/Display.pm
M views/beta.tt.text

Log Message:
-----------
Merge pull request #1926 from zorkian/https-everywhere-beta

Add HTTPS Everywhere beta


Commit: 3bf7c185e5b9aec4510efb7e838c8cf5b7b3d271
https://github.com/dreamwidth/dw-free/commit/3bf7c185e5b9aec4510efb7e838c8cf5b7b3d271
Author: Jen <kareila@dreamwidth.org>
Date: 2017-01-02 (Mon, 02 Jan 2017)

Changed paths:
A cgi-bin/DW/Controller/Support/Index.pm
R htdocs/support/index.bml
R htdocs/support/index.bml.text
A views/support/index.tt
A views/support/index.tt.text

Log Message:
-----------
Merge pull request #1666 from hotlevel4/bug1046/convertSupportIndextoTT

(Issue 1046) Convert Support Index to TT and Foundation


Commit: 1ced074913d54a802c8d053d4607ccdb40cdae05
https://github.com/dreamwidth/dw-free/commit/1ced074913d54a802c8d053d4607ccdb40cdae05
Author: Mark Smith <mark@qq.is>
Date: 2017-01-03 (Tue, 03 Jan 2017)

Changed paths:
M cgi-bin/DW/Pay.pm
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
Merge pull request #1924 from zorkian/safer-payments2

Safer payments


Commit: ae023f21c4c3ae81bdf1bf0b56f25d34a802c30b
https://github.com/dreamwidth/dw-free/commit/ae023f21c4c3ae81bdf1bf0b56f25d34a802c30b
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-01-04 (Wed, 04 Jan 2017)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
Syntax error


Commit: d8d37bf5a090ffe28af69694a72ea22c3210fd14
https://github.com/dreamwidth/dw-free/commit/d8d37bf5a090ffe28af69694a72ea22c3210fd14
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-05 (Thu, 05 Jan 2017)

Changed paths:
M bin/maint/taskinfo.txt
M bin/upgrading/update-db-general.pl

Log Message:
-----------
remove references to unused comm_promo_list


Commit: 0b0c8bb369a251d50a1ee6b232ffdd8b67b9974d
https://github.com/dreamwidth/dw-free/commit/0b0c8bb369a251d50a1ee6b232ffdd8b67b9974d
Author: Mark Smith <mark@qq.is>
Date: 2017-01-05 (Thu, 05 Jan 2017)

Changed paths:
M bin/maint/taskinfo.txt
M bin/upgrading/update-db-general.pl

Log Message:
-----------
Merge pull request #1929 from kareila/cleanup-2017q1

remove references to unused comm_promo_list


Commit: dc57ff7d830b189c7c22929db1c451aa2742632e
https://github.com/dreamwidth/dw-free/commit/dc57ff7d830b189c7c22929db1c451aa2742632e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-06 (Fri, 06 Jan 2017)

Changed paths:
M cgi-bin/LJ/NotificationInbox.pm

Log Message:
-----------
[#1896] only populate notifyarchive if esn_archive enabled

Metadata for every notification is saved in this table,
but if the feature is disabled, it's never used anywhere.

Perhaps this "feature" could be entirely removed in the
future, but I think that decision should be delayed until
we have a spec for the requested inbox redesign. It might
be useful when trying to implement a trash folder, for example.

Fixes #1896.


Commit: 9ceb16618f693ef4b891e6fbde2eec77b19c2a8a
https://github.com/dreamwidth/dw-free/commit/9ceb16618f693ef4b891e6fbde2eec77b19c2a8a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-08 (Sun, 08 Jan 2017)

Changed paths:
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
[#1928] croak if get_file_data fails in _resize method

This replaces the current "Column 'height' cannot be null"
error from Image::Magick with a more informative error,
"Failed to load image file $mediaid for $username."

This would give a sysadmin the necessary information to
delete any rows from media and media_versions related
to the file not having been saved to MogileFS.

The error happens trying to display media that was
uploaded while MogileFS was in a read-only state.


Commit: fd469b55ea3d7c533100af179d29722e1077e6cc
https://github.com/dreamwidth/dw-free/commit/fd469b55ea3d7c533100af179d29722e1077e6cc
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-08 (Sun, 08 Jan 2017)

Changed paths:
M cgi-bin/DW/Media.pm

Log Message:
-----------
[#1928] use eval to catch croaks from DW::Media->new

In get_active_for_user, the process of loading the
user's images would die if DW::Media->new failed
for any of the images.

This allows the process to complete and the page
to display normally minus the problematic images,
trapping any image errors in an eval statement
and printing them to the error log instead.


Commit: c6e320197a3f0b21f2f24d025eab1f004e1f4f37
https://github.com/dreamwidth/dw-free/commit/c6e320197a3f0b21f2f24d025eab1f004e1f4f37
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-08 (Sun, 08 Jan 2017)

Changed paths:
M cgi-bin/DW/Media.pm

Log Message:
-----------
[#1928] create image in MogileFS before writing to db

This changes the order of operations in upload_media
to try to create the MogileFS file first - that way
if we get the "unable to instantiate file" error,
we haven't already created bogus rows in the media
and media_versions tables that would cause problems.

In order to do the MogileFS operation first, we need
to use the mogkey object method to get the file key,
but we can't use the new object method before the db
rows exist. The workaround is to bless a fake object
into the class using the minimal information needed to
use the mogkey method.

Yay for reducing the number of FIXME comments.


Commit: 508a9970022751ea3c25702753ba5c6ed532444e
https://github.com/dreamwidth/dw-free/commit/508a9970022751ea3c25702753ba5c6ed532444e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-08 (Sun, 08 Jan 2017)

Changed paths:
A bin/delete-bogus-media.pl

Log Message:
-----------
Script for deleting bogus media data

This will allow a sysadmin to easily change the deletion
state for any problematic rows logged by the fix for #1928,
or to delete any orphaned thumbnails as reported in #1931.


Commit: aa8afc13175d1b1153966d29f69081a030d1b647
https://github.com/dreamwidth/dw-free/commit/aa8afc13175d1b1153966d29f69081a030d1b647
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-10 (Tue, 10 Jan 2017)

Changed paths:
M t/esn-journalnewcomment.t
M t/notificationinbox.t

Log Message:
-----------
Remove flip-flop warnings from test suite

Use of uninitialized value $. in range (or flip) at t/esn-journalnewcomment.t line 170.

Use of uninitialized value $. in range (or flip) at t/esn-journalnewcomment.t line 208.

Use of uninitialized value $. in range (or flip) at t/notificationinbox.t line 28.

Use of uninitialized value $. in range (or flop) at t/notificationinbox.t line 28.

I'm not sure why these suddenly manifested while testing on
the blobstore branch, but they appear to hinge on using
questionable syntax to assign to a hash slice. Rewritten
as a postfix foreach to achieve more clarity/less shadiness.

A Google search on the error message turned up
http://www.perlmonks.org/?node_id=525392 which was
educational if not exactly enlightening.


Commit: 49b9210ad2e1999ecfbc6a992f9f7ffb26033e01
https://github.com/dreamwidth/dw-free/commit/49b9210ad2e1999ecfbc6a992f9f7ffb26033e01
Author: Mark Smith <mark@qq.is>
Date: 2017-01-11 (Wed, 11 Jan 2017)

Changed paths:
M t/esn-journalnewcomment.t
M t/notificationinbox.t

Log Message:
-----------
Merge pull request #1938 from kareila/cleanup-2017q1

Remove flip-flop warnings from test suite


Commit: f771318f572599865af5c770652adc023a0918d7
https://github.com/dreamwidth/dw-free/commit/f771318f572599865af5c770652adc023a0918d7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-12 (Thu, 12 Jan 2017)

Changed paths:
M htdocs/shop/cart.bml
M htdocs/shop/cart.bml.text
M htdocs/shop/creditcard_wait.bml

Log Message:
-----------
[#1338] display different payment error for duplicate transactions


Commit: e193a2a65cd493afda90c0ae564c1ac2770854ca
https://github.com/dreamwidth/dw-free/commit/e193a2a65cd493afda90c0ae564c1ac2770854ca
Author: Mark Smith <mark@qq.is>
Date: 2017-01-13 (Fri, 13 Jan 2017)

Changed paths:
M htdocs/shop/cart.bml
M htdocs/shop/cart.bml.text
M htdocs/shop/creditcard_wait.bml

Log Message:
-----------
Merge pull request #1943 from kareila/1338-ccdupe

[#1338] display different payment error for duplicate transactions


Commit: c78ee3a29493a8cdaff5efed5cb6660c8b805e77
https://github.com/dreamwidth/dw-free/commit/c78ee3a29493a8cdaff5efed5cb6660c8b805e77
Author: Mark Smith <mark@qq.is>
Date: 2017-01-13 (Fri, 13 Jan 2017)

Changed paths:
M cgi-bin/LJ/NotificationInbox.pm

Log Message:
-----------
Merge pull request #1930 from kareila/1896-notifyarchive

[#1896] only populate notifyarchive if esn_archive enabled


Commit: 7ac643c36da6ea7759b5e8ccfc2cd18ccf9bb4f5
https://github.com/dreamwidth/dw-free/commit/7ac643c36da6ea7759b5e8ccfc2cd18ccf9bb4f5
Author: Mark Smith <mark@qq.is>
Date: 2017-01-13 (Fri, 13 Jan 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
Merge pull request #1932 from kareila/1928-file-edit

fixes for failed uploads breaking /file/edit page


Commit: a0ad161b3894bb549bf83441dd6b37c005f75dca
https://github.com/dreamwidth/dw-free/commit/a0ad161b3894bb549bf83441dd6b37c005f75dca
Author: Mark Smith <mark@qq.is>
Date: 2017-01-15 (Sun, 15 Jan 2017)

Changed paths:
A bin/delete-bogus-media.pl

Log Message:
-----------
Merge pull request #1933 from kareila/delete-bogus-media

Script for deleting bogus media data


Commit: 2c539cf00a47c8c08e390c14b189443c91987d4d
https://github.com/dreamwidth/dw-free/commit/2c539cf00a47c8c08e390c14b189443c91987d4d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-19 (Thu, 19 Jan 2017)

Changed paths:
R cgi-bin/LJ/SixDegrees.pm

Log Message:
-----------
remove unused module SixDegrees.pm


Commit: 73bb021de6ff0504c292df84a54b397480ea6d81
https://github.com/dreamwidth/dw-free/commit/73bb021de6ff0504c292df84a54b397480ea6d81
Author: Mark Smith <mark@qq.is>
Date: 2017-01-19 (Thu, 19 Jan 2017)

Changed paths:
R cgi-bin/LJ/SixDegrees.pm

Log Message:
-----------
Merge pull request #1947 from kareila/cleanup-2017q1

remove unused module SixDegrees.pm


Compare: https://github.com/dreamwidth/dw-free/compare/05b24047eca7...73bb021de6ff
Page generated Oct. 24th, 2017 07:56 am
Powered by Dreamwidth Studios