2011-09-20

fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-09-20 12:37 pm

[dw-free] Spellcheck causes segfaults when used within a controller

[commit: http://hg.dwscoalition.org/dw-free/rev/e6e054bc4933]

http://bugs.dwscoalition.org/show_bug.cgi?id=3947

Go back to an older approach (using IPC::Open2) to avoid the segfaults, but
do this in a gearman worker instead of in web context, to avoid issues with
IPC::Open2 not working with mod_perl2 (Bug 307).

Tweak the styling while I'm in here: stop using font, allow us to pass in a
class instead of a color (for site-skin compatibility), stop using BML
templates (for controller compatibility). Clicking on the misspelled word in
the entry will take you to the suggestion, and vice versa.

Patch by [personal profile] fu.

Files modified:
  • bin/upgrading/en.dat
  • bin/worker/spellcheck-gm
  • cgi-bin/LJ/SpellCheck.pm
ExpandDiff: 3 files changed. )