2011-06-17

fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-06-17 07:47 am

[dw-free] JS broken in talkread

[commit: http://hg.dwscoalition.org/dw-free/rev/534cacaf25cf]

http://bugs.dwscoalition.org/show_bug.cgi?id=3741

Remove references to deleted file; replace with jquery.ui.position.js where
we forgot to call it.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/ljdefaults.pl
  • htdocs/talkread.bml
  • views/dev/tests/commentmanage.js
Diff: 3 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-06-17 07:52 am

[dw-free] Parts of the contextual hover menu may spill over the edge of the screen

[commit: http://hg.dwscoalition.org/dw-free/rev/d37771f3da27]

http://bugs.dwscoalition.org/show_bug.cgi?id=3742

Recalculate the hover menu's position every time its displayed or redrawn.

Patch by [personal profile] fu.

Files modified:
  • htdocs/js/jquery.ajaxtip.js
  • htdocs/js/jquery.contextualhover.js
Diff: 2 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-06-17 07:55 am

[dw-free] "DOM not defined" error when in jquery beta

[commit: http://hg.dwscoalition.org/dw-free/rev/efbcd47a98c8]

http://bugs.dwscoalition.org/show_bug.cgi?id=3743

Don't include old-style code for users who are in beta, to avoid errors in
the browser logs.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/Talk.pm
  • cgi-bin/weblib.pl
Diff: 2 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-06-17 08:03 am

[dw-free] "Can't call inprogress on undefined" error when you click elsewhere while any aj

[commit: http://hg.dwscoalition.org/dw-free/rev/e3d81dc5d30e]

http://bugs.dwscoalition.org/show_bug.cgi?id=3744

Decouple by triggering a custom event instead of digging for the variable
directly (it may not actually exist at that point, which is what's causing
the errors). Also fix a couple issues where the ajaxtip widgets would linger
even when they shouldn't.

Patch by [personal profile] fu.

Files modified:
  • htdocs/js/jquery.ajaxtip.js
  • htdocs/js/jquery.contextualhover.js
Diff: 2 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2011-06-17 08:09 am

[dw-free] delcommentcomplete event not called when the AJAX request errors

[commit: http://hg.dwscoalition.org/dw-free/rev/2015deb1e51c]

http://bugs.dwscoalition.org/show_bug.cgi?id=3745

Set our calling widget as the context (this) of the underlying ajaxtip
widget, so we can throw up accurate events on completion.

Patch by [personal profile] fu.

Files modified:
  • htdocs/js/jquery.ajaxtip.js
  • htdocs/js/jquery.commentmanage.js
  • htdocs/js/jquery.contextualhover.js
  • htdocs/js/jquery.poll.js
  • views/dev/tests/commentmanage.js
Diff: 5 files changed. )