2010-12-10

2010-12-10

[dw-free] remove "use vars" pragma from modules in cgi-bin

[commit: http://hg.dwscoalition.org/dw-free/rev/e57798960719]

http://bugs.dwscoalition.org/show_bug.cgi?id=3217

Update to use newer Perl syntax - no functional changes.

Patch by

kareila.

Files modified:

bin/ljmaint.pl
bin/maint/stats.pl
bin/maint/synsuck.pl
cgi-bin/Apache/DebateSuicide.pm
cgi-bin/Apache/SendStats.pm
cgi-bin/DW/Request.pm
cgi-bin/JSON.pm
cgi-bin/JSON/Parser.pm
cgi-bin/LJ/Entry.pm
cgi-bin/LJ/MemCache.pm
cgi-bin/LJ/ModuleLoader.pm
cgi-bin/LJ/SpellCheck.pm
cgi-bin/LJ/Support.pm
cgi-bin/LJ/Test.pm
cgi-bin/LJ/TextMessage.pm
cgi-bin/LJ/Widget/InboxFolderNav.pm
cgi-bin/LJ/Worker/Gearman.pm
cgi-bin/LJ/Worker/TheSchwartz.pm
cgi-bin/LJ/XMLRPC.pm
cgi-bin/XML/Atom.pm
cgi-bin/XML/Atom/ErrorHandler.pm
cgi-bin/XML/Atom/Link.pm
cgi-bin/XML/Atom/Person.pm
cgi-bin/XML/Atom/Thing.pm
cgi-bin/XML/Atom/Util.pm
cgi-bin/imageconf.pl
cgi-bin/ljlib.pl
doc/raw/build/caps/cap2db.pl
doc/raw/build/hooks/hooks2db.pl

( Diff: 29 files changed. )

[dw-free] remove unneeded third party modules

[commit: http://hg.dwscoalition.org/dw-free/rev/66a74c934a30]

http://bugs.dwscoalition.org/show_bug.cgi?id=2715

We no longer use this -- it's an Apache 1.3 module, and it's not in any of
our configs.

Patch by

kareila.

Files modified:

cvs/multicvs.conf
t/00-compile.t

( Diff: 2 files changed. )

[dw-free] remove unneeded third party modules

[commit: http://hg.dwscoalition.org/dw-free/rev/2781a118a7bc]

http://bugs.dwscoalition.org/show_bug.cgi?id=2715

We don't need to guard against this warning, because the module no longer
exists.

Patch by

kareila.

Files modified:

t/00-compile.t

( Diff: 1 file changed. )

[dw-free] "Also Access To" list not in alphabetical order

[commit: http://hg.dwscoalition.org/dw-free/rev/cb77ef4e7de8]

http://bugs.dwscoalition.org/show_bug.cgi?id=3313

Missed a spot; add the "also access to" list to the list of lists to
alphabetize.

Patch by Erin of

teamdestroyer.

Files modified:

htdocs/profile.bml

( Diff: 1 file changed. )

[dw-free] fix warnings in htdocs/manage/circle/add.bml

[commit: http://hg.dwscoalition.org/dw-free/rev/05a3090468de]

http://bugs.dwscoalition.org/show_bug.cgi?id=3332

Reset count variable, instead of (mistakenly) checking for equality; also
don't double-declare the variable with "my" in the same scope.

Patch by

kareila.

Files modified:

htdocs/manage/circle/add.bml

( Diff: 1 file changed. )

[dw-free] warnings for undefined privarg in priv console command

[commit: http://hg.dwscoalition.org/dw-free/rev/50c3866d1cec]

http://bugs.dwscoalition.org/show_bug.cgi?id=3308

Less warnings.

Patch by

kareila.

Files modified:

cgi-bin/LJ/Console/Command/Priv.pm

( Diff: 1 file changed. )

[dw-free] Show 'display cross post links' on cross-posting summary page

[commit: http://hg.dwscoalition.org/dw-free/rev/18a19f24b6a8]

http://bugs.dwscoalition.org/show_bug.cgi?id=3292

Adds checkbox for the "show crosspost link" option to the general Other
Sites view, so that it's more visible.

Patch by Erin of

teamdestroyer.

Files modified:

bin/upgrading/en.dat
cgi-bin/DW/Setting/XPostAccounts.pm

( Diff: 2 files changed. )

[dw-free] remove gratuitous shifts from Entry.pm

[commit: http://hg.dwscoalition.org/dw-free/rev/cac843759a21]

http://bugs.dwscoalition.org/show_bug.cgi?id=3324

Remove gratuitous shifts, leave in non-gratuitous shifts.

Patch by

kareila.

Files modified:

cgi-bin/LJ/Entry.pm

( Diff: 1 file changed. )

[dw-free] servicetype error not displayed on /manage/externalaccount

[commit: http://hg.dwscoalition.org/dw-free/rev/3428da6437e4]

http://bugs.dwscoalition.org/show_bug.cgi?id=3325

Show an error message instead of silently failing if you are over your limit
of accounts, just in case you manage to get to the page where accounts can
be created (the link normally doesn't show up).

Patch by

kareila.

Files modified:

htdocs/manage/externalaccount.bml

( Diff: 1 file changed. )

[dw-free] remove broken add_edge call from htdocs/feeds/index.bml

[commit: http://hg.dwscoalition.org/dw-free/rev/8bed8122b87e]

http://bugs.dwscoalition.org/show_bug.cgi?id=3339

No effect, the syntax is wrong. We redirect to /manage/circle/add, so just
remove this.

Patch by

kareila.

Files modified:

htdocs/feeds/index.bml

( Diff: 1 file changed. )

[dw-free] avoid uninitialized warnings in LJ/Lang.pm

[commit: http://hg.dwscoalition.org/dw-free/rev/1717049f6c65]

http://bugs.dwscoalition.org/show_bug.cgi?id=3326

Return early, if we didn't pass in an argument to process.

Patch by

kareila.

Files modified:

cgi-bin/LJ/Lang.pm

( Diff: 1 file changed. )

[dw-free] avoid uninitialized warnings in LJ/Keywords.pm

[commit: http://hg.dwscoalition.org/dw-free/rev/29a8d7e6fef1]

http://bugs.dwscoalition.org/show_bug.cgi?id=3329

Avoid warnings.

Patch by

kareila.

Files modified:

cgi-bin/LJ/Keywords.pm

( Diff: 1 file changed. )

[dw-free] avoid uninitialized warnings in ljtextutil.pl

[commit: http://hg.dwscoalition.org/dw-free/rev/0ba86eefb2b0]

http://bugs.dwscoalition.org/show_bug.cgi?id=3323

Do the check in the other order to avoid warnings.

Patch by

kareila.

Files modified:

cgi-bin/ljtextutil.pl

( Diff: 1 file changed. )

[dw-free] avoid uninitialized warnings in ljtextutil.pl

[commit: http://hg.dwscoalition.org/dw-free/rev/ca110e45bf53]

http://bugs.dwscoalition.org/show_bug.cgi?id=3323

Avoid warnings; for functions which manipulate strings, return "" if we
passed in undef.

Patch by

kareila.

Files modified:

cgi-bin/ljtextutil.pl

( Diff: 1 file changed. )

[dw-free] avoid uninitialized warnings in LJ/Customize.pm

[commit: http://hg.dwscoalition.org/dw-free/rev/81b1241004ea]

http://bugs.dwscoalition.org/show_bug.cgi?id=3330

hush warnings.

Patch by

kareila.

Files modified:

cgi-bin/LJ/Customize.pm

( Diff: 1 file changed. )

[dw-free] Add "expired last month" to circle gifts in the shop

[commit: http://hg.dwscoalition.org/dw-free/rev/b0b6954b7c51]

http://bugs.dwscoalition.org/show_bug.cgi?id=1747

Distinguish between paid-but-expired and never-paid.

Patch by

kareila.

Files modified:

cgi-bin/LJ/User.pm
htdocs/shop/gifts.bml
htdocs/shop/gifts.bml.text

( Diff: 3 files changed. )