2010-06-21

fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2010-06-21 09:25 am

[dw-free] Declaration of which themes are default/should go in the base category, is duplicated

[commit: http://hg.dwscoalition.org/dw-free/rev/138f3a485251]

http://bugs.dwscoalition.org/show_bug.cgi?id=2728

Deduplication of logic: no need to declare a separate "base" category --
instead, use the known default_themes, to determine which theme to display
for each layout under the "Base Layouts" category.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/S2Theme.pm
  • cgi-bin/LJ/S2Theme/bases.pm
  • cgi-bin/LJ/S2Theme/basicboxes.pm
  • cgi-bin/LJ/S2Theme/blanket.pm
  • cgi-bin/LJ/S2Theme/boxesandborders.pm
  • cgi-bin/LJ/S2Theme/brittle.pm
  • cgi-bin/LJ/S2Theme/core2base.pm
  • cgi-bin/LJ/S2Theme/crossroads.pm
  • cgi-bin/LJ/S2Theme/drifting.pm
  • cgi-bin/LJ/S2Theme/easyread.pm
  • cgi-bin/LJ/S2Theme/fluidmeasure.pm
  • cgi-bin/LJ/S2Theme/funkycircles.pm
  • cgi-bin/LJ/S2Theme/modular.pm
  • cgi-bin/LJ/S2Theme/negatives.pm
  • cgi-bin/LJ/S2Theme/nouveauoleanders.pm
  • cgi-bin/LJ/S2Theme/refriedtablet.pm
  • cgi-bin/LJ/S2Theme/skittlishdreams.pm
  • cgi-bin/LJ/S2Theme/steppingstones.pm
  • cgi-bin/LJ/S2Theme/tranquilityiii.pm
  • cgi-bin/LJ/S2Theme/zesty.pm
  • cgi-bin/LJ/Widget/ThemeChooser.pm
Diff: 21 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2010-06-21 09:27 am

[dw-nonfree] Declaration of which themes are default/should go in the base category, is duplicated

[commit: http://hg.dwscoalition.org/dw-nonfree/rev/770ba3d08bab]

http://bugs.dwscoalition.org/show_bug.cgi?id=2728

Deduplication: Remove declaration of "base" category.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/S2Theme/colorside_local.pm
  • cgi-bin/LJ/S2Theme/modish_local.pm
  • cgi-bin/LJ/S2Theme/sundaymorning.pm
  • cgi-bin/LJ/S2Theme/transmogrified.pm
Diff: 4 files changed. )
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[personal profile] fu2010-06-21 01:53 pm

[dw-free] Using quick reply from a thread in custom comments pages does not return you to thread vie

[commit: http://hg.dwscoalition.org/dw-free/rev/ca607f1f3084]

http://bugs.dwscoalition.org/show_bug.cgi?id=2730

$page->{viewing_thread} is a boolean, used within s2 layers to determine
whether you were viewing a thread or not; we need to pass the actual id of
the thread we're viewing.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/S2.pm
  • cgi-bin/LJ/S2/EntryPage.pm
Diff: 2 files changed. )