afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-16 05:28 am

[dw-free] birthday notifications contain link that 404s

[commit: http://hg.dwscoalition.org/dw-free/rev/ea820e5dfbce]

http://bugs.dwscoalition.org/show_bug.cgi?id=1141

Fix giftshop link

Patch by [staff profile] denise.

Files modified:
  • cgi-bin/LJ/Event/Birthday.pm
  • cgi-bin/LJ/User.pm
--------------------------------------------------------------------------------
diff -r fad8e11bd5c3 -r ea820e5dfbce cgi-bin/LJ/Event/Birthday.pm
--- a/cgi-bin/LJ/Event/Birthday.pm	Sat May 16 05:16:49 2009 +0000
+++ b/cgi-bin/LJ/Event/Birthday.pm	Sat May 16 05:28:01 2009 +0000
@@ -53,7 +53,7 @@ sub as_html_actions {
 sub as_html_actions {
     my ($self) = @_;
 
-    my $gifturl = $self->bdayuser->gift_url({ item => 'vgift' });
+    my $gifturl = $self->bdayuser->gift_url;
     my $ret .= "<div class='actions'>";
     $ret .= " <a href='$gifturl'>Send a Gift</a>";
     $ret .= "</div>";
diff -r fad8e11bd5c3 -r ea820e5dfbce cgi-bin/LJ/User.pm
--- a/cgi-bin/LJ/User.pm	Sat May 16 05:16:49 2009 +0000
+++ b/cgi-bin/LJ/User.pm	Sat May 16 05:28:01 2009 +0000
@@ -5279,11 +5279,7 @@ sub show_mutualfriends {
 # after that, it goes in section 7
 # returns the gift shop URL to buy a gift for that user
 sub gift_url {
-    my ($u, $opts) = @_;
-    croak "invalid user object passed" unless LJ::isu($u);
-    my $item = $opts->{item} ? delete $opts->{item} : '';
-
-    return "$LJ::SITEROOT/shop/view.bml?item=$item&gift=1&for=$u->{'user'}";
+    return "$LJ::SITEROOT/shop/account?for=gift";
 }
 
 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org