afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-12 01:23 pm

[dw-free] Only show both button sets on manage/circle/add.bml if there are filters to list

[commit: http://hg.dwscoalition.org/dw-free/rev/d3182b74993f]

http://bugs.dwscoalition.org/show_bug.cgi?id=1206

Less can be more.

Patch by [personal profile] wyntarvox.

Files modified:
  • htdocs/manage/circle/add.bml
--------------------------------------------------------------------------------
diff -r 80d2596b9824 -r d3182b74993f htdocs/manage/circle/add.bml
--- a/htdocs/manage/circle/add.bml	Tue May 12 13:11:55 2009 +0000
+++ b/htdocs/manage/circle/add.bml	Tue May 12 13:23:03 2009 +0000
@@ -181,27 +181,30 @@
         });
     }
 
-    ## extra add and cancel buttons
-    $body .= "<br /><br />";
-    if ($u->is_visible) {
-        my $btn = ( $watched || $trusted ) ? $ML{'.btn.modify'} :  BML::ml( '.btn.add', { user => $u->display_name } );
-        $body .= "<input type='submit' value=\"$btn\"> ";
-    } else {
-        $body .= "<input type='submit' name='action:delete' value=\"$ML{'.btn.remove'}\"> \n";
-    }
+    my $trust_groups = $remote->trust_groups;
 
-    my $cancel_btn = LJ::ejs($ML{'.btn.cancel'});
+    ## extra add and cancel buttons only if there are filters to list
+    if ( keys %$trust_groups ) {
+        $body .= "<br /><br />";
+        if ($u->is_visible) {
+            my $btn = ( $watched || $trusted ) ? $ML{'.btn.modify'} :  BML::ml( '.btn.add', { user => $u->display_name } );
+            $body .= "<input type='submit' value=\"$btn\"> ";
+        } else {
+            $body .= "<input type='submit' name='action:delete' value=\"$ML{'.btn.remove'}\"> \n";
+        }
 
-    $body .= "<script type='text/javascript' language='Javascript'> \n <!-- \n
+        my $cancel_btn = LJ::ejs($ML{'.btn.cancel'});
+
+        $body .= "<script type='text/javascript' language='Javascript'> \n <!-- \n
        document.write(\"<input type='button' value='$cancel_btn' onclick='history.go(-1); return false;'>\");
         \n // -->\n ";
-    $body .= '</script>';
+        $body .= '</script>';
+    }
 
 
     ## let them pick friend groups
     # FIXME: Add support for reading groups once those exist
     my $err;
-    my $trust_groups = $remote->trust_groups;
 
     if ( $remote->can_trust( $u ) && keys %$trust_groups ) {
         $body .= "<?p &nbsp;<br />";
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org