afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-10 06:21 pm

[dw-free] alt text is over-escaped in S2

[commit: http://hg.dwscoalition.org/dw-free/rev/a4ba03d4fc21]

http://bugs.dwscoalition.org/show_bug.cgi?id=1147

Remove overescaping of alttext (Alttext already escaped by the backend)

Patch by [personal profile] jadelennox.

Files modified:
  • bin/upgrading/s2layers/core2.s2
--------------------------------------------------------------------------------
diff -r df81a3e83008 -r a4ba03d4fc21 bin/upgrading/s2layers/core2.s2
--- a/bin/upgrading/s2layers/core2.s2	Sun May 10 17:47:00 2009 +0000
+++ b/bin/upgrading/s2layers/core2.s2	Sun May 10 18:20:47 2009 +0000
@@ -2473,7 +2473,7 @@ function Image::as_string(string alttext
 function Image::as_string(string alttext) [fixed] : string
 "You most likely want to use Image::print instead.  Prints HTML for the image with a given alttext. Using meaningful alttext is strongly recommended to improve the accessibility of your layout. Overriding this function is NOT RECOMMENDED. Overriding this function could prevent sitewide improvements to styles, accessibility, or other functionality from operating in your layout."
 {
-    return "<img src=\"$.url\" title=\"\" alt=\"" + ehtml($alttext) + "\"" +
+    return "<img src=\"$.url\" title=\"\" alt=\"" + $alttext + "\"" +
         htmlattr("height", $.height) +
         htmlattr("width", $.width) + " />";
 }
--------------------------------------------------------------------------------