[dreamwidth/dreamwidth] 6f0d34: put authas select back in /register

[github]

Branch: refs/heads/main Home: https://github.com/dreamwidth/dreamwidth Commit: 6f0d3442187d45b2b344a39a77eadf70883d9e9d https://github.com/dreamwidth/dreamwidth/commit/6f0d3442187d45b2b344a39a77eadf70883d9e9d Author: Kareila kareila@dreamwidth.org Date: 2023-07-14 (Fri, 14 Jul 2023)

Changed paths: M cgi-bin/DW/Controller/Register.pm M views/register.tt

Log Message:

---

put authas select back in /register

Wow, I really messed up this conversion!

1. I didn't realize that email addresses for communities were still an ongoing concern? I had removed the authas selection form, but it turns out to still be necessary sometimes.

2. Furthermore, DW::Controller won't let you use both authas and anonymous. But the only part of the page code that actually didn't require you to be logged in was the /confirm path, and it's probably actually not great to let that work logged out, so I removed the anonymous option instead. If THAT needs to come back later, it'll have to be moved into a separate controller from the rest of /register.

3. The cherry on top was when I realized I had accidentally passed the controller options to register_string instead of controller, so the options weren't even being enabled! I can't believe I didn't notice that when I was testing the initial conversion.