afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-07 02:58 pm

[dw-free] On the reading page, usericons do not have a width & height set, unlike on the comment

[commit: http://hg.dwscoalition.org/dw-free/rev/cbcf9c621bf9]

http://bugs.dwscoalition.org/show_bug.cgi?id=1004

Load userpic width and height correctly.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/S2.pm
--------------------------------------------------------------------------------
diff -r 86a6d882516c -r cbcf9c621bf9 cgi-bin/LJ/S2.pm
--- a/cgi-bin/LJ/S2.pm	Thu May 07 07:07:10 2009 +0000
+++ b/cgi-bin/LJ/S2.pm	Thu May 07 14:58:31 2009 +0000
@@ -2110,8 +2110,8 @@ sub Image_userpic
     my $p = LJ::Userpic->new($u, $picid);
 
     #  load the dimensions, unless they have been passed in explicitly
-    $width ||= $p->{width};
-    $height ||= $p->{height};
+    $width ||= $p->width;
+    $height ||= $p->height;
 
     # load the alttext.  use description by default, keyword as fallback,
     # and all keywords as final fallback (should be for default icon only).
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org