github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2020-09-07 02:10 pm
  • Add Memory
  • Share This Entry

[dreamwidth/dw-free] b023c1: Fix location of commentmanage.js in views/dev/tests

Branch: refs/heads/master Home: https://github.com/dreamwidth/dw-free Commit: b023c12a04e72a0ab4f81d47d704a9ae2d95b629 https://github.com/dreamwidth/dw-free/commit/b023c12a04e72a0ab4f81d47d704a9ae2d95b629 Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests/commentmanage.js

Log Message:

Fix location of commentmanage.js in views/dev/tests

Commit: 99195720b441df24c3d5da55a4750cd1c06ff1db https://github.com/dreamwidth/dw-free/commit/99195720b441df24c3d5da55a4750cd1c06ff1db Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests.tt

Log Message:

Don't include sinon-ie.js in dev/tests.tt

This breaks the test suite by overriding the built-in Date() object.

"If you don't require fake timers to work in IE, don't include this file."

Commit: 3cbe433e8196a30c12603c44908f6279cbcb711f https://github.com/dreamwidth/dw-free/commit/3cbe433e8196a30c12603c44908f6279cbcb711f Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests-all.tt

Log Message:

Don't include sample.js in dev/tests-all.tt

It's an example file, not a real test.

Commit: 3e855fc52d47ca37e2cd15cd092d20cd28843419 https://github.com/dreamwidth/dw-free/commit/3e855fc52d47ca37e2cd15cd092d20cd28843419 Author: Kareila kareila@dreamwidth.org Date: 2020-09-07 (Mon, 07 Sep 2020)

Changed paths: M views/dev/tests/commentmanage.js

Log Message:

Fix timing issues in delcomment tests

Through trial and error, I proved that the delcomment tests were failing in a non-deterministic way due to timing issues between the comment visibility being changed and being observed. If I removed all the stop calls or changed their arguments, all the visibility tests failed consistently.

I eventually discovered that if I commented out the stop calls for the elements whose visibility was unchanged, the tests passed consistently.

Compare: https://github.com/dreamwidth/dw-free/compare/9be41d342503...3e855fc52d47