github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2020-07-16 08:29 pm

[dreamwidth/dw-free] 4236b5: Polls: Fix the really easy display problems

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 4236b51e5c8042e09f9b85134f1f48324c5a16ec
https://github.com/dreamwidth/dw-free/commit/4236b51e5c8042e09f9b85134f1f48324c5a16ec
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-16 (Thu, 16 Jul 2020)

Changed paths:
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Poll/Question.pm

Log Message:
-----------
Polls: Fix the really easy display problems

- Set max-widths for text inputs and selects.
- Make the left margin of the response groups adjust to the width of its
container, instead of locking to 40px.
- Don't worry too much about the poll preview thing; it's locked to site-skin
anyway, so it doesn't have to fit into as many different environments. (Once
it's foundationized the default styles should make it ok on mobile, and until
then there's no way to make it NOT awful.)


Commit: c29267a9f8a91020005c6a2362c37e174fd631ef
https://github.com/dreamwidth/dw-free/commit/c29267a9f8a91020005c6a2362c37e174fd631ef
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-16 (Thu, 16 Jul 2020)

Changed paths:
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Poll/Question.pm
A views/poll/scale_radio.tt

Log Message:
-----------
Polls: Move radio-button scale controls to a template

I guess it looks kind of lonely out there at the moment. Maybe later we can
templatize more of this, but for now that just seemed like the easiest way to
deal with having this complex formatting called by multiple files.

OH RIGHT, also, I'm replacing that chaotic neutral single-row table with some
nice normal flexbox, with inline-block as fallback for flexless browsers.


Commit: f46ace8cdb1c545f566fe78699a09a08b90d0729
https://github.com/dreamwidth/dw-free/commit/f46ace8cdb1c545f566fe78699a09a08b90d0729
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-07-16 (Thu, 16 Jul 2020)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
Polls: Fix display of poll results histograms

This was a constantly overflowing mess, and now it's hopefully less so. It's
still kind of a dank thicket of inline CSS, but oh well.

- Removing some obsolete/deprecated attributes from the table HTML for range
questions.
- Replacing the goofy extend-a-image trick we use for bars with a CSSed div that
that looks roughly the same.
- Contain the histograms to the width of their container, instead of setting
random pixel widths and launching them out through the side of the house.


Compare: https://github.com/dreamwidth/dw-free/compare/cc8499943efb...f46ace8cdb1c

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org