[dreamwidth/dw-free] 763ee9: (#2632) Stop mutating opts hashrefs in `ljuser` an...
Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 763ee970c2e20a78693dfd2ffc3671dd1369bb36
https://github.com/dreamwidth/dw-free/commit/763ee970c2e20a78693dfd2ffc3671dd1369bb36
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M cgi-bin/LJ/User/Display.pm
Log Message:
-----------
(#2632) Stop mutating opts hashrefs in `ljuser` and `ljuser_display`
This was causing every user to look deleted within a given post after at least
one deleted user was mentioned.
Commit: 0fa09a8b7859bd94b50395468de635edbec3001a
https://github.com/dreamwidth/dw-free/commit/0fa09a8b7859bd94b50395468de635edbec3001a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M cgi-bin/LJ/CleanHTML.pm
Log Message:
-----------
DW::External::User::ljuser_display takes an opts hash, not an opts hashref
This actually might have been working fine, depending on your version of perl
(direct key access on a hashref, which iirc they were considering at some point
and implemented as experimental), but it's definitely deviant and wrong.
Compare: https://github.com/dreamwidth/dw-free/compare/f36d002c0afd...0fa09a8b7859
Home: https://github.com/dreamwidth/dw-free
Commit: 763ee970c2e20a78693dfd2ffc3671dd1369bb36
https://github.com/dreamwidth/dw-free/commit/763ee970c2e20a78693dfd2ffc3671dd1369bb36
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M cgi-bin/LJ/User/Display.pm
Log Message:
-----------
(#2632) Stop mutating opts hashrefs in `ljuser` and `ljuser_display`
This was causing every user to look deleted within a given post after at least
one deleted user was mentioned.
Commit: 0fa09a8b7859bd94b50395468de635edbec3001a
https://github.com/dreamwidth/dw-free/commit/0fa09a8b7859bd94b50395468de635edbec3001a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M cgi-bin/LJ/CleanHTML.pm
Log Message:
-----------
DW::External::User::ljuser_display takes an opts hash, not an opts hashref
This actually might have been working fine, depending on your version of perl
(direct key access on a hashref, which iirc they were considering at some point
and implemented as experimental), but it's definitely deviant and wrong.
Compare: https://github.com/dreamwidth/dw-free/compare/f36d002c0afd...0fa09a8b7859