[dreamwidth/dw-free] fe5b1c: Fix backwards cut-tag expansion by removing ancien...

[github]

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: fe5b1c7d7bb6667db828b1153790cc3ae301e824
https://github.com/dreamwidth/dw-free/commit/fe5b1c7d7bb6667db828b1153790cc3ae301e824
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-01-20 (Mon, 20 Jan 2020)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/cleaner-ljtags.t

Log Message:
-----------
Fix backwards cut-tag expansion by removing ancient hack

Revert "http://bugs.dwscoalition.org/show_bug.cgi?id=2686"

This reverts commit 8e11293186c502e1e29888fa9202d86fa25ab4e6, with tidying.

Fu's original commit, ca. 2010, said:

> Nest the cuttag div in a span (inline element to still allow for inline cuts).
> Hack-y workaround to account for Firefox not refreshing the display when there
> is a :first-letter on the entry.

Said bug is long gone, but now the workaround triggers a different bug: adding
or removing `display: block` on a child of an inline element can make Firefox
choose an especially useless scroll anchor node. If you then add content that
changes the page height (like when expanding a cut tag), the irrelevant node
helpfully stays put, so you can keep looking at it while the content you
actually care about blasts off into space.

Anyway, Firefox is _technically_ doing a wrong thing here. (See
https://bugzilla.mozilla.org/show_bug.cgi?id=1608995 for details; interestingly,
the root cause also explains why that hack originally worked!) But since putting
block elements in an inline container is counterproductive in the first place,
it's kind of a "Doctor, it hurts when I kick this wall" bug.


Commit: 025697a6807dcd36b1a7665352e642c3720ec879
https://github.com/dreamwidth/dw-free/commit/025697a6807dcd36b1a7665352e642c3720ec879
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2020-01-20 (Mon, 20 Jan 2020)

Changed paths:
M styles/goldleaf/layout.s2

Log Message:
-----------
Styles: Update a rule targeting .cuttag_container

This span was removed, but also .cuttag-action is a better choice anyway
because it targets the closing cut tag as well as the opening one.


Compare: https://github.com/dreamwidth/dw-free/compare/094e44023850...025697a6807d