[dreamwidth/dw-free] ec447f: [#2508] Fix endless and expanding choir of dead-ey...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: ec447ff04ddc84a7570cac7b98e399c00de954d0
https://github.com/dreamwidth/dw-free/commit/ec447ff04ddc84a7570cac7b98e399c00de954d0
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-23 (Sun, 23 Jun 2019)

Changed paths:
M cgi-bin/LJ/Talk.pm
M views/journal/talkform.tt

Log Message:
-----------
[#2508] Fix endless and expanding choir of dead-eyed faces

Fixes #2508.

I forgot that:

1. The stuff a TT template gets is passed by reference, so you need to never
mutate it or else the changes escape back into perl land.
2. I'm caching the subjecticons hashref now.

The result was that every time a user loaded the talkform, it would add another
"none" icon onto the canonical list, and it would keep expanding until the
mod_perl process got killed.