github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2017-02-01 01:19 pm

[dreamwidth/dw-free] 9865ff: fix variable reuse warning in DW::Pay

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 9865ffb44ccef10c5687231dd232c89282c5d144
https://github.com/dreamwidth/dw-free/commit/9865ffb44ccef10c5687231dd232c89282c5d144
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-01 (Wed, 01 Feb 2017)

Changed paths:
M cgi-bin/DW/Pay.pm

Log Message:
-----------
fix variable reuse warning in DW::Pay

"my" variable $rv masks earlier declaration in same scope .. cgi-bin/DW/Pay.pm line 533.

Traced this back to bd33881 - eval code added in two spots, but one of
the spots was already using $rv.

Changed the new $rv to use a different variable name, which means the
function will return the earlier $rv as before.


Commit: 0d75d726b15ec3c6c724839793611e3ea9d8d023
https://github.com/dreamwidth/dw-free/commit/0d75d726b15ec3c6c724839793611e3ea9d8d023
Author: Mark Smith <mark@qq.is>
Date: 2017-02-01 (Wed, 01 Feb 2017)

Changed paths:
M cgi-bin/DW/Pay.pm

Log Message:
-----------
Merge pull request #1951 from kareila/cleanup-2017q1

fix variable reuse warning in DW::Pay


Compare: https://github.com/dreamwidth/dw-free/compare/66e9cc108b77...0d75d726b15e

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org