github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2016-05-12 08:54 pm

[dreamwidth/dw-free] 362153: Adjust things to avoid Perl 5.20's precedence warn...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 362153b7492cac9d894567cbe9ca665a5947281e
https://github.com/dreamwidth/dw-free/commit/362153b7492cac9d894567cbe9ca665a5947281e
Author: pinterface <github@kepibu.org>
Date: 2016-05-12 (Thu, 12 May 2016)

Changed paths:
M cgi-bin/DW/Hooks/SiteSearch.pm
M cgi-bin/DW/Shop.pm
M cgi-bin/LJ/Stats.pm

Log Message:
-----------
Adjust things to avoid Perl 5.20's precedence warnings (#1773)

Due to Perl's precedence rules, `return x or thing` is always
interpreted as `return x`, so the `or thing` never happens.
That's not really ideal when you're trying to error out (`or die`),
so adjust these calls to ensure the dieing is not dead code.

Fixes #1772

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org