github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2016-05-04 01:31 pm

[dreamwidth/dw-free] a50ebf: [#1660] improve error message when uploading multi...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: a50ebf21c3a90c06a75c53b953accdc372d06f28
https://github.com/dreamwidth/dw-free/commit/a50ebf21c3a90c06a75c53b953accdc372d06f28
Author: Kareila <kareila@dreamwidth.org>
Date: 2016-05-04 (Wed, 04 May 2016)

Changed paths:
M cgi-bin/Apache/BML.pm
M htdocs/editicons.bml

Log Message:
-----------
[#1660] improve error message when uploading multiple icons fails

Some bits of code were expecting errorrefs that weren't being set.
Others were ignoring errorrefs that were being set. Both cases
should be fixed now, such that the intended error messages will
actually be shown to the user.

The error message shown when one of many icons is an unsupported
image type is now "You can only upload GIF, PNG, or JPG files."
instead of "Hook: 'enddata' returned false" - it's in the
translation system if we want to make it more verbose.

Fixes #1660.


Commit: 54940f1a66b06e7760179fa0c24a1c59d8195057
https://github.com/dreamwidth/dw-free/commit/54940f1a66b06e7760179fa0c24a1c59d8195057
Author: Mark Smith <mark@qq.is>
Date: 2016-05-04 (Wed, 04 May 2016)

Changed paths:
M cgi-bin/Apache/BML.pm
M htdocs/editicons.bml

Log Message:
-----------
Merge pull request #1765 from kareila/1660-enddata

[#1660] improve error message when uploading multiple icons fails


Compare: https://github.com/dreamwidth/dw-free/compare/4534df72e7c8...54940f1a66b0

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org