mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2009-02-27 06:42 am

[dw-free] Documentation and implementation for trust group options don't match up

[commit: http://hg.dwscoalition.org/dw-free/rev/f901b2e58ca6]

http://bugs.dwscoalition.org/show_bug.cgi?id=369

Allow sortorder/is_public to really be optional now.

Patch by [staff profile] mark.

--------------------------------------------------------------------------------
diff -r b7a015d8896c -r f901b2e58ca6 cgi-bin/DW/User/Edges/WatchTrust.pm
--- a/cgi-bin/DW/User/Edges/WatchTrust.pm	Fri Feb 27 03:18:29 2009 +0000
+++ b/cgi-bin/DW/User/Edges/WatchTrust.pm	Fri Feb 27 06:42:01 2009 +0000
@@ -635,7 +635,7 @@ sub edit_trust_group {
     my $dbcm = LJ::get_cluster_master( $u )
         or confess 'unable to connect to user cluster master';
     $dbcm->do( 'REPLACE INTO trust_groups (userid, groupnum, groupname, sortorder, is_public) VALUES (?, ?, ?, ?, ?)',
-               undef, $u->id, $id, $change{groupname}, $change{sortorder}, $change{is_public} );
+               undef, $u->id, $id, $change{groupname}, $change{sortorder} || 50, $change{is_public} || 0 );
     confess $dbcm->errstr if $dbcm->err;
 
     # kill memcache and return
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org