[dreamwidth/dw-free] 66cee5: (Bug 2165) Revamp community posting options

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 66cee5febb6f370156b60eb5781bed3243b449aa
https://github.com/dreamwidth/dw-free/commit/66cee5febb6f370156b60eb5781bed3243b449aa
Author: Afuna <fu@dreamwidth.org>
Date: 2014-03-04 (Tue, 04 Mar 2014)

Changed paths:
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
M cgi-bin/DW/Controller/Community.pm
M cgi-bin/DW/Setting/CommunityPostLevel.pm
A cgi-bin/DW/Setting/CommunityPostLevelNew.pm
M cgi-bin/LJ/Community.pm
M cgi-bin/LJ/Setting.pm
A htdocs/js/jquery.settings.js
M htdocs/manage/settings/index.bml
M htdocs/stc/settings.css

Log Message:
-----------
(Bug 2165) Revamp community posting options

* "All members" now grants posting access to *all* members, instead of
still allowing you to selectively grant/take away access. This applies
retroactively (so everyone, including those who didn't explicitly have
posting access before, can now post to the community)

* "Select members" acts as described: you can choose which of your
members has posting access

* New option: "new members can/cannot post" which is only visible when
"select members" is selected. "New members can post" is like the old
"all members" option. "New members cannot post" is like the old
"select members" option. Default is for new members to be unable to
post unless; they have to be given posting access


Commit: 68098c2fbca298e5f674ffe102ae19a4b7583d69
https://github.com/dreamwidth/dw-free/commit/68098c2fbca298e5f674ffe102ae19a4b7583d69
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-03-04 (Tue, 04 Mar 2014)

Changed paths:
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
M cgi-bin/DW/Controller/Community.pm
M cgi-bin/DW/Setting/CommunityPostLevel.pm
A cgi-bin/DW/Setting/CommunityPostLevelNew.pm
M cgi-bin/LJ/Community.pm
M cgi-bin/LJ/Setting.pm
A htdocs/js/jquery.settings.js
M htdocs/manage/settings/index.bml
M htdocs/stc/settings.css

Log Message:
-----------
Merge pull request #648 from afuna/community-posting-options-cleanup-bug2165

(Bug 2165) Revamp community posting options


Compare: https://github.com/dreamwidth/dw-free/compare/3c046622064e...68098c2fbca2

Comments

[ninetydegrees]

Awesome!

[ninetydegrees]

Oh getting an error message when going to /members

[Error: Can't locate object method "post_level" via package "LJ::User" at /dreamhack/home/8174-ninetydegrees/dw/cgi-bin/DW/Controller/Community.pm line 724. @ newhack.dreamwidth.net]

[fu]

facepalm I'm not sure why that didn't make it to the commit. I'm adding it, thanks for catching that.

[ninetydegrees]

You're most welcome. I know what's it's like. Is the whole revamp complete BTW? Because I've been testing the page and some behaviors are quite confusing and I don't think that's intended but I don't know whether it's something that's still being worked on.

[fu]

The revamp is complete, yes! Which parts are confusing?

[ninetydegrees]

Ok still on /members any unchecked box will trigger a removal notification at the top, for all members in the list. So let's say all I'm doing is revoking membership for user x. The note for user x will say I also removed them as a moderator and as an admin *and* I'll get notes for all other members as well even if I haven't made any changes for them.
Also, while unchecking works, checking doesn't for me. I can't make anybody anything or give them posting/unmoderated access via this page.

[fu]

Hmmm weird! I will take a look (but I love that you're actually looking at the page please tell me more / if you run into any other issues <333)

[ninetydegrees]

I thought this was Fondation-related but there are some display issues which seem to be specific to any manage community page/subpage. Like content is quite narrower, the DW logo isn't a link to Home, the navigation menu LIs are too big in my font size and the little swirls in the drop-down are right next to the text.
I don't know if it's related. Could be there's an unclosed tag somewhere?
Otherwise this just looks so much better and I love invitations and the community homepage and just everything. They're much clearer and easier to use.

[fu]

I'm glad you like it so far!

The membership issues are all fixed, I'm glad that you caught that!

I think that the things you noted are common to all foundation-pages (of which there are only a few; the best way to check otherwise is to look at /dev/style-guide

The DW logo was another bug, fixed and thank you! I've also adjusted the swirls in the dropdown to be a little further apart. The content being narrower was changed from previous foundation versions to be more in line with the regular tropo sitewidth (unless that's another bug but I *think* there are no unclosed elements anywhere); same with the navigation menu LIs which might just be because of converting tropo from 0.85em up to 1em

[ninetydegrees]

Always happy to play with new toys!

Hmm. Not sure I understand what you're saying about the width and the LIs. Are they now in line with regular tropo pages? I can't see any changes as far as display issues are concerned (did compass compile but maybe I was supposed to do something else?). Swirls are in the same place too. I see the same thing on /dev/style-guide. The only difference for me is the logo working now.

[fu]

I.. didn't push the thing facepalm (Things Real Dreamwidth Programmers do, etc)

Let me know if that looks better to you now :)

With the width -- it was made narrower to be in line with regular tropo pages, yes! With the LIs I think it's the opposite: we changed the font size away from the original and so it's bigger relative to before.

[ninetydegrees]

Ok I still don't see any difference between now and before (all the issues are still there) and the pages look really different from regular tropo pages in my font size (17px minimum).

[fu]

Hrmmm I haven't really made any changes, other than moving the swirl a bit further away in tropo a tidge. It was only a couple pixels though; I didn't want to make it too far away but I did find it hard to strike a balance!

(Can you make sure that your dw-nonfree is updated in case it is that? (but again it was a very tiny tweak so perhaps not noticeable))

[ninetydegrees]

Everything's up-to-date including nonfree AFAIK.
Ok so it might be a little bit farther apart. I think at this point screen caps are best. Tell me if I should report these issues elsewhere BTW.

So this is standard tropo (DH or actual site): http://i.imgur.com/8oREr6m.png
This is the new tropo: http://i.imgur.com/q8KDinm.png

And now that I've looked at it, Celerity and Gradation also look notably different and have some issues in the new versions.

[fu]

Hmmm I think reporting the issues in the bug tracker is best! Good idea :)

(For celerity / gradation too)

Thank you <3

[ninetydegrees]

Seems things are still a little bid odd: users who have been removed as members or admins are still in the list (I guess because they're still suscribers?) and you can't add them back.

[fu]

Sorry for the late reply! Things got a bit hairy recently :)

I'm not reproducing this though; I went to a community I owned and removed someone from all roles. When I did that it said "shyguy - removed: member", and they don't show up anymore.

Is this still an issue for you on the latest DW code? Can you give me any more context / additional steps to make this happen?

[ninetydegrees]

Hmm. It's still happening for me but I think this might only occur when you've changed the comm settings: I think my two subscribers still show up because at some point posting access was restricted. Right now, they're no longer members but they still have posting access. However, the posting access column doesn't show up on the Members page so I can't do anything about that.

[fu]

Aha that makes sense! I'll take a look at that then :)