github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2013-01-10 11:34 pm

[dreamwidth/dw-free] 278e47: (Bug 4719) Coerce all false values to the numerica...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 278e47b4b0013c6e0821b61d05cbeb350dc684ee
https://github.com/dreamwidth/dw-free/commit/278e47b4b0013c6e0821b61d05cbeb350dc684ee
Author: Afuna <fu@dreamwidth.org>
Date: 2013-01-09 (Wed, 09 Jan 2013)

Changed paths:
M cgi-bin/LJ/User.pm

Log Message:
-----------
(Bug 4719) Coerce all false values to the numerical 0

We can't rely on defined-ness. The cached value is stored as an empty
string when there are no points, so it fails the defined test and
doesn't get set to 0. Then in the frontend it gets printed as an empty
string...

This means that on production, or anywhere else with memcache on, first
time you load the page you'll get "you have 0 points". On subsequent
loads it becomes "you have points". Misleading! Annoying! Weird.


Commit: 626fb58aee8c34982db5e6afc3fbf4b4c410c2d2
https://github.com/dreamwidth/dw-free/commit/626fb58aee8c34982db5e6afc3fbf4b4c410c2d2
Author: Afuna <afunamatata+github@gmail.com>
Date: 2013-01-10 (Thu, 10 Jan 2013)

Changed paths:
M cgi-bin/LJ/User.pm

Log Message:
-----------
Merge pull request #205 from afuna/disappearing-zero-bug4719

(Bug 4719) Coerce all false values to the numerical 0


Compare: https://github.com/dreamwidth/dw-free/compare/954165cc46c5...626fb58aee8c