afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-04-18 11:34 am

[dw-free] CSS for comment/entry interaction/management links needs to be fixed

[commit: http://hg.dwscoalition.org/dw-free/rev/fc47183bbb0b]

http://bugs.dwscoalition.org/show_bug.cgi?id=869

Alt text on the read page. Every userpic on the site should have proper alt
text now.

Patch by [personal profile] jadelennox.

Files modified:
  • cgi-bin/LJ/S2/FriendsPage.pm
--------------------------------------------------------------------------------
diff -r fd42aca8b1a4 -r fc47183bbb0b cgi-bin/LJ/S2/FriendsPage.pm
--- a/cgi-bin/LJ/S2/FriendsPage.pm	Sat Apr 18 06:32:53 2009 +0000
+++ b/cgi-bin/LJ/S2/FriendsPage.pm	Sat Apr 18 11:34:07 2009 +0000
@@ -328,17 +328,12 @@ sub FriendsPage
             'comments' => $comments,
             'new_day' => 0,  # setup below
             'end_day' => 0,  # setup below
-            'userpic' => undef,
+            'userpic' => Image_userpic( $picu, $picid, $eobj->userpic_kw_from_props( $logprops{$datakey} ) ),
             'tags' => \@taglist,
             'permalink_url' => $permalink,
             'moodthemeid' => $moodthemeid,
         });
         $entry->{'_ymd'} = join('-', map { $entry->{'time'}->{$_} } qw(year month day));
-
-        if ($picid && $picu) {
-            push @userpic_load, [ $picu, $picid ];
-            push @{$objs_of_picid{$picid}}, \$entry->{'userpic'};
-        }
 
         push @{$p->{'entries'}}, $entry;
         $eventnum++;
@@ -360,18 +355,6 @@ sub FriendsPage
             $p->{'entries'}->[$last]->{'end_day'} = 1;
             $i = $last;
         }
-    }
-
-    # load the pictures that were referenced, then retroactively populate
-    # the userpic fields of the Entries above
-    my %userpics;
-    LJ::load_userpics(\%userpics, \@userpic_load);
-
-    foreach my $picid (keys %userpics) {
-        my $up = Image("$LJ::USERPIC_ROOT/$picid/$userpics{$picid}->{'userid'}",
-                       $userpics{$picid}->{'width'},
-                       $userpics{$picid}->{'height'});
-        foreach (@{$objs_of_picid{$picid}}) { $$_ = $up; }
     }
 
     # make the skip links
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org