fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2012-02-14 05:45 pm

[dw-free] Styles: refactor the CSS styling of the navlinks module to remove the absolute positioning

[commit: http://hg.dwscoalition.org/dw-free/rev/dc71eb43ca95]

http://bugs.dwscoalition.org/show_bug.cgi?id=3078

Remove absolute positioning in Modular. Remove obsolete browser-specific
border radius properties and adjust module header for Starry Night theme.

Patch by [personal profile] ninetydegrees.

Files modified:
  • bin/upgrading/s2layers/modular/layout.s2
  • bin/upgrading/s2layers/modular/themes.s2
--------------------------------------------------------------------------------
diff -r f24d2e4438a9 -r dc71eb43ca95 bin/upgrading/s2layers/modular/layout.s2
--- a/bin/upgrading/s2layers/modular/layout.s2	Wed Feb 15 01:40:32 2012 +0800
+++ b/bin/upgrading/s2layers/modular/layout.s2	Wed Feb 15 01:44:47 2012 +0800
@@ -145,28 +145,6 @@
         .comment .userpic { float: right; }";
     }
 
-
-var string navlinks_css = "";
-    if ($*module_navlinks_section == "header") {
-        $navlinks_css = ".module-navlinks { position: absolute; 
-                top: 1.75em; 
-                right: 2em;
-                border: none;
-                background-color: transparent;
-                }
-            .module-navlinks li { display: inline;
-                padding-left: .5em;
-                border-left: 1px solid $*color_page_title;
-                }
-            .module-navlinks ul > li:first-child { border-left: none; }
-            .module-navlinks .module-header { display: none; }
-            .module-navlinks a { color: $*color_page_title; }
-            #header { padding-top: 1.5em; }";
-    }
-    else {
-        $navlinks_css = "";
-    }
-
 """
 
 /* Modular  */
@@ -540,9 +518,39 @@
 
 .module-userprofile .module-content { text-align: center; }
 
-.module-navlinks a.current { font-weight: bold; }
+#header .module-navlinks {
+    background-color: transparent;
+    border: none;
+    margin-bottom: 0;
+    margin-right: 1em;
+    text-align: right;
+    }
 
-$navlinks_css
+#header .module-navlinks .module-content {
+    padding: .5em 0 0;
+    }
+
+#header .module-navlinks li {
+    border-left: 1px solid $*color_page_title;
+    display: inline;
+    padding-left: .5em;
+    }
+
+#header .module-navlinks ul > li:first-child {
+    border-left: none;
+    }
+
+#header .module-navlinks .module-header {
+    display: none;
+    }
+
+#header .module-navlinks a {
+    color: $*color_page_title;
+    }
+
+.module-navlinks a.current {
+    font-weight: bold;
+    }
 
 """;
 }
diff -r f24d2e4438a9 -r dc71eb43ca95 bin/upgrading/s2layers/modular/themes.s2
--- a/bin/upgrading/s2layers/modular/themes.s2	Wed Feb 15 01:40:32 2012 +0800
+++ b/bin/upgrading/s2layers/modular/themes.s2	Wed Feb 15 01:44:47 2012 +0800
@@ -1008,9 +1008,10 @@
     .module-wrapper, #entries, #archive-year, #archive-month, #archive-day, .tags-container {
         background-color: $*color_entry_background;
         border-radius: .5em;
-        -moz-border-radius: .5em;
-        -webkit-border-radius: .5em;
-        -khtml-border-radius: .5em;
+        }
+
+    #header .module-wrapper {
+        background: none;
         }
 
     .module-navlinks a:visited {
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org