fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-09-30 02:31 am

[dw-free] Minor issue: add more "save" buttons for Manage Circle page

[commit: http://hg.dwscoalition.org/dw-free/rev/534864c3f093]

http://bugs.dwscoalition.org/show_bug.cgi?id=3864

Add a save button in between all sections, added to the space where there
are currently anchors to the other sections. (Welcome, woggy!)

Patch by [personal profile] batrachian.

Files modified:
  • htdocs/manage/circle/edit.bml
--------------------------------------------------------------------------------
diff -r 014e2e08b861 -r 534864c3f093 htdocs/manage/circle/edit.bml
--- a/htdocs/manage/circle/edit.bml	Thu Sep 29 18:00:47 2011 -0500
+++ b/htdocs/manage/circle/edit.bml	Fri Sep 30 10:29:14 2011 +0800
@@ -65,8 +65,7 @@
         $ret .= "<?h2 $ML{'.circle.header'} h2?>\n";
 
         # little standout box to repeat before each section:
-
-        my $standoutbox .= "<?standout " . BML::ml( '.circle.standout', { aopts1 => "href='#editpeople'", aopts2 => "href='#editcomms'", aopts3 => "href='#editfeeds'" }) . "standout?><br />\n\n";
+        my $standoutbox .= "<?standout " . BML::ml( '.circle.standout', { aopts1 => "href='#editpeople'", aopts2 => "href='#editcomms'", aopts3 => "href='#editfeeds'" }) . "<br/>" . LJ::html_submit($ML{'.btn.save'}) . " standout?><br />\n\n";
 
         # does the circle exist
         if ( @all_circle_userids ) {
@@ -245,10 +244,10 @@
             $ret .= $generate_table->( 'comms', \@comm_userids ) . "<br>";
             $ret .= $standoutbox;
             $ret .= $generate_table->( 'feeds', \@feed_userids ) . "<br>";
+            $ret .= $standoutbox;
             $ret .= "</div>";
 
-            ### middleified submit block
-            $ret .= "<?standout " . LJ::html_submit($ML{'.btn.save'}) . " standout?>\n";
+
         } else {
             $ret .= "<p>$ML{'.circle.nocircle'}</p><br><br>\n\n";
         }
@@ -360,7 +359,7 @@
         $ret .= "</table></div><br />";
 
         ### ending submit block
-        $ret .= "<?standout " . LJ::html_submit($ML{'.btn.save2'}) . " standout?>\n";
+        $ret .= "<?standout " . LJ::html_submit( $ML{'.btn.save2'} ) . " standout?>\n";
         $ret .= "</form>\n";
 
         return $ret;
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org