afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-04-08 04:52 pm

[dw-free] cgi-bin/DW/Worker/DistributeInvites.pm does not compile

[commit: http://hg.dwscoalition.org/dw-free/rev/17b2899a2fe2]

http://bugs.dwscoalition.org/show_bug.cgi?id=677

Fix compilation error

Patch by [personal profile] pauamma.

Files modified:
  • cgi-bin/DW/Worker/DistributeInvites.pm
--------------------------------------------------------------------------------
diff -r f6789dcf3529 -r 17b2899a2fe2 cgi-bin/DW/Worker/DistributeInvites.pm
--- a/cgi-bin/DW/Worker/DistributeInvites.pm	Wed Apr 08 16:45:17 2009 +0000
+++ b/cgi-bin/DW/Worker/DistributeInvites.pm	Wed Apr 08 16:52:15 2009 +0000
@@ -40,7 +40,7 @@ sub retry_delay {
 
 sub keep_exit_status_for { 86400 } # 24 hours
 
-# TODO: tune value?
+# FIXME: tune value?
 sub grab_for { 600 }
 
 sub work {
@@ -48,7 +48,7 @@ sub work {
     my $arg = $job->arg;
 
     my ($req_uid, $uckey, $ninv, $reason)
-        = map delete $arg->{$_} qw( requester searchclass invites reason );
+        = map { delete $arg->{$_} } qw( requester searchclass invites reason );
 
     return $job->permanent_failure( "Unknown keys: " . join( ", ", keys %$arg ))
         if keys %$arg;
@@ -126,7 +126,7 @@ sub work {
             my $inv_peruser = int( $adj_ninv / $inv_nusers );
             $reqemail_vars->{peruser} = $inv_peruser;
 
-            # TODO: make magic number configurable
+            # FIXME: make magic number configurable
             for (my $start = 0; $start < $inv_nusers; $start += 1000) {
                 my $end = ($start + 999 < $inv_nusers)
                     ? $start + 999
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org