fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-04-08 01:14 pm

[dw-free] Rendering of embedded Flash content broke recently in FF

[commit: http://hg.dwscoalition.org/dw-free/rev/ea1623701681]

http://bugs.dwscoalition.org/show_bug.cgi?id=3593

Remove the type attribute when we remove the data attribute to avoid
problems in Firefox.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/CleanHTML.pm
--------------------------------------------------------------------------------
diff -r fd79f3fbf5de -r ea1623701681 cgi-bin/LJ/CleanHTML.pm
--- a/cgi-bin/LJ/CleanHTML.pm	Fri Apr 08 19:14:55 2011 +0800
+++ b/cgi-bin/LJ/CleanHTML.pm	Fri Apr 08 21:14:26 2011 +0800
@@ -657,6 +657,11 @@ sub clean
 
                     if ( $attr eq "data" ) {
                         delete $hash->{$attr};
+
+                        # type specifies the content type for the data specified by "data"
+                        # without the data, this has no useful effect
+                        # but may cause the object tag not to use the fallback values in Firefox
+                        delete $hash->{"type"};
                         next;
                     }
 
--------------------------------------------------------------------------------