fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-12-01 06:50 pm

[dw-free] Setting a color to transparent in the layout layer prevents detection of unset variables

[commit: http://hg.dwscoalition.org/dw-free/rev/55b8cd41beff]

http://bugs.dwscoalition.org/show_bug.cgi?id=3319

Remove color_property = "" instances, so that we can detect when a variable
is unset, or when we want it to be transparent.

Patch by [personal profile] fu.

Files modified:
  • bin/upgrading/s2layers/boxesandborders/layout.s2
  • bin/upgrading/s2layers/core2base/layout.s2
  • bin/upgrading/s2layers/drifting/layout.s2
  • bin/upgrading/s2layers/easyread/layout.s2
--------------------------------------------------------------------------------
diff -r 70889973bb4d -r 55b8cd41beff bin/upgrading/s2layers/boxesandborders/layout.s2
--- a/bin/upgrading/s2layers/boxesandborders/layout.s2	Thu Dec 02 01:59:46 2010 +0800
+++ b/bin/upgrading/s2layers/boxesandborders/layout.s2	Thu Dec 02 02:49:52 2010 +0800
@@ -32,9 +32,6 @@ propgroup colors_child {
     property use color_page_details_text;
 }
 
-set color_navigation_module_background = "";
-set color_calendar_module_emptyday_background = "";
-set color_calendar_module_hasday_background = "";
 set color_page_details_text = "#999";
 
 ##===============================
diff -r 70889973bb4d -r 55b8cd41beff bin/upgrading/s2layers/core2base/layout.s2
--- a/bin/upgrading/s2layers/core2base/layout.s2	Thu Dec 02 01:59:46 2010 +0800
+++ b/bin/upgrading/s2layers/core2base/layout.s2	Thu Dec 02 02:49:52 2010 +0800
@@ -80,67 +80,6 @@ propgroup colors {
     property use color_comment_title_background;
 
 }
-
-
-##===============================
-## Page Colors
-##===============================
-
-set color_page_background = "";
-set color_page_text = "";
-set color_page_link = "";
-set color_page_link_active = "";
-set color_page_link_hover = "";
-set color_page_link_visited = "";
-set color_page_border = "";
-set color_page_title = "";
-
-##===============================
-## Header and Footer Colors
-##===============================
-
-set color_header_background = "";
-set color_footer_background = "";
-set color_footer_link = "";
-set color_footer_link_active = "";
-set color_footer_link_hover = "";
-set color_footer_link_visited = "";
-
-##===============================
-## Entry Colors
-##===============================
-
-set color_entry_background = "";
-set color_entry_text = "";
-set color_entry_link = "";
-set color_entry_link_active = "";
-set color_entry_link_hover = "";
-set color_entry_link_visited = "";
-set color_entry_border = "";
-set color_entry_title = "";
-set color_entry_title_background = "";
-set color_entry_interaction_links = "";
-
-##===============================
-## Comment Colors
-##===============================
-
-set color_comment_title = "";
-set color_comment_title_background = "";
-
-##===============================
-## Module Colors
-##===============================
-
-set color_module_background = "";
-set color_module_text = "";
-set color_module_link = "";
-set color_module_link_active = "";
-set color_module_link_hover = "";
-set color_module_link_visited = "";
-set color_module_title = "";
-set color_module_title_background = "";
-set color_module_border = "";
 
 ##===============================
 ## Display settings - fonts
diff -r 70889973bb4d -r 55b8cd41beff bin/upgrading/s2layers/drifting/layout.s2
--- a/bin/upgrading/s2layers/drifting/layout.s2	Thu Dec 02 01:59:46 2010 +0800
+++ b/bin/upgrading/s2layers/drifting/layout.s2	Thu Dec 02 02:49:52 2010 +0800
@@ -46,27 +46,6 @@ propgroup colors
         des = "Page subtitle color";
     }
 }
-
-set color_page_background         = "";
-set color_page_text               = "";
-set color_page_link               = "";
-set color_page_link_visited       = "";
-set color_page_link_active        = "";
-set color_page_border             = "";
-
-set color_header_background       = "";
-
-set color_module_border           = "";
-set color_module_title            = "";
-
-set color_entry_border            = "";
-set color_entry_background        = "";
-set color_entry_title             = "";
-set color_entry_text              = "";
-
-set color_page_title              = "";
-set color_page_subtitle           = "";
-
 
 # IMAGES
 ################################################################################
diff -r 70889973bb4d -r 55b8cd41beff bin/upgrading/s2layers/easyread/layout.s2
--- a/bin/upgrading/s2layers/easyread/layout.s2	Thu Dec 02 01:59:46 2010 +0800
+++ b/bin/upgrading/s2layers/easyread/layout.s2	Thu Dec 02 02:49:52 2010 +0800
@@ -50,31 +50,6 @@ propgroup colors {
     property use color_entry_text;
   
 }
-
-##===============================
-## Page Colors
-##===============================
-
-set color_page_background = "";
-set color_page_text = "";
-set color_page_link = "";
-set color_page_link_active = "";
-set color_page_link_visited = "";
-set color_page_title = "";
-set color_page_border = "";
-
-##===============================
-## Header and Footer Colors
-##===============================
-
-set color_header_background = "";
-
-##===============================
-## Entry Colors
-##===============================
-
-set color_entry_background = "";
-set color_entry_text = "";
 
 ##===============================
 ## Display settings - fonts
--------------------------------------------------------------------------------