kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2009-10-27 08:43 pm

[dw-free] AJAX tracking prevents "track comments to this entry" from being opened in a ne

[commit: http://hg.dwscoalition.org/dw-free/rev/fbc88a77756e]

http://bugs.dwscoalition.org/show_bug.cgi?id=1978

Don't load Javascript tracker on cmd-click or ctrl-click.

Patch by [personal profile] afuna.

Files modified:
  • htdocs/js/esn.js
--------------------------------------------------------------------------------
diff -r c87cef0eb638 -r fbc88a77756e htdocs/js/esn.js
--- a/htdocs/js/esn.js	Mon Oct 26 23:27:26 2009 +0000
+++ b/htdocs/js/esn.js	Tue Oct 27 15:43:01 2009 -0500
@@ -83,6 +83,9 @@ ESN.trackBtnClickHandler = function (evt
 ESN.trackBtnClickHandler = function (evt) {
     var trackBtn = evt.target;
     if ( ! trackBtn ) return true;
+
+    // don't show the popup if we want to open it in a new tab (ctrl+click or cmd+click)
+    if (evt && (evt.ctrlKey || evt.metaKey)) return false;
 
     trackBtn.isIcon = false;
 
--------------------------------------------------------------------------------