kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2009-10-19 01:27 pm

[dw-free] Apply theme button is far away from the theme name above it

[commit: http://hg.dwscoalition.org/dw-free/rev/1d912d9ba9cb]

http://bugs.dwscoalition.org/show_bug.cgi?id=1950

Tweak HTML/CSS to better format boxes on style selection page.

Patch by [personal profile] afuna.

Files modified:
  • cgi-bin/LJ/Widget/ThemeChooser.pm
  • htdocs/stc/widgets/themechooser.css
--------------------------------------------------------------------------------
diff -r 19bd8359e62f -r 1d912d9ba9cb cgi-bin/LJ/Widget/ThemeChooser.pm
--- a/cgi-bin/LJ/Widget/ThemeChooser.pm	Sun Oct 18 17:37:19 2009 +0000
+++ b/cgi-bin/LJ/Widget/ThemeChooser.pm	Mon Oct 19 08:26:52 2009 -0500
@@ -190,7 +190,7 @@ sub render_body {
 
         my $layout_link = "<a href='$LJ::SITEROOT/customize/$getextra${getsep}layoutid=" . $theme->layoutid . "$filterarg$showarg' class='theme-layout'><em>$theme_layout_name</em></a>";
         my $special_link_opts = "href='$LJ::SITEROOT/customize/$getextra${getsep}cat=special$filterarg$showarg' class='theme-cat'";
-        $ret .= "<p class='theme-desc'>";
+        $ret .= "<div class='theme-action'><p class='theme-desc'>";
         if ($theme_designer) {
             my $designer_link = "<a href='$LJ::SITEROOT/customize/$getextra${getsep}designer=" . LJ::eurl($theme_designer) . "$filterarg$showarg' class='theme-designer'>$theme_designer</a>";
             if ($theme_types{special}) {
@@ -217,7 +217,7 @@ sub render_body {
             );
             $ret .= $class->end_form;
         }
-        $ret .= "</div><!-- end .theme-item -->";
+        $ret .= "</div><!-- end .theme-action --></div><!-- end .theme-item -->";
     }
     $ret .= "</div><!-- end .themes-area --->";
 
diff -r 19bd8359e62f -r 1d912d9ba9cb htdocs/stc/widgets/themechooser.css
--- a/htdocs/stc/widgets/themechooser.css	Sun Oct 18 17:37:19 2009 +0000
+++ b/htdocs/stc/widgets/themechooser.css	Mon Oct 19 08:26:52 2009 -0500
@@ -42,9 +42,11 @@
 }
 .theme-item .theme-desc {
     font-size: 10px;
+    margin: 0;
+}
+.theme-item .theme-action {
+    height: 6em;
     padding: 4px 0 6px 0;
-    margin: 0;
-    height: 4em;
 }
 .theme-item.special h4,
 .theme-item.special .theme-desc {
--------------------------------------------------------------------------------