afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-10-08 05:41 pm

[dw-free] Use accessors, instead of hash lookup (better coding style).

[commit: http://hg.dwscoalition.org/dw-free/rev/6b836705206b]

Use accessors, instead of hash lookup (better coding style).

Patch by [personal profile] afuna.

Files modified:
  • cgi-bin/DW/Widget/ReadingList.pm
--------------------------------------------------------------------------------
diff -r aae74d041e9f -r 6b836705206b cgi-bin/DW/Widget/ReadingList.pm
--- a/cgi-bin/DW/Widget/ReadingList.pm	Thu Oct 08 17:34:36 2009 +0000
+++ b/cgi-bin/DW/Widget/ReadingList.pm	Thu Oct 08 17:41:16 2009 +0000
@@ -43,7 +43,7 @@ sub render_body {
         $ret .= $class->ml( 'widget.readinglist.filters.title' );
         $ret .= "<ul>";
         foreach my $filter ( @filters ) {
-            $ret .= "<li><a href='" . $remote->journal_base . "/read/" . LJ::eurl( $filter->{name} ) . "'>" . $filter->{name} . "</a></li>\n";
+            $ret .= "<li><a href='" . $remote->journal_base . "/read/" . LJ::eurl( $filter->name ) . "'>" . $filter->name . "</a></li>\n";
         }
         $ret .= "</ul>";
     } else {
--------------------------------------------------------------------------------
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2009-10-08 05:42 pm (UTC)(link)
And the useless use of 'use DW::User::ContentFilters'.

The LJ::User object already loads all of the ContentFilter code, you don't have to do it...