afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-09-11 02:21 pm

[dw-free] "Mass action on selected comments" has no <label>

[commit: http://hg.dwscoalition.org/dw-free/rev/4adaa4a856ec]

http://bugs.dwscoalition.org/show_bug.cgi?id=1658

(Insert label here)

Patch by [personal profile] afuna.

Files modified:
  • cgi-bin/LJ/S2.pm
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r 863165dfc54e -r 4adaa4a856ec cgi-bin/LJ/S2.pm
--- a/cgi-bin/LJ/S2.pm	Fri Sep 11 13:47:03 2009 +0000
+++ b/cgi-bin/LJ/S2.pm	Fri Sep 11 14:20:57 2009 +0000
@@ -3657,8 +3657,8 @@ sub EntryPage__print_multiform_actionlin
     my ($ctx, $this) = @_;
     return unless $this->{'multiform_on'};
     my $pr = $ctx->[S2::PROPS];
-    $S2::pout->($pr->{'text_multiform_des'} . "\n" .
-                LJ::html_select({'name' => 'mode' },
+    $S2::pout->( LJ::labelfy( 'multiform_mode', $pr->{text_multiform_des} ) . "\n" .
+                LJ::html_select( { name => 'mode', id => 'multiform_mode' },
                                 "" => "",
                                 map { $_ => $pr->{"text_multiform_opt_$_"} }
                                 qw(unscreen screen delete deletespam)) . "\n" .
diff -r 863165dfc54e -r 4adaa4a856ec htdocs/talkread.bml
--- a/htdocs/talkread.bml	Fri Sep 11 13:47:03 2009 +0000
+++ b/htdocs/talkread.bml	Fri Sep 11 14:20:57 2009 +0000
@@ -837,8 +837,8 @@ body<=
             $ret .= "<div align='center'>" . LJ::make_qr_target('bottom') . "</div>" if $remote;
 
             if ($showmultiform && $multiform_selects) {
-                $ret .= "<p>$ML{'.talkmulti.des'} ";
-                $ret .= LJ::html_select({'name' => 'mode' },
+                $ret .= "<p><label for='multiform_mode'>$ML{'.talkmulti.des'}</label>";
+                $ret .= LJ::html_select( { name => 'mode', id => 'multiform_mode' },
                                         ''           => '',
                                         'unscreen'   => $ML{'.talkmulti.unscreen'},
                                         'screen'     => $ML{'.talkmulti.screen'},
--------------------------------------------------------------------------------