[dw-free] crossposter: no check made for validity of entered account

[mark]

[commit: http://hg.dwscoalition.org/dw-free/rev/c55b614aff8a]

http://bugs.dwscoalition.org/show_bug.cgi?id=1142

Add some more explanatory text to the xpost configuration page, and cleanup
some whitespace.

Patch by yvi.

Files modified:

• htdocs/manage/externalaccount.bml
• htdocs/manage/externalaccount.bml.text

--------------------------------------------------------------------------------
diff -r 97507ad74d5a -r c55b614aff8a htdocs/manage/externalaccount.bml
--- a/htdocs/manage/externalaccount.bml	Tue Aug 11 06:02:10 2009 +0000
+++ b/htdocs/manage/externalaccount.bml	Tue Aug 11 06:04:27 2009 +0000
@@ -77,8 +77,9 @@ use strict;
     foreach my $protocol (keys %protocols) {
         $protocolselectmap{$protocol} = $protocol;
     }
-    
-    
+
+    $body .= "<br />";
+
     $body .= "<tr><td class='setting_label'><label for='site'>" . $ML{'.setting.xpost.option.site'} . "</label></td>";
     if ($editpage) {
         $body .= "<td>" . $editacct->servername . "</td>\n";
@@ -122,7 +123,6 @@ use strict;
             maxlength => 80,
                                         });
 
-        
         my $servicename_errdiv = errdiv(\%errs, "servicename");
         $body .= "<br />$servicename_errdiv" if $servicename_errdiv;
         $body .= "</td></tr>\n";
@@ -140,7 +140,7 @@ use strict;
         my $serviceurl_errdiv = errdiv(\%errs, "serviceurl");
         $body .= "<br />$serviceurl_errdiv" if $serviceurl_errdiv;
         $body .= "</td></tr>\n";
-        
+
         $body .= "</table>"; # end customsite table
         $body .= "</td></tr>\n"; # end 
     }
@@ -157,11 +157,12 @@ use strict;
             size => 40,
             maxlength => 80,
                                         });
+        $body .= "<br /><em>$ML{'.setting.xpost.option.username.info'}</em>";
         my $username_errdiv = errdiv(\%errs, "username");
         $body .= "<br />$username_errdiv" if $username_errdiv;
         $body .= "</td></tr>\n";
     }
-    
+
     $body .= "<tr><td class='setting_label'><label for='password'>" . $ML{'.setting.xpost.option.password'} . "</label></td>";
 
     # we don't have the password itself, so either use "" (for no password /
@@ -175,11 +176,11 @@ use strict;
         maxlength => 80,
         type => 'password'
     });
+    $body .= "<br /><em>$ML{'.setting.xpost.option.password.info'}</em>";
     my $password_errdiv = errdiv(\%errs, "password");
-        $body .= "<br />$password_errdiv" if $password_errdiv;
-        $body .= "</td></tr>\n";
+    $body .= "<br />$password_errdiv" if $password_errdiv;
+    $body .= "</td></tr>\n";
 
-    
     $body .= "<tr><td class='setting_label'><label for='xpostbydefault'>" . $ML{'.setting.xpost.option.xpostbydefault'} . "</label></td>";
     $body .= "<td>" . LJ::html_check({
         name     => "xpostbydefault",
@@ -192,9 +193,10 @@ use strict;
         $body .= "</td></tr>\n";
 
     $body .= "<tr><td>";
+    $body .= "<br />";
     $body .= LJ::html_submit(undef, $editpage ? $ML{'.btn.update'} : $ML{'.btn.create'});
     $body .="</td></tr>\n";
-    
+
     $body .= "</table>";
     $body .= "</div>";
     $body .= "</form>";
diff -r 97507ad74d5a -r c55b614aff8a htdocs/manage/externalaccount.bml.text
--- a/htdocs/manage/externalaccount.bml.text	Tue Aug 11 06:02:10 2009 +0000
+++ b/htdocs/manage/externalaccount.bml.text	Tue Aug 11 06:04:27 2009 +0000
@@ -22,8 +22,9 @@
 
 .settings.xpost.error.username.required=Username is required.
 
+.setting.xpost.option.password=Password
 
-.setting.xpost.option.password=Password
+.setting.xpost.option.password.info=(Please make sure you have caps-lock disabled and enter the correct password.)
 
 .setting.xpost.option.servicename=Custom Service Name
 
@@ -39,6 +40,8 @@
 
 .setting.xpost.option.username=Username
 
+.setting.xpost.option.username.info=(Please enter a valid username on the selected service. Crossposting to community accounts is not possible.)
+
 .setting.xpost.option.xpostbydefault=Cross Post by Default
 
 .title.edit=Edit External Account
--------------------------------------------------------------------------------