Feb. 12th, 2017

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1866146ec1b4e9cd952de48353f102dd33659f3a
https://github.com/dreamwidth/dw-free/commit/1866146ec1b4e9cd952de48353f102dd33659f3a
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
A bin/erase-imported-content
R bin/erase-imported-content.pl
A bin/importadm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Comments.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Entries.pm
M cgi-bin/DW/Worker/ContentImporter/Local/Entries.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/User/Account.pm
M cgi-bin/LJ/User/Display.pm
M cgi-bin/LJ/Widget/ImportChooseSource.pm

Log Message:
-----------
Update importer

This is a collection of fixes over the past two months since the
importer was under heavier use. Also some tooling updates.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: d6e83bde7c848f107df6e6ceda4c93a388528bb1
https://github.com/dreamwidth/dw-free/commit/d6e83bde7c848f107df6e6ceda4c93a388528bb1
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M bin/worker/esn-process-sub
M cgi-bin/DW/Stats.pm

Log Message:
-----------
Updates
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 774f909fb8bc5796c10c256c04b0ed0eaf9e906f
https://github.com/dreamwidth/dw-free/commit/774f909fb8bc5796c10c256c04b0ed0eaf9e906f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
[#1931] delete associated thumbnails when a media image is deleted

This calls the parent method to do the deletion as before,
then looks for other versions of the same image to also
delete from storage once the original is gone.

Fixes #1931.


Commit: e69e7d5c029c73508a944ea4e52bd8ede85c93b6
https://github.com/dreamwidth/dw-free/commit/e69e7d5c029c73508a944ea4e52bd8ede85c93b6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm

Log Message:
-----------
[#1940] don't count deleted files against quotas

I realized when testing the new delete method that the
relevant rows in media_versions are preserved, so we
need to crosscheck against the 'state' column of the
media table and make sure we aren't counting the
sizes of deleted files against the user's quota.


Commit: ef8d8017fc90c0ec2b34cba1d0787fb594385389
https://github.com/dreamwidth/dw-free/commit/ef8d8017fc90c0ec2b34cba1d0787fb594385389
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
incorporate feedback from code review


Commit: 443c194f10f03aa192bd2ea5f9171929a5d6ac76
https://github.com/dreamwidth/dw-free/commit/443c194f10f03aa192bd2ea5f9171929a5d6ac76
Author: Mark Smith <mark@qq.is>
Date: 2017-02-12 (Sun, 12 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
Merge pull request #1969 from kareila/1931-delete-thumbnails

delete associated thumbnails when a media image is deleted


Compare: https://github.com/dreamwidth/dw-free/compare/d6e83bde7c84...443c194f10f0
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: 188786a92f5f72891f7854098bd20e20d13eb241
https://github.com/dreamwidth/dw-free/commit/188786a92f5f72891f7854098bd20e20d13eb241
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
fix undefined string warnings

Use of uninitialized value in pattern match (m//) .. cgi-bin/LJ/CleanHTML.pm line 1419.

Use of uninitialized value in concatenation (.) or string .. cgi-bin/DW/Controller/Entry.pm line 1496.


Commit: 378067bd62597abf5fb6d2c87c2025a544c7dda9
https://github.com/dreamwidth/dw-free/commit/378067bd62597abf5fb6d2c87c2025a544c7dda9
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
[#1948] add wbr tag to list of void elements

Should be treated the same as the br tag.

This fixes the reported problem where if someone
used in an entry, it would get autoclosed
with , which is invalid markup. Now it
will get changed to instead.


Commit: b57bc0fef6d34b814f51903eb7df75a13bcc8f5f
https://github.com/dreamwidth/dw-free/commit/b57bc0fef6d34b814f51903eb7df75a13bcc8f5f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1948] prefer punctuation points for word breaks

In most areas (entries, subjects, comments) the HTML cleaner will
insert a wbr tag in any "word" (text unbroken by whitespace)
longer than 40 characters, exactly at the 40th character point,
and for every 40 characters thereafter, if autoformatting is active.

This behavior could be improved, so let's try checking each
40 characters for punctuation characters, and if found, insert
the word break at that point instead.


Commit: 81580e1ce9e68dc3253db014e0b481372a374814
https://github.com/dreamwidth/dw-free/commit/81580e1ce9e68dc3253db014e0b481372a374814
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-01-24 (Tue, 24 Jan 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1948] tweaks for word break behavior

1. The \B match failed if the word ended with punctuation, so just check to
see if we're at the end of the word after the match succeeds.

2. Make sure the regex finds the LAST punctuation character in the string.
Unexpectedly, it was matching the first one instead.

3. Don't do a breakpoint shift if the last punctuation character in the string
is the first character in the string - a common edge case resulting in a
premature word break.

4. Refactor printing logic to remove unneeded else case from conditional.

Also: more tests! Tests are great.


Commit: 66e9cc108b775758600678ad83373e97477ca928
https://github.com/dreamwidth/dw-free/commit/66e9cc108b775758600678ad83373e97477ca928
Author: Mark Smith <mark@qq.is>
Date: 2017-01-31 (Tue, 31 Jan 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
Merge pull request #1949 from kareila/1948-wbr-fix

better automatic word-break behavior


Commit: 9865ffb44ccef10c5687231dd232c89282c5d144
https://github.com/dreamwidth/dw-free/commit/9865ffb44ccef10c5687231dd232c89282c5d144
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-01 (Wed, 01 Feb 2017)

Changed paths:
M cgi-bin/DW/Pay.pm

Log Message:
-----------
fix variable reuse warning in DW::Pay

"my" variable $rv masks earlier declaration in same scope .. cgi-bin/DW/Pay.pm line 533.

Traced this back to bd33881 - eval code added in two spots, but one of
the spots was already using $rv.

Changed the new $rv to use a different variable name, which means the
function will return the earlier $rv as before.


Commit: 0d75d726b15ec3c6c724839793611e3ea9d8d023
https://github.com/dreamwidth/dw-free/commit/0d75d726b15ec3c6c724839793611e3ea9d8d023
Author: Mark Smith <mark@qq.is>
Date: 2017-02-01 (Wed, 01 Feb 2017)

Changed paths:
M cgi-bin/DW/Pay.pm

Log Message:
-----------
Merge pull request #1951 from kareila/cleanup-2017q1

fix variable reuse warning in DW::Pay


Commit: 84e27948efe2d9b55f7e0dc7b7d564e6333fdd55
https://github.com/dreamwidth/dw-free/commit/84e27948efe2d9b55f7e0dc7b7d564e6333fdd55
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
alphabetize and fix whitespace


Commit: d45ae4e4df764bd7577b351bf132fa43371df6db
https://github.com/dreamwidth/dw-free/commit/d45ae4e4df764bd7577b351bf132fa43371df6db
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1946] allow video embeds from Facebook


Commit: b488853922419872702bab1a89eeb9fdbf539c3a
https://github.com/dreamwidth/dw-free/commit/b488853922419872702bab1a89eeb9fdbf539c3a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1920] allow video embeds from CNN


Commit: dbd30be90e5877cd76297f6003627d6f5498b533
https://github.com/dreamwidth/dw-free/commit/dbd30be90e5877cd76297f6003627d6f5498b533
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1908] allow embeds from 4shared.com


Commit: b03475f5f52d2cddad9348b18e0c668c5b7e8701
https://github.com/dreamwidth/dw-free/commit/b03475f5f52d2cddad9348b18e0c668c5b7e8701
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1906] allow embeds from playmoss.com


Commit: acc405f479240d91ec47f71aa6fccf8ef7eacff8
https://github.com/dreamwidth/dw-free/commit/acc405f479240d91ec47f71aa6fccf8ef7eacff8
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1860] allow embeds from onedrive.com


Commit: 58ca7938d37049f767dceebbe9f9f7189bd7a6ed
https://github.com/dreamwidth/dw-free/commit/58ca7938d37049f767dceebbe9f9f7189bd7a6ed
Author: Mark Smith <mark@qq.is>
Date: 2017-02-02 (Thu, 02 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
Merge pull request #1954 from kareila/embed_triage

Embed triage


Commit: 772464eacbec7f80e958017090b654a20e45ab47
https://github.com/dreamwidth/dw-free/commit/772464eacbec7f80e958017090b654a20e45ab47
Author: srukle <srukle@users.noreply.github.com>
Date: 2017-02-03 (Fri, 03 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm

Log Message:
-----------
Allow embeds from JSFiddle (#1837)

* Allow embeds from JSFiddle

Fixes #1713.


Commit: 91625b492aa35eaf3bc25f92fc678e2ed6471279
https://github.com/dreamwidth/dw-free/commit/91625b492aa35eaf3bc25f92fc678e2ed6471279
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm

Log Message:
-----------
make sure necessary module is loaded

Error loading DW::Controller::Entry: Bareword "LJ::CMAX_SUBJECT" not allowed while "strict subs" in use .. cgi-bin/DW/Controller/Entry.pm line 425.


Commit: 73ba87ef394c3e07cae5ab3e58318a5536f9b9db
https://github.com/dreamwidth/dw-free/commit/73ba87ef394c3e07cae5ab3e58318a5536f9b9db
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
fix undefined string warning

Use of uninitialized value $_[0] in lc .. cgi-bin/LJ/User/Account.pm line 1259.


Commit: 9ea4199a768c0cc42b42a907601a595ce763ac75
https://github.com/dreamwidth/dw-free/commit/9ea4199a768c0cc42b42a907601a595ce763ac75
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
jsfiddle embed cleanup

Put the site in correct alphabetical order, and add the test case.


Commit: 93ef028a575bd1054ae05d4061a4b5f7c2514b48
https://github.com/dreamwidth/dw-free/commit/93ef028a575bd1054ae05d4061a4b5f7c2514b48
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/LJ/Keywords.pm

Log Message:
-----------
fix undefined string warning

Use of uninitialized value $kw in pattern match (m//) .. cgi-bin/LJ/Keywords.pm line 65.


Commit: bdac2a5978e9c6dca74b58f88ba2b789995cf768
https://github.com/dreamwidth/dw-free/commit/bdac2a5978e9c6dca74b58f88ba2b789995cf768
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M htdocs/manage/circle/invite.bml

Log Message:
-----------
fix ML substitution mismatch in /manage/circle/invite

Use of uninitialized value in substitution iterator .. cgi-bin/LJ/Lang.pm line 609.

Traced this back to a translation string that specified "sitenameshort" in the code file and "sitename" in the text file.


Commit: 1f04282d862abddb87ad2bd21f7772b33e189631
https://github.com/dreamwidth/dw-free/commit/1f04282d862abddb87ad2bd21f7772b33e189631
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M htdocs/manage/circle/invite.bml

Log Message:
-----------
clean up trailing whitespace in /manage/circle/invite


Commit: 1b9651fab1d4cd9722fc926ee2d54f49ae3bdf60
https://github.com/dreamwidth/dw-free/commit/1b9651fab1d4cd9722fc926ee2d54f49ae3bdf60
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
[#1907] also look for http when given https

This works in my testing - if the OpenID account was
originally created with http, we can look up the existing
account with either http or https, instead of creating a
second account when the user switches to https.

Fixes #1907.


Commit: 7d324989296671d6e0d55f45c40b5a1fcbff4ba3
https://github.com/dreamwidth/dw-free/commit/7d324989296671d6e0d55f45c40b5a1fcbff4ba3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/LJ/User/Account.pm

Log Message:
-----------
eliminate redundant identitymap lookup code

I noticed that LJ::load_user_or_identity had code identical
to the previous functionality of LJ::User::load_existing_identity_user.
This updates the former to use the latter and benefit from
the improved handling of https URLs.


Commit: 24848d0c8873621a3f2c88e4f0bba5880e4be819
https://github.com/dreamwidth/dw-free/commit/24848d0c8873621a3f2c88e4f0bba5880e4be819
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M htdocs/inbox/compose.bml

Log Message:
-----------
[#1744] use username, not display_name, in msg_to

This allows the message to be delivered successfully
when replying to a PM from an OpenID user.

Fixes #1744.


Commit: eff1ff1fb0c7038243c1db8d54247dd92506764a
https://github.com/dreamwidth/dw-free/commit/eff1ff1fb0c7038243c1db8d54247dd92506764a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-04 (Sat, 04 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
M views/openid/claim.tt.text

Log Message:
-----------
[#1939] return an error if trying to claim a deleted account

This does the check at the interface layer to preempt possible
problems in the backend.

Fixes #1939.


Commit: 46d5ed977e7988d44817e5ec2ea172bb63400bbe
https://github.com/dreamwidth/dw-free/commit/46d5ed977e7988d44817e5ec2ea172bb63400bbe
Author: Mark Smith <mark@qq.is>
Date: 2017-02-06 (Mon, 06 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M cgi-bin/LJ/Keywords.pm
M cgi-bin/LJ/User/Account.pm
M htdocs/manage/circle/invite.bml
M t/embed-whitelist.t

Log Message:
-----------
Merge pull request #1955 from kareila/cleanup-2017q1

Cleanup 2017q1


Commit: c65a0c6c70247aa60bd4eff01b6812bafa74eb25
https://github.com/dreamwidth/dw-free/commit/c65a0c6c70247aa60bd4eff01b6812bafa74eb25
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M cgi-bin/Apache/BML.pm

Log Message:
-----------
return suffix-neutral URIs from BML::get_uri

@kaberett pointed out that when visiting /tools/importer without
being logged in, the returnto pointed to /tools/importer.bml.

This changes the behavior of BML::get_uri to strip the .bml suffix
from the return value. I checked all 3 places the function is
called and I believe this is the desired behavior in each case.


Commit: 48cf18ae634382f5308b9b0df5f97cd15c14512a
https://github.com/dreamwidth/dw-free/commit/48cf18ae634382f5308b9b0df5f97cd15c14512a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M t/00-compile.t

Log Message:
-----------
add compile checking of command line scripts

In the past, we've only done compile checking of modules
in cgi-bin. This adds similar checking for scripts in
the bin directory.

Since we don't actually want to execute the scripts,
we change the test condition to execute 'perl -c'
instead of 'perl' (which was OK for modules).
This only affects files ending in .pl -
files ending in .pm are tested differently.


Commit: fd790febc841f92c3240beb72939463822fc036c
https://github.com/dreamwidth/dw-free/commit/fd790febc841f92c3240beb72939463822fc036c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M bin/dev/newtheme.pl
M bin/ljubackup.pl
M t/00-compile.t

Log Message:
-----------
fix newly discovered CLI script warnings


Commit: 658174ec36417d60e6932914460de80a597ee66f
https://github.com/dreamwidth/dw-free/commit/658174ec36417d60e6932914460de80a597ee66f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1940] don't allow offsite loading of images

Check the page referer and only load if it's a page on
our site or a bare image URL.


Commit: 01f2dc69143ea6b2b96212cee077ac42220f56ba
https://github.com/dreamwidth/dw-free/commit/01f2dc69143ea6b2b96212cee077ac42220f56ba
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/EmailPost/Entry.pm
M cgi-bin/DW/Media.pm
M etc/config.pl

Log Message:
-----------
[#1940] image upload quotas

New usercap 'media_file_quota' which is 500 (MB) by default.

New methods for checking usage and quota in DW::Media.

New user method, can_upload_media, which is false if you've
gone over quota, true otherwise.

Added can_upload_media checks to the two places in the code
where upload_media is called.

Fixes #1940.


Commit: f1885131f9d80191ee42102515ff40f69d24ee06
https://github.com/dreamwidth/dw-free/commit/f1885131f9d80191ee42102515ff40f69d24ee06
Author: Mark Smith <mark@qq.is>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M bin/dev/newtheme.pl
M bin/ljubackup.pl
M t/00-compile.t

Log Message:
-----------
Merge pull request #1959 from kareila/compile-tests

add compile checking of command line scripts


Commit: c95821c146fd68c41408d2a6c83b479c67b7e9d7
https://github.com/dreamwidth/dw-free/commit/c95821c146fd68c41408d2a6c83b479c67b7e9d7
Author: Mark Smith <mark@qq.is>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M cgi-bin/Apache/BML.pm

Log Message:
-----------
Merge pull request #1958 from kareila/bml_returnto

return suffix-neutral URIs from BML::get_uri


Commit: 5ef9d6b808677812834d7fb93228f6470aa4780d
https://github.com/dreamwidth/dw-free/commit/5ef9d6b808677812834d7fb93228f6470aa4780d
Author: Mark Smith <mark@qq.is>
Date: 2017-02-07 (Tue, 07 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/EmailPost/Entry.pm
M cgi-bin/DW/Media.pm
M etc/config.pl

Log Message:
-----------
Merge pull request #1960 from kareila/1940-media-limit

enforce limits for media (photo) usage


Commit: 0c0e6c626e6f3bfb538db82608aa31d4e37a8cb6
https://github.com/dreamwidth/dw-free/commit/0c0e6c626e6f3bfb538db82608aa31d4e37a8cb6
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
M bin/checkconfig.pl
M bin/delete-bogus-media.pl
M bin/incoming-mail-inject.pl
M bin/maint/clean_caches.pl
R bin/upgrading/migrate-userpics.pl
M bin/upgrading/update-db-general.pl
M bin/upgrading/update-db.pl
M bin/worker/incoming-email
R bin/worker/userpic-resize-gm
M cgi-bin/Apache/LiveJournal.pm
A cgi-bin/DW/BlobStore.pm
A cgi-bin/DW/BlobStore/LocalDisk.pm
A cgi-bin/DW/BlobStore/MogileFS.pm
A cgi-bin/DW/BlobStore/S3.pm
M cgi-bin/DW/Controller/API/Media.pm
A cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Controller/RPC/MiscLegacy.pm
M cgi-bin/DW/EmailPost/Entry.pm
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm
M cgi-bin/DW/VirtualGift.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Userpics.pm
M cgi-bin/DW/Worker/ContentImporter/UserPictures.pm
M cgi-bin/LJ/ConfCheck/General.pm
M cgi-bin/LJ/Config.pm
M cgi-bin/LJ/Directory/Constraint.pm
M cgi-bin/LJ/Directory/SetHandle/Mogile.pm
R cgi-bin/LJ/IncomingEmailHandle.pm
M cgi-bin/LJ/User/Account.pm
M cgi-bin/LJ/User/Icons.pm
M cgi-bin/LJ/Userpic.pm
M cgi-bin/ljlib.pl
M cgi-bin/modperl_subs.pl
M etc/config-private.pl
M etc/config.pl
A etc/log4perl.conf
M etc/workers.conf
M htdocs/admin/vgifts/index.bml
M htdocs/editicons.bml
M htdocs/tools/userpicfactory.bml
M t/aliases.t
A t/blobstore.t
M t/directorysearch.t
M t/media-security.t

Log Message:
-----------
Start BlobStore

This starts implementation of BlobStore which will replace all the
various storage layers we use for userpics/media. The idea is that we
should have one simple storage system and offload the work to other
people instead of doing it all ourself.

This is first part in removing MogileFS. It's a really complicated
system that is better replaced by using something simple with frontend
caching and/or a file storage service other people provide.

(Although the BlobStore interface was made with the idea that it can
support MogileFS pretty easily, so it's not actually hard... if we added
'namespace' to the API then it'd be a drop-in replacement.)

Additionally this adds Log::Log4perl as an easy way of logging things in
a more uniform way. I'm tired of not having logging messages and this
adds a very basic method of logging (with Carp support) in such a way
that it shows up in the Apache logs, but in a very useful format that
includes the package/line number that is generating the logs.


Commit: 5d780ef420aac9dd3955bc886476c31276166cd7
https://github.com/dreamwidth/dw-free/commit/5d780ef420aac9dd3955bc886476c31276166cd7
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
M bin/checkconfig.pl
M bin/delete-bogus-media.pl
M bin/incoming-mail-inject.pl
M bin/maint/clean_caches.pl
R bin/upgrading/migrate-userpics.pl
M bin/upgrading/update-db-general.pl
M bin/upgrading/update-db.pl
M bin/worker/incoming-email
R bin/worker/userpic-resize-gm
M cgi-bin/Apache/LiveJournal.pm
A cgi-bin/DW/BlobStore.pm
A cgi-bin/DW/BlobStore/LocalDisk.pm
A cgi-bin/DW/BlobStore/MogileFS.pm
A cgi-bin/DW/BlobStore/S3.pm
M cgi-bin/DW/Controller/API/Media.pm
A cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Controller/RPC/MiscLegacy.pm
M cgi-bin/DW/EmailPost/Entry.pm
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm
M cgi-bin/DW/VirtualGift.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Userpics.pm
M cgi-bin/DW/Worker/ContentImporter/UserPictures.pm
M cgi-bin/LJ/ConfCheck/General.pm
M cgi-bin/LJ/Config.pm
M cgi-bin/LJ/Directory/Constraint.pm
M cgi-bin/LJ/Directory/SetHandle/Mogile.pm
R cgi-bin/LJ/IncomingEmailHandle.pm
M cgi-bin/LJ/User/Account.pm
M cgi-bin/LJ/User/Icons.pm
M cgi-bin/LJ/Userpic.pm
M cgi-bin/ljlib.pl
M cgi-bin/modperl_subs.pl
M etc/config-private.pl
M etc/config.pl
A etc/log4perl.conf
M etc/workers.conf
M htdocs/admin/vgifts/index.bml
M htdocs/editicons.bml
M htdocs/tools/userpicfactory.bml
M t/aliases.t
A t/blobstore.t
M t/directorysearch.t
M t/media-security.t

Log Message:
-----------
Merge pull request #1829 from zorkian/start-blobstore

Start BlobStore


Commit: 995fa7a1e48fc4dcef50733d603e3a3a37a83b49
https://github.com/dreamwidth/dw-free/commit/995fa7a1e48fc4dcef50733d603e3a3a37a83b49
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
A bin/upgrading/migrate-userpics.pl

Log Message:
-----------
resurrect old version of migrate-userpics.pl


Commit: 3b8996cfa35c931f44390d20ae53ab0f7b07f31b
https://github.com/dreamwidth/dw-free/commit/3b8996cfa35c931f44390d20ae53ab0f7b07f31b
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
M bin/upgrading/migrate-userpics.pl

Log Message:
-----------
move userpicblob2 data to blobstore


Commit: dc72fb79ca91cd7a24216bbe7b4edb5709d41668
https://github.com/dreamwidth/dw-free/commit/dc72fb79ca91cd7a24216bbe7b4edb5709d41668
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
M bin/upgrading/migrate-userpics.pl

Log Message:
-----------
use custom log4perl config


Commit: 65439455eec949821273c0f4a4c7c49a9e530441
https://github.com/dreamwidth/dw-free/commit/65439455eec949821273c0f4a4c7c49a9e530441
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
R bin/ljubackup.pl

Log Message:
-----------
remove bin/ljubackup.pl

Unused script which repeatedly runs ljbackup.pl (which
no longer exists) and copies the results into MogileFS
(which we are getting rid of).


Commit: b554607f40dc5c543581c8f6bf0e4145ab8e82fd
https://github.com/dreamwidth/dw-free/commit/b554607f40dc5c543581c8f6bf0e4145ab8e82fd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-08 (Wed, 08 Feb 2017)

Changed paths:
M bin/upgrading/update-db-general.pl

Log Message:
-----------
drop unused table backupdirty

Was only used in ljubackup.pl.


Commit: f372661cd79f18f0a62b0973d790a2439dfdd660
https://github.com/dreamwidth/dw-free/commit/f372661cd79f18f0a62b0973d790a2439dfdd660
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M bin/checkconfig.pl

Log Message:
-----------
checkconfig.pl cleanup

* Indicate MogileFS::Client is now optional.

* Enforce minimum version of Text::Wrap.

* Don't export module functions during load testing.

That last item fixes an odd error I was seeing:
`Prototype mismatch: sub main::validate: none vs (\@$) at /usr/share/perl/5.18/Exporter.pm line 66.`

The cause: Params::Validate and Business::CreditCard both export
functions named `validate`, with different argument prototypes.


Commit: 3a348ba563837478165ce1aca3295c1a31f9ba27
https://github.com/dreamwidth/dw-free/commit/3a348ba563837478165ce1aca3295c1a31f9ba27
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/modperl_subs.pl

Log Message:
-----------
stop including MogileFS::Client


Commit: 4c552568bc2db41aef555ada3947135112863003
https://github.com/dreamwidth/dw-free/commit/4c552568bc2db41aef555ada3947135112863003
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M t/blobstore.t

Log Message:
-----------
incorrect file name in header


Commit: 8aa43ed152f6f904eb2743d14ec3f09384076318
https://github.com/dreamwidth/dw-free/commit/8aa43ed152f6f904eb2743d14ec3f09384076318
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Photo.pm
M cgi-bin/DW/VirtualGift.pm
M htdocs/admin/vgifts/index.bml.text
M t/console-expungeuserpic.t
M t/directorysearch.t

Log Message:
-----------
remove other textual MogileFS references


Commit: 8bbcf3aeb755830dedea38908668555ceb0e27ef
https://github.com/dreamwidth/dw-free/commit/8bbcf3aeb755830dedea38908668555ceb0e27ef
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
R cgi-bin/LJ/ConfCheck.pm
R cgi-bin/LJ/ConfCheck/General.pm
M t/00-compile.t

Log Message:
-----------
[#1915] remove unused ConfCheck modules

Fixes #1915.


Commit: 578c6fef72476075827577cb3db9e4dbf7a94a56
https://github.com/dreamwidth/dw-free/commit/578c6fef72476075827577cb3db9e4dbf7a94a56
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/ljlib.pl

Log Message:
-----------
allow etc/log4perl.conf to be superceded by ext/local

Use LJ::resolve_file to prefer a version in ext/local
over the stock version in LJHOME, like we do for other
config files.


Commit: 2f2ad767e68fa8c7856dfae0ff9808aab7de570c
https://github.com/dreamwidth/dw-free/commit/2f2ad767e68fa8c7856dfae0ff9808aab7de570c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-10 (Fri, 10 Feb 2017)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/DW/Logic/MenuNav.pm

Log Message:
-----------
[#1942] add file/new, file/edit to menunav


Commit: 23f25444cf412a7957267e1c1d7e2f61311b2858
https://github.com/dreamwidth/dw-free/commit/23f25444cf412a7957267e1c1d7e2f61311b2858
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-10 (Fri, 10 Feb 2017)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Media.pm

Log Message:
-----------
don't let OpenID users upload files


Commit: 005e4eee36b2065339654ab2e54d943c812e7c94
https://github.com/dreamwidth/dw-free/commit/005e4eee36b2065339654ab2e54d943c812e7c94
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-10 (Fri, 10 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
[#1968] allow embeds from scratch.mit.edu


Commit: 5a9dbc689bae6fab5f4d68acaa2cec51b1e103d7
https://github.com/dreamwidth/dw-free/commit/5a9dbc689bae6fab5f4d68acaa2cec51b1e103d7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-10 (Fri, 10 Feb 2017)

Changed paths:
M etc/log4perl.conf

Log Message:
-----------
add comments explaining other log levels


Commit: 4802c5ad7862c011109fbcc9ba5d9b8c4c0a43c3
https://github.com/dreamwidth/dw-free/commit/4802c5ad7862c011109fbcc9ba5d9b8c4c0a43c3
Author: rshatch <ruth.s.hatch@gmail.com>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm
M htdocs/js/jquery.fileupload.js
M htdocs/scss/components/foundation-custom/_pagination.scss
M htdocs/scss/pages/media/new.scss
M htdocs/scss/skins/_skin-colors.scss
M htdocs/stc/media.css
M views/media/edit.tt
M views/media/edit.tt.text
A views/media/field-row.tt
M views/media/home.tt
M views/media/home.tt.text
M views/media/index.tt
M views/media/index.tt.text
M views/media/new.tt
M views/media/new.tt.text

Log Message:
-----------
Updates to the image uploader and management system (#1961)

* Updates to the image uploader and management system

-adds an index page with links to all subpages
-adds editable textfields for title, description and alt-text
-adds two views for showing all files, with pagination
-list view shows all info about the original file with embed code
for fullsized and selectable thumbnail sized versions of the image
-grid view shows title, file size and dimensions, and thumbnail embed code
-pload date and time is now shown in list view
-file list now displays correct text when no files have been uploaded
-all subpaes are now crosslinked with other subpages
-uploader page now has alt-text field, and displays message on successful upload
-language across pages has been standardized to say 'images' instead of a mix
of 'files' and 'images'.
-edit page has been converted to Foundation
-backend changes make original file's url, size, and dimensions available to
resized versions of that image

Fixes #1936.


Commit: 27853cffd20ef3ac19268998446e21bd9dce4191
https://github.com/dreamwidth/dw-free/commit/27853cffd20ef3ac19268998446e21bd9dce4191
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
[#1325] let register_string redirect pagename/ to pagename

Fixes #1325 for pages that use register_string.


Commit: 82c9100e7c1607d1fbabb3c91eb66a04c449c27d
https://github.com/dreamwidth/dw-free/commit/82c9100e7c1607d1fbabb3c91eb66a04c449c27d
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/OpenID.pm
M cgi-bin/LJ/User/Account.pm
M htdocs/inbox/compose.bml
M views/openid/claim.tt.text

Log Message:
-----------
Merge pull request #1956 from kareila/openid_fixes

OpenID fixes


Commit: 4a947554c47037a27fd2eb8a1d39e80bfefa4d8c
https://github.com/dreamwidth/dw-free/commit/4a947554c47037a27fd2eb8a1d39e80bfefa4d8c
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
R bin/ljubackup.pl
M bin/upgrading/update-db-general.pl

Log Message:
-----------
Merge pull request #1963 from kareila/remove-ljubackup

remove bin/ljubackup.pl


Commit: f0eb84dbaecc7a126f2c227d499b332b385279a6
https://github.com/dreamwidth/dw-free/commit/f0eb84dbaecc7a126f2c227d499b332b385279a6
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Hooks/EmbedWhitelist.pm
M t/embed-whitelist.t

Log Message:
-----------
Merge pull request #1971 from kareila/1968-scratch-embed

[#1968] allow embeds from scratch.mit.edu


Commit: 62b44d293a2bcc5992bb0a33fed0500241c74e23
https://github.com/dreamwidth/dw-free/commit/62b44d293a2bcc5992bb0a33fed0500241c74e23
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/ljlib.pl
M etc/log4perl.conf

Log Message:
-----------
Merge pull request #1967 from kareila/local-logconf

allow etc/log4perl.conf to be superceded by ext/local


Commit: 9c10ec38c42bb9f4fb269c7a15396d9109a5027e
https://github.com/dreamwidth/dw-free/commit/9c10ec38c42bb9f4fb269c7a15396d9109a5027e
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
R cgi-bin/LJ/ConfCheck.pm
R cgi-bin/LJ/ConfCheck/General.pm
M t/00-compile.t

Log Message:
-----------
Merge pull request #1965 from kareila/1915-confcheck

[#1915] remove unused ConfCheck modules


Commit: 3a83cd31fb8e10f935386092274b339ba6ee7478
https://github.com/dreamwidth/dw-free/commit/3a83cd31fb8e10f935386092274b339ba6ee7478
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
Merge pull request #1974 from kareila/1325-redirect

[#1325] let register_string redirect pagename/ to pagename


Commit: c616c8e9594081640f8da2341a41d32ce0728567
https://github.com/dreamwidth/dw-free/commit/c616c8e9594081640f8da2341a41d32ce0728567
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
A bin/upgrading/migrate-userpics.pl

Log Message:
-----------
Merge pull request #1962 from kareila/migrate-userpicblob2

Migrate userpicblob2 icons


Commit: e10aecfb69e58a42d1a4c42b2606844bbddc80d6
https://github.com/dreamwidth/dw-free/commit/e10aecfb69e58a42d1a4c42b2606844bbddc80d6
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M bin/checkconfig.pl
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Photo.pm
M cgi-bin/DW/VirtualGift.pm
M cgi-bin/modperl_subs.pl
M htdocs/admin/vgifts/index.bml.text
M t/blobstore.t
M t/console-expungeuserpic.t
M t/directorysearch.t

Log Message:
-----------
Merge pull request #1964 from kareila/cleanup-2017q1

Blobstore-related cleanup


Commit: 2dea49af161f563de4488ebc4d555774ea98416e
https://github.com/dreamwidth/dw-free/commit/2dea49af161f563de4488ebc4d555774ea98416e
Author: Mark Smith <mark@qq.is>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Logic/MenuNav.pm
M cgi-bin/DW/Media.pm

Log Message:
-----------
Merge pull request #1970 from kareila/1942-navmenu-files

[#1942] add file/new, file/edit to menunav


Compare: https://github.com/dreamwidth/dw-free/compare/73bb021de6ff...2dea49af161f

Profile

Dreamwidth Changelog

May 2017

S M T W T F S
  123456
789 10111213
14151617181920
21222324252627
28293031   

Most Popular Tags

Style Credit

Expand Cut Tags

No cut tags
Page generated May. 23rd, 2017 10:43 am
Powered by Dreamwidth Studios