github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2017-03-30 08:37 pm

[dreamwidth/dw-free] 68e2fa: Fix undefined value warning in DW/Controller/Searc...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 68e2fad088bca9dbc4bb7b34f1b6195f62f28905
https://github.com/dreamwidth/dw-free/commit/68e2fad088bca9dbc4bb7b34f1b6195f62f28905
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/Search/Interests.pm

Log Message:
-----------
Fix undefined value warning in DW/Controller/Search/Interests.pm

Use of uninitialized value in numeric ne (!=) at /home/dw/production/cgi-bin/DW/Controller/Search/Interests.pm line 410.


Commit: f34c80e2a42cb0f7aa7dc2286870aa63c760dc77
https://github.com/dreamwidth/dw-free/commit/f34c80e2a42cb0f7aa7dc2286870aa63c760dc77
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
remove vestiges of phonepost support from LJ/Feed.pm


Commit: f8e054f048b266fbaa3a4af27ec59a267c8a7ed0
https://github.com/dreamwidth/dw-free/commit/f8e054f048b266fbaa3a4af27ec59a267c8a7ed0
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/Global/Defaults.pm

Log Message:
-----------
remove nonexistent endpoints from %LJ::AJAX_URI_MAP


Commit: f22c9722ea097d9a48ad827a6af267f22bc81391
https://github.com/dreamwidth/dw-free/commit/f22c9722ea097d9a48ad827a6af267f22bc81391
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
R cgi-bin/LJ/Widget/FriendInterests.pm
R htdocs/js/widgets/friendinterests.js

Log Message:
-----------
remove unused module LJ/Widget/FriendInterests.pm


Commit: a39da19886e1c1425651182e1c149de0f06521de
https://github.com/dreamwidth/dw-free/commit/a39da19886e1c1425651182e1c149de0f06521de
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/RPC/Misc.pm
R htdocs/tools/endpoints/extacct_auth.bml.text

Log Message:
-----------
remove htdocs/tools/endpoints/extacct_auth.bml.text


Commit: 81e553832039380f87686aa942927b13ffcec447
https://github.com/dreamwidth/dw-free/commit/81e553832039380f87686aa942927b13ffcec447
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/DW/Hooks/PrivList.pm

Log Message:
-----------
remove siteadmin:entry_redirect from privilege list

The relevant page was removed in 06e8abf.


Commit: e643f2602bd8025e6b80e06249c825b7d6cc65b3
https://github.com/dreamwidth/dw-free/commit/e643f2602bd8025e6b80e06249c825b7d6cc65b3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M views/interests/int.tt

Log Message:
-----------
try to fix weird href parse error in logs

Seeing several errors similar to this:

`Argument "10330'"" isn't numeric in addition (+) at /home/dw/production/cgi-bin/DW/Controller/Search/Interests.pm line 298.`

The process of adding zero to the number with the extra trailing
punctuation results in the desired number, so it's not a bug per se,
but the error indicates that the page source isn't being parsed correctly
in some circumstances. I couldn't reproduce the problem in Firefox,
Chrome, or Safari.

I decided to update the template to use cleaner syntax for generating
the URL, hoping that this would prevent the parse error in the
future. If it continues to cause problems, the next step would be
to rewrite the ML string to avoid the need for string variable
interpolation in the caller. If nothing else, removing the escaped
ampersand from the URL arguments is an improvement.


Commit: f3b52d37d01f155216f1587c7ce06a7bc2585066
https://github.com/dreamwidth/dw-free/commit/f3b52d37d01f155216f1587c7ce06a7bc2585066
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/RPC/Misc.pm
M cgi-bin/DW/Controller/Search/Interests.pm
M cgi-bin/DW/Hooks/PrivList.pm
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/Global/Defaults.pm
R cgi-bin/LJ/Widget/FriendInterests.pm
R htdocs/js/widgets/friendinterests.js
R htdocs/tools/endpoints/extacct_auth.bml.text
M views/interests/int.tt

Log Message:
-----------
Merge pull request #2051 from kareila/cleanup-2017q1

Cleanup 2017q1 **bonus round**


Compare: https://github.com/dreamwidth/dw-free/compare/975f9b425ab5...f3b52d37d01f