![[personal profile]](http://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
![[site community profile]](http://www.dreamwidth.org/img/comm_staff.png){kind=small}
[dreamwidth/dw-free] 17bf9d: remove unused module LJ/Setting/Language.pm
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 17bf9d4288e746691fef3aa737e3a3409aed2778
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
R cgi-bin/LJ/Setting/Language.pm
M htdocs/manage/settings/index.bml.text
Log Message:
-----------
remove unused module LJ/Setting/Language.pm
Commit: b8127fb5bf9a72843f9afc8775b79728ded0d483
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/PollVote.pm
M htdocs/login.bml
M htdocs/support/see_request.bml
Log Message:
-----------
strip trailing whitespace
Commit: ca179ae0562d8d2b1cb53990b9f6a62200b2dcaa
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/Session.pm
M htdocs/login.bml
Log Message:
-----------
remove langpref cookie support
There was no effective way to ever set the cookie, and even
if there were, the code was never implemented to honor the
value of the cookie on non-BML pages.
Can still override the site's default language on a per-request
basis by using the "uselang" GET parameter.
Commit: 03322114a6dfd8a79da1a2d637b204f353ca98e7
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm
Log Message:
-----------
remove uses of 'browselang' in get_text calls
This prepares to get rid of the 'browselang' userprop in the next
commit; since there was no available way for the user to set it,
it was always undefined. Most of these changes simply make the
explicit choice to use $LJ::DEFAULT_LANG, which is effectively
what was happening already.
There's a subtle difference here between using LJ::Lang::ml
and using LJ::Lang::get_text with an undefined lang argument.
LJ::Lang::ml will use LJ::Lang::get_effective_lang, which picks
up any language selection from the web request. That's desired
when we're showing text to the remote user, but we don't always
want the same choice for the target of a particular action
being taken. Whereas LJ::Lang::get_text will always fall back
to the site default of $LJ::DEFAULT_LANG if the given lang is
undefined.
To make that clearer for future development, I've added a new
helper function, LJ::Lang::get_default_text, which works just
like calling LJ::Lang::get_text without the explicit undef
arguments. There's also a corresponding get_default_text_multi
for the modules that preload multiple static strings.
This may seem like overkill given our eventual aim to rip
out the translation system, but as long as we support URLs
using the "?uselang=" format, we need to make sure this
behavior is maintained.
Commit: 3b9f56d1362db54eb81a90eae1eb41bba244154d
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/proplists.dat
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text
Log Message:
-----------
remove browselang userprop
Was only set in LJ::Lang::set_lang, which was only called by
LJ/Setting/Language.pm, which was unused and removed.
LJ::Lang::set_lang is retained as a stub for future replacement
of BML::set_language as we move away from using BML.
Commit: d5d49cb66fb410b732924bfeda112b8d0d501296
https://github.com/dreamwidth/dw-free/
Author: Mark Smith <mark@qq.is>
Date: 2017-03-29 (Wed, 29 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
R cgi-bin/LJ/Setting/Language.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/manage/settings/index.bml.text
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text
Log Message:
-----------
Merge pull request #2031 from kareila/remove_setlang
Remove unused code for browselang
Compare: https://github.com/dreamwidth/dw-free/
Home: https://github.com/dreamwidth/dw-free
Commit: 17bf9d4288e746691fef3aa737e3a3409aed2778
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
R cgi-bin/LJ/Setting/Language.pm
M htdocs/manage/settings/index.bml.text
Log Message:
-----------
remove unused module LJ/Setting/Language.pm
Commit: b8127fb5bf9a72843f9afc8775b79728ded0d483
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/PollVote.pm
M htdocs/login.bml
M htdocs/support/see_request.bml
Log Message:
-----------
strip trailing whitespace
Commit: ca179ae0562d8d2b1cb53990b9f6a62200b2dcaa
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/Session.pm
M htdocs/login.bml
Log Message:
-----------
remove langpref cookie support
There was no effective way to ever set the cookie, and even
if there were, the code was never implemented to honor the
value of the cookie on non-BML pages.
Can still override the site's default language on a per-request
basis by using the "uselang" GET parameter.
Commit: 03322114a6dfd8a79da1a2d637b204f353ca98e7
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm
Log Message:
-----------
remove uses of 'browselang' in get_text calls
This prepares to get rid of the 'browselang' userprop in the next
commit; since there was no available way for the user to set it,
it was always undefined. Most of these changes simply make the
explicit choice to use $LJ::DEFAULT_LANG, which is effectively
what was happening already.
There's a subtle difference here between using LJ::Lang::ml
and using LJ::Lang::get_text with an undefined lang argument.
LJ::Lang::ml will use LJ::Lang::get_effective_lang, which picks
up any language selection from the web request. That's desired
when we're showing text to the remote user, but we don't always
want the same choice for the target of a particular action
being taken. Whereas LJ::Lang::get_text will always fall back
to the site default of $LJ::DEFAULT_LANG if the given lang is
undefined.
To make that clearer for future development, I've added a new
helper function, LJ::Lang::get_default_text, which works just
like calling LJ::Lang::get_text without the explicit undef
arguments. There's also a corresponding get_default_text_multi
for the modules that preload multiple static strings.
This may seem like overkill given our eventual aim to rip
out the translation system, but as long as we support URLs
using the "?uselang=" format, we need to make sure this
behavior is maintained.
Commit: 3b9f56d1362db54eb81a90eae1eb41bba244154d
https://github.com/dreamwidth/dw-free/
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/proplists.dat
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text
Log Message:
-----------
remove browselang userprop
Was only set in LJ::Lang::set_lang, which was only called by
LJ/Setting/Language.pm, which was unused and removed.
LJ::Lang::set_lang is retained as a stub for future replacement
of BML::set_language as we move away from using BML.
Commit: d5d49cb66fb410b732924bfeda112b8d0d501296
https://github.com/dreamwidth/dw-free/
Author: Mark Smith <mark@qq.is>
Date: 2017-03-29 (Wed, 29 Mar 2017)
Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
R cgi-bin/LJ/Setting/Language.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/manage/settings/index.bml.text
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text
Log Message:
-----------
Merge pull request #2031 from kareila/remove_setlang
Remove unused code for browselang
Compare: https://github.com/dreamwidth/dw-free/