github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2017-02-15 03:16 pm

[dreamwidth/dw-free] 2c5a6d: Use of $# considered harmful

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
https://github.com/dreamwidth/dw-free/commit/2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Use of $# considered harmful

This construction returns the index of the last item rather than the
count which means this was only returning true once the file had
replicated, which while often successful is definitely not what we want.


Commit: fd10742691d7fa50859287df90ab77a2a9145ba3
https://github.com/dreamwidth/dw-free/commit/fd10742691d7fa50859287df90ab77a2a9145ba3
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Merge pull request #1986 from zorkian/fix-off-by-one

Use of $# considered harmful


Compare: https://github.com/dreamwidth/dw-free/compare/0cf1d70e3879...fd10742691d7