github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: d90f7d3d0fea863218821e9809a5ce3c6f1163a3
https://github.com/dreamwidth/dw-free/commit/d90f7d3d0fea863218821e9809a5ce3c6f1163a3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-20 (Mon, 20 Mar 2017)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M t/cleanemail.t

Log Message:
-----------
[#2039] check for extra space in bogus_email address text

Fixes #2039.


Commit: 5283f6f69fd5418c75c5b109bbcf46f547a47896
https://github.com/dreamwidth/dw-free/commit/5283f6f69fd5418c75c5b109bbcf46f547a47896
Author: Mark Smith <mark@qq.is>
Date: 2017-03-20 (Mon, 20 Mar 2017)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M t/cleanemail.t

Log Message:
-----------
Merge pull request #2040 from kareila/2039-cleanemail

[#2039] check for extra space in bogus_email address text


Compare: https://github.com/dreamwidth/dw-free/compare/c90eedbb267a...5283f6f69fd5
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 477632185097d02d9f57b5bf285b862999eff95b
https://github.com/dreamwidth/dw-free/commit/477632185097d02d9f57b5bf285b862999eff95b
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2017-03-15 (Wed, 15 Mar 2017)

Changed paths:
M htdocs/openid/server.bml

Log Message:
-----------
Rewrite LJ's trust_root to https to match their return_to


Commit: c90eedbb267af0ef4681d586c3539fbfcd772870
https://github.com/dreamwidth/dw-free/commit/c90eedbb267af0ef4681d586c3539fbfcd772870
Author: Jen <kareila@dreamwidth.org>
Date: 2017-03-15 (Wed, 15 Mar 2017)

Changed paths:
M htdocs/openid/server.bml

Log Message:
-----------
Merge pull request #2029 from alierak/2013_lj_openid

Rewrite LJ's trust_root to https to match their return_to


Compare: https://github.com/dreamwidth/dw-free/compare/929b5e4901d5...c90eedbb267a
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: b32e76ce0a09c80629d286372f9fc7aeca1c7aec
https://github.com/dreamwidth/dw-free/commit/b32e76ce0a09c80629d286372f9fc7aeca1c7aec
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Logic/ProfilePage.pm
M htdocs/profile.bml
M htdocs/profile.bml.text
M htdocs/stc/profile.css

Log Message:
-----------
[#2023] remove status_image support from DW/Logic/ProfilePage.pm


Commit: 929b5e4901d5015eac68b0639231869b03b16623
https://github.com/dreamwidth/dw-free/commit/929b5e4901d5015eac68b0639231869b03b16623
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Logic/ProfilePage.pm
M htdocs/profile.bml
M htdocs/profile.bml.text
M htdocs/stc/profile.css

Log Message:
-----------
Merge pull request #2026 from kareila/2023-imstatus

[#2023] remove status_image support from DW/Logic/ProfilePage.pm


Compare: https://github.com/dreamwidth/dw-free/compare/aa4a44be075e...929b5e4901d5
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: f7e291e1214624fce7874ca92be2ecd249029a3d
https://github.com/dreamwidth/dw-free/commit/f7e291e1214624fce7874ca92be2ecd249029a3d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
R cgi-bin/LJ/Setting/MailEncoding.pm

Log Message:
-----------
remove unused module LJ/Setting/MailEncoding.pm


Commit: 3fd69212fdcc5a424d27909c4460638e1c562a11
https://github.com/dreamwidth/dw-free/commit/3fd69212fdcc5a424d27909c4460638e1c562a11
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/LJ/Comment.pm

Log Message:
-----------
strip trailing whitespace in DW/InviteCodeRequests.pm & LJ/Comment.pm


Commit: 63b8f49b2cd4f5d6874d39ce5f2a0b0eb5a85d64
https://github.com/dreamwidth/dw-free/commit/63b8f49b2cd4f5d6874d39ce5f2a0b0eb5a85d64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/User/Message.pm

Log Message:
-----------
remove mailencoding userprop


Commit: aa4a44be075e25628f19e965bb8774957b53792e
https://github.com/dreamwidth/dw-free/commit/aa4a44be075e25628f19e965bb8774957b53792e
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
R cgi-bin/LJ/Setting/MailEncoding.pm
M cgi-bin/LJ/User/Message.pm

Log Message:
-----------
Merge pull request #2025 from kareila/remove-mailconfig

Remove unused code for mailencoding


Compare: https://github.com/dreamwidth/dw-free/compare/76a2f297700a...aa4a44be075e
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: d90724b71bf8fbb86bcc53131f78f1480a30c229
https://github.com/dreamwidth/dw-free/commit/d90724b71bf8fbb86bcc53131f78f1480a30c229
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
[#1972] Don't require unfold_embed get_arg to expand embeds

Fixes #1972.


Commit: 76a2f297700ab5e3a41c094dfa0f7e069ae89e37
https://github.com/dreamwidth/dw-free/commit/76a2f297700ab5e3a41c094dfa0f7e069ae89e37
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
Merge pull request #2027 from kareila/1972-rss-embeds

[#1972] Don't require unfold_embed get_arg to expand embeds


Compare: https://github.com/dreamwidth/dw-free/compare/fc3360a077d2...76a2f297700a
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4fe1215a92d3977079da4c5e03f0369732699581
https://github.com/dreamwidth/dw-free/commit/4fe1215a92d3977079da4c5e03f0369732699581
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R cgi-bin/LJ/Setting/FOAFURL.pm

Log Message:
-----------
remove unused module LJ/Setting/FOAFURL.pm


Commit: af0b723a603ed858993ebae9baacccc7f743b728
https://github.com/dreamwidth/dw-free/commit/af0b723a603ed858993ebae9baacccc7f743b728
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R bin/upgrading/migrate-userprop.pl
M bin/upgrading/proplists.dat
M bin/upgrading/update-db.pl
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/User/Styles.pm

Log Message:
-----------
remove external_foaf_url userprop


Commit: 1a7b3329ef13d35ff17ed9ec5fc01f82c70f1196
https://github.com/dreamwidth/dw-free/commit/1a7b3329ef13d35ff17ed9ec5fc01f82c70f1196
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
M bin/upgrading/update-db.pl

Log Message:
-----------
strip trailing whitespace in bin/upgrading/update-db.pl


Commit: fc3360a077d25de06f418919e9263c2fd098040a
https://github.com/dreamwidth/dw-free/commit/fc3360a077d25de06f418919e9263c2fd098040a
Author: Mark Smith <mark@qq.is>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R bin/upgrading/migrate-userprop.pl
M bin/upgrading/proplists.dat
M bin/upgrading/update-db.pl
M cgi-bin/LJ/Feed.pm
R cgi-bin/LJ/Setting/FOAFURL.pm
M cgi-bin/LJ/User/Styles.pm

Log Message:
-----------
Merge pull request #2024 from kareila/remove-foafurl

Remove unused code for external_foaf_url


Compare: https://github.com/dreamwidth/dw-free/compare/7f8f41f19d42...fc3360a077d2
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: b46d5882591896da59ef1a7b430e861557fe9cb1
https://github.com/dreamwidth/dw-free/commit/b46d5882591896da59ef1a7b430e861557fe9cb1
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
A t/cleaner-markdown.t

Log Message:
-----------
[#1990] don't transform username tags in URLs

I thought about bringing out the heavy artillery (aka HTML::Parser)
but realized that even if we just transformed on plain text,
things that look like usernames in plain URLs would still be
mangled. So this just tweaks the existing regular expression to
ignore "@username" if immediately preceded by a slash.

Fixes #1990.


Commit: 7f8f41f19d4265d8342ef8f3f775886fd06977ef
https://github.com/dreamwidth/dw-free/commit/7f8f41f19d4265d8342ef8f3f775886fd06977ef
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
A t/cleaner-markdown.t

Log Message:
-----------
Merge pull request #2004 from kareila/1990-markdown-usernames

[#1990] don't transform username tags in URLs


Compare: https://github.com/dreamwidth/dw-free/compare/4924682f9d69...7f8f41f19d42
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 242782ce646d7c902d15f801951a0f1229f40ea8
https://github.com/dreamwidth/dw-free/commit/242782ce646d7c902d15f801951a0f1229f40ea8
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm

Log Message:
-----------
remove trailing whitespace in DW/Controller/Support/History.pm


Commit: f76833a122ae7a7a40c3b4c20161fc9da65b00a7
https://github.com/dreamwidth/dw-free/commit/f76833a122ae7a7a40c3b4c20161fc9da65b00a7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M views/support/history.tt
M views/support/history.tt.text

Log Message:
-----------
additional search field in template


Commit: 486a0a18d665978efb217e2f1b72edb9d60132b6
https://github.com/dreamwidth/dw-free/commit/486a0a18d665978efb217e2f1b72edb9d60132b6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
remove Dumper from DW/Controller/Support/Search.pm


Commit: f49608d5cd0954b038be4e9aac2c8c7d75174a5f
https://github.com/dreamwidth/dw-free/commit/f49608d5cd0954b038be4e9aac2c8c7d75174a5f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
refactor search task into separate function do_search


Commit: d7293bf45fc03d2ee7587225e4dfb3640a4e2473
https://github.com/dreamwidth/dw-free/commit/d7293bf45fc03d2ee7587225e4dfb3640a4e2473
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
do search from history page


Commit: 09e99f7b4f1f4a3b0b08c57751217bc2b820e711
https://github.com/dreamwidth/dw-free/commit/09e99f7b4f1f4a3b0b08c57751217bc2b820e711
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M views/support/history.tt

Log Message:
-----------
change fullsearch from get to post


Commit: 4924682f9d6975dae141e240d891b2f7b49dadbc
https://github.com/dreamwidth/dw-free/commit/4924682f9d6975dae141e240d891b2f7b49dadbc
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M cgi-bin/DW/Controller/Support/Search.pm
M views/support/history.tt
M views/support/history.tt.text

Log Message:
-----------
Merge pull request #2005 from kareila/1957-support-search

[#1957] add request text search to /support/history


Compare: https://github.com/dreamwidth/dw-free/compare/4c80f7a20d0e...4924682f9d69
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 6d446edebb2f0174fb1ffeb4d68e7f3d13d80e95
https://github.com/dreamwidth/dw-free/commit/6d446edebb2f0174fb1ffeb4d68e7f3d13d80e95
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-28 (Tue, 28 Feb 2017)

Changed paths:
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/User/Administration.pm

Log Message:
-----------
[#2016] look for both possible saved orderings

I can confirm that this lookup works in testing with unsorted data.
I'm also adding a sort to log_event so prevent similar problems
in the future, but that won't correct previously logged events.

Fixes #2016.


Commit: 4c80f7a20d0ef603bd2743ebe5ef9ec954a0366e
https://github.com/dreamwidth/dw-free/commit/4c80f7a20d0ef603bd2743ebe5ef9ec954a0366e
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/User/Administration.pm

Log Message:
-----------
Merge pull request #2017 from kareila/2016-userlog-extra

[#2016] look for both possible saved orderings


Compare: https://github.com/dreamwidth/dw-free/compare/686e56bb6f8f...4c80f7a20d0e
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: ea1056381db32d1aba1e8f12d3fc0b70638ce5d3
https://github.com/dreamwidth/dw-free/commit/ea1056381db32d1aba1e8f12d3fc0b70638ce5d3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Setting/BoolSetting.pm

Log Message:
-----------
fix undefined value warning in LJ/Setting/BoolSetting.pm

Use of uninitialized value $new_val in string eq at /home/dw/production/cgi-bin/LJ/Setting/BoolSetting.pm line 71.


Commit: 757d539303fb88717545e2cf449cf7fe99409e59
https://github.com/dreamwidth/dw-free/commit/757d539303fb88717545e2cf449cf7fe99409e59
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/RPC/Misc.pm

Log Message:
-----------
fix undefined value warning in DW/Controller/RPC/Misc.pm

Can't call method "user" on an undefined value at /home/dw/production/cgi-bin/DW/Controller/RPC/Misc.pm line 35.


Commit: 83faa4a1df8f645bdc6104507f51b32f830c957d
https://github.com/dreamwidth/dw-free/commit/83faa4a1df8f645bdc6104507f51b32f830c957d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Community.pm

Log Message:
-----------
fix undefined value warning in LJ/Community.pm

Can't call method "userid" on an undefined value at /home/dw/production/cgi-bin/LJ/Community.pm line 720.

Also strips trailing whitespace.


Commit: 96766bfa72111d5bc5cff0de6160f66e8c76498c
https://github.com/dreamwidth/dw-free/commit/96766bfa72111d5bc5cff0de6160f66e8c76498c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M bin/checkconfig.pl

Log Message:
-----------
add debian pkg name for log4perl


Commit: 3bb1cfd50e83cd23d55a2f5e564b5bb2619ab872
https://github.com/dreamwidth/dw-free/commit/3bb1cfd50e83cd23d55a2f5e564b5bb2619ab872
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
fix duplicate scoped variable warning in advanced/styles.bml

"my" variable $dis masks earlier declaration in same scope .. htdocs/customize/advanced/styles.bml line 445.


Commit: 35d9f14e4e6147f1569d0365bf1a203aec42a6e5
https://github.com/dreamwidth/dw-free/commit/35d9f14e4e6147f1569d0365bf1a203aec42a6e5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
strip trailing whitespace in /customize/advanced/styles


Commit: 1af5de9ddf1a641ada27f089446c85b7404a887c
https://github.com/dreamwidth/dw-free/commit/1af5de9ddf1a641ada27f089446c85b7404a887c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm

Log Message:
-----------
fix numeric eq warning in XPostProtocol/LJXMLRPC.pm

Argument "Client" isn't numeric in numeric eq (==) at /home/dw/production/cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm line 53.

... Yeah, I dunno either, but treating it like a string will fix the warning.


Commit: ecb3187aaee9e2ebcc4165e70b16d0386be83869
https://github.com/dreamwidth/dw-free/commit/ecb3187aaee9e2ebcc4165e70b16d0386be83869
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/InviteCodes.pm

Log Message:
-----------
fix undefined value warning in DW/Controller/InviteCodes.pm

Use of uninitialized value in numeric comparison (<=>) .. cgi-bin/DW/Controller/InviteCodes.pm line 79.


Commit: 686e56bb6f8fa1d687167e4c239e15e3fdcba6c0
https://github.com/dreamwidth/dw-free/commit/686e56bb6f8fa1d687167e4c239e15e3fdcba6c0
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M bin/checkconfig.pl
M cgi-bin/DW/Controller/InviteCodes.pm
M cgi-bin/DW/Controller/RPC/Misc.pm
M cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm
M cgi-bin/LJ/Community.pm
M cgi-bin/LJ/Setting/BoolSetting.pm
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
Merge pull request #2020 from kareila/cleanup-2017q1

more cleanup


Compare: https://github.com/dreamwidth/dw-free/compare/24b20fce013b...686e56bb6f8f
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: f443ce45af34b61409a5b3099ece530652cbf60e
https://github.com/dreamwidth/dw-free/commit/f443ce45af34b61409a5b3099ece530652cbf60e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller.pm

Log Message:
-----------
[#2003] also use error header for Cache-Control

@alierak explains that there are two header tables, one
for successes (which header_out uses) and one for errors
and redirects (which err_header_out uses). So we need to
make sure that user cookie bounces use err_header_out to
avoid caching.

He says we could probably set this header on every request,
but let's start with the one place where we know we need it.

(Most of this is whitespace cleanup; the last line is the
bit that does the thing.)


Commit: 1d34018a37d8653db5123fe1200bc9d985de6283
https://github.com/dreamwidth/dw-free/commit/1d34018a37d8653db5123fe1200bc9d985de6283
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
also use no-cache for image load 403 errors


Compare: https://github.com/dreamwidth/dw-free/compare/861a018829ee...1d34018a37d8
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e31ba34c645c9967594e70615a8a0d00fdb587ae
https://github.com/dreamwidth/dw-free/commit/e31ba34c645c9967594e70615a8a0d00fdb587ae
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller.pm

Log Message:
-----------
[#2003] also use error header for Cache-Control

@alierak explains that there are two header tables, one
for successes (which header_out uses) and one for errors
and redirects (which err_header_out uses). So we need to
make sure that user cookie bounces use err_header_out to
avoid caching.

He says we could probably set this header on every request,
but let's start with the one place where we know we need it.

(Most of this is whitespace cleanup; the last line is the
bit that does the thing.)


Commit: ede6a2b9a5fe87800aa18978e2f4b5127d710449
https://github.com/dreamwidth/dw-free/commit/ede6a2b9a5fe87800aa18978e2f4b5127d710449
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
also use no-cache for image load 403 errors


Commit: 24b20fce013bdd5e273077aa3818ade31b52e00e
https://github.com/dreamwidth/dw-free/commit/24b20fce013bdd5e273077aa3818ade31b52e00e
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller.pm
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
Merge pull request #2007 from kareila/cache-control

[#2003] also use error header for Cache-Control


Compare: https://github.com/dreamwidth/dw-free/compare/8410894ea119...24b20fce013b
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: 941441147bd95f6b345d38c69eee4f6ddb958190
https://github.com/dreamwidth/dw-free/commit/941441147bd95f6b345d38c69eee4f6ddb958190
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 8f7953dd1501b11c3db6f4a04f506e75b9916c18
https://github.com/dreamwidth/dw-free/commit/8f7953dd1501b11c3db6f4a04f506e75b9916c18
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: 861a018829ee0ae2c67b2a490413c44550976e08
https://github.com/dreamwidth/dw-free/commit/861a018829ee0ae2c67b2a490413c44550976e08
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Compare: https://github.com/dreamwidth/dw-free/compare/e05fe1281a79...861a018829ee
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 7400b91371eecaf4e604b2085d35a05c72dfc5a5
https://github.com/dreamwidth/dw-free/commit/7400b91371eecaf4e604b2085d35a05c72dfc5a5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Commit: 8410894ea119c8fe13b0ccb88db949c9ece082f9
https://github.com/dreamwidth/dw-free/commit/8410894ea119c8fe13b0ccb88db949c9ece082f9
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
Merge pull request #2003 from kareila/media-headers

additional headers for media file requests


Compare: https://github.com/dreamwidth/dw-free/compare/ecba2a889335...8410894ea119
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e69b60fbd008183682bf8f910f54cc61c6e11ecd
https://github.com/dreamwidth/dw-free/commit/e69b60fbd008183682bf8f910f54cc61c6e11ecd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf

Log Message:
-----------
[#1988] remove LJ/EventLogRecord.pm and submodules

Fixes #1988.


Commit: fd912965db3686b34ff5e93dd57551504e3d9280
https://github.com/dreamwidth/dw-free/commit/fd912965db3686b34ff5e93dd57551504e3d9280
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M t/post.t

Log Message:
-----------
removal of EventLogRecord from postevent causes test failures

Failed test 'Public security'
at t/post.t line 394.
got: undef
expected: 'public'

Failed test 'Public security'
at t/post.t line 403.
got: undef
expected: 'public'

Failed test 'Locked security'
at t/post.t line 415.
got: undef
expected: 'usemask'

In all three cases, changing $entry->{security} to $entry->security
fixed the problem, because that causes the object's hash data to be
populated. Previously, the data was populated within the context of
the EventLogRecord job in postevent.


Commit: 4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
https://github.com/dreamwidth/dw-free/commit/4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use another method to repopulate the entry object data

At first I thought I would need to audit the code for
uses of $entry->{security} instead of $entry->security,
and while I did find and change a few of those, I quickly
realized a less scattershot approach would be to drop in
another method call in place of the removed one that had
the same side effect of populating the data in the cached
entry object.

With that done, the failing test once again passes
(although I'm still committing the fixed version).


Commit: ecba2a889335572f0ff0125eee0d9ca1b9eda166
https://github.com/dreamwidth/dw-free/commit/ecba2a889335572f0ff0125eee0d9ca1b9eda166
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf
M t/post.t

Log Message:
-----------
Merge pull request #1994 from kareila/1988-EventLogRecord

[#1988] remove LJ/EventLogRecord.pm and submodules


Compare: https://github.com/dreamwidth/dw-free/compare/ea34b74fd0ae...ecba2a889335
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: c172a10daa9e7f9c6aea4a66f92581555d5f612f
https://github.com/dreamwidth/dw-free/commit/c172a10daa9e7f9c6aea4a66f92581555d5f612f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
https://github.com/dreamwidth/dw-free/commit/ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
Merge pull request #2002 from kareila/1855-null-mediaid

[#1855] improve handling of media load errors on /file/edit


Compare: https://github.com/dreamwidth/dw-free/compare/04b517843619...ea34b74fd0ae
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4b4f745e77f45cb387c65819c5d7a15618c231ea
https://github.com/dreamwidth/dw-free/commit/4b4f745e77f45cb387c65819c5d7a15618c231ea
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 04b51784361961dfcbbd70112b08b0cf49b901d0
https://github.com/dreamwidth/dw-free/commit/04b51784361961dfcbbd70112b08b0cf49b901d0
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #2001 from kareila/1983-autoscale

[#1983] fix one more occurrence of reference mismatch errors


Compare: https://github.com/dreamwidth/dw-free/compare/e94a1a9b5351...04b517843619
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
https://github.com/dreamwidth/dw-free/commit/1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use correct user object when deleting existing slugs

Fixes #1992.


Commit: e94a1a9b5351bdbc75ba2acb971cc0770237a584
https://github.com/dreamwidth/dw-free/commit/e94a1a9b5351bdbc75ba2acb971cc0770237a584
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
Merge pull request #1993 from kareila/1992-edit-slugs

use correct user object when deleting existing slugs


Compare: https://github.com/dreamwidth/dw-free/compare/b49f98c67974...e94a1a9b5351
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: eb9640e01dd422685ec586c2cef703c0474d49c5
https://github.com/dreamwidth/dw-free/commit/eb9640e01dd422685ec586c2cef703c0474d49c5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Feeds.pm

Log Message:
-----------
fix undefined warning in DW/Controller/Feeds.pm

Use of uninitialized value in pattern match (m//) at /home/dw/production/cgi-bin/DW/Controller/Feeds.pm line 72.


Commit: 29afdd466c3857ecf573dbbbed8d9226a56682f6
https://github.com/dreamwidth/dw-free/commit/29afdd466c3857ecf573dbbbed8d9226a56682f6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix undefined warning in DW/Controller/EditIcons.pm

Use of uninitialized value in string eq .. cgi-bin/DW/Controller/EditIcons.pm line 163.


Commit: 60d05bad8ddbd27c656865e8db30679289757d13
https://github.com/dreamwidth/dw-free/commit/60d05bad8ddbd27c656865e8db30679289757d13
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined warning in LJ/Userpic.pm

Use of uninitialized value $w in numeric ge (>=) .. cgi-bin/LJ/Userpic.pm line 682.


Commit: b2ab126f4681dd98e213752dfaa2f105154a9b64
https://github.com/dreamwidth/dw-free/commit/b2ab126f4681dd98e213752dfaa2f105154a9b64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
avoid die statement in LJ/Poll.pm

Error loading poll id: 1903855: Invalid journalid at /home/dw/production/cgi-bin/LJ/Poll.pm line 558.

This seemed the best course of action, since we're also
returning undef if the subsequent row lookup fails.


Commit: 1b9abedbfbaf852114844964841b8d6209026698
https://github.com/dreamwidth/dw-free/commit/1b9abedbfbaf852114844964841b8d6209026698
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
avoid calling method on undefined object in DW/Routing.pm

Can't call method "journal_base" on an undefined value at /home/dw/production/cgi-bin/DW/Routing.pm line 209

Tweak the conditional logic so that $renamed_u must be
valid if we want to redirect to it.


Commit: ae9ef2cf874669c36829ad8b13129a0b4770ba8e
https://github.com/dreamwidth/dw-free/commit/ae9ef2cf874669c36829ad8b13129a0b4770ba8e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/ChangeEmail.pm

Log Message:
-----------
fix undefined warning in DW/Controller/ChangeEmail.pm

Use of uninitialized value in string ne at /home/dw/production/cgi-bin/DW/Controller/ChangeEmail.pm line 84.

First, we don't need to check is_identity when assigning $password,
because we check for it in the conditional.

Second, we should actually use $password if we assign it.

Third, put the short-circuit check ($remote->is_identity)
first, to avoid unnecessarily checking a string that will
be undefined in that particular case.

Fourth, OK to error if $password is undef, since that can never be
the correct password. Identity accounts can have undefined pws
but we've already accounted for that.


Commit: 850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
https://github.com/dreamwidth/dw-free/commit/850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
fix undefined warning in DW/Controller/API/Media.pm

Use of uninitialized value $type in numeric eq (==) at /home/dw/production/cgi-bin/DW/Controller/API/Media.pm line 74.


Commit: 1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
https://github.com/dreamwidth/dw-free/commit/1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
remove unused variable from DW::Routing


Commit: b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
https://github.com/dreamwidth/dw-free/commit/b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Feeds.pm
M cgi-bin/DW/Routing.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #1991 from kareila/cleanup-2017q1

Post-push log cleanup


Compare: https://github.com/dreamwidth/dw-free/compare/fd10742691d7...b49f98c67974
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
https://github.com/dreamwidth/dw-free/commit/2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Use of $# considered harmful

This construction returns the index of the last item rather than the
count which means this was only returning true once the file had
replicated, which while often successful is definitely not what we want.


Commit: fd10742691d7fa50859287df90ab77a2a9145ba3
https://github.com/dreamwidth/dw-free/commit/fd10742691d7fa50859287df90ab77a2a9145ba3
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Merge pull request #1986 from zorkian/fix-off-by-one

Use of $# considered harmful


Compare: https://github.com/dreamwidth/dw-free/compare/0cf1d70e3879...fd10742691d7

Profile

Dreamwidth Changelog

March 2017

S M T W T F S
   1 234
5678910 11
12 1314 15161718
19 202122232425
262728293031 

Syndicate

RSS Atom

Most Popular Tags

Page Summary

Style Credit

Expand Cut Tags

No cut tags
Page generated Mar. 24th, 2017 02:15 am
Powered by Dreamwidth Studios